From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#17544: 24.3; [PATCH] Improved diff-mode navigation/manipulation Date: Sat, 22 Oct 2016 11:47:29 -0400 Message-ID: <874m44tmge.fsf@users.sourceforge.net> References: <87ha4jgw53.fsf@secretsauce.net> <87si0ion1c.fsf@gnus.org> <87k2et8hr4.fsf@secretsauce.net> <83a8fpe1dr.fsf@gnu.org> <87h99w8ynv.fsf@secretsauce.net> <87k2es9weh.fsf@users.sourceforge.net> <87oa4018r3.fsf@secretsauce.net> <87twdi6rm9.fsf@secretsauce.net> <87h997nkqp.fsf@secretsauce.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1477151248 25313 195.159.176.226 (22 Oct 2016 15:47:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 22 Oct 2016 15:47:28 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: Andreas Schwab , 17544@debbugs.gnu.org To: Dima Kogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 22 17:47:24 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxyVv-0004pS-18 for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Oct 2016 17:47:15 +0200 Original-Received: from localhost ([::1]:37782 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxyVx-00079e-3H for geb-bug-gnu-emacs@m.gmane.org; Sat, 22 Oct 2016 11:47:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bxyVn-00078a-4k for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 11:47:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bxyVi-0004qo-Gs for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 11:47:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59335) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bxyVi-0004qk-Di for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 11:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bxyVi-0000wj-3S for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2016 11:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2016 15:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 17544-submit@debbugs.gnu.org id=B17544.14771512193628 (code B ref 17544); Sat, 22 Oct 2016 15:47:02 +0000 Original-Received: (at 17544) by debbugs.gnu.org; 22 Oct 2016 15:46:59 +0000 Original-Received: from localhost ([127.0.0.1]:46501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxyVf-0000wS-BH for submit@debbugs.gnu.org; Sat, 22 Oct 2016 11:46:59 -0400 Original-Received: from mail-it0-f68.google.com ([209.85.214.68]:34214) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bxyVd-0000wF-NN for 17544@debbugs.gnu.org; Sat, 22 Oct 2016 11:46:58 -0400 Original-Received: by mail-it0-f68.google.com with SMTP id e203so3622873itc.1 for <17544@debbugs.gnu.org>; Sat, 22 Oct 2016 08:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WK2esMgWh56KVD7Sg+8m8IlI8f0TyDEMZ5QLPgOpx/g=; b=oIVRLMU2BMmhX9v4emmfHT0mjVNNxvFyCwayFYkv7bHVPmmBgy15GHWMhSCAnmIRo2 480pnBXmsUiNWp34avhI7FWS/VZjzin1Era5Cv+SrdmmidXBsYpH0urGkT+9TPWvOVXU ZvzyABzzmkW3uBDqhFlanOmCWlwBsx8HLu4olNU7i5ymQL4V5d+YJ4j7q9d/bLWkT5pd /vEdz1To9K/GAa8JXdV2IZfbT8WcRQ7Rzd5UpXoMpILRZe9Uomf0ub9d5pSKzULK3L4E 1dy61rRioZ+NgRx2PbeYOHGsCl1jz1Efr16ePOXGcNbWRNapwkpUHfC44Y3uDTq3/ndR MzdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=WK2esMgWh56KVD7Sg+8m8IlI8f0TyDEMZ5QLPgOpx/g=; b=SjXDREY5ViX9ZpnKOB4IDQV9MSfc9EgeoNjQKl4GWVx5Qupdf4HKW1HO69o55ByEgb 8kocKjt0R774Emvpy2noOj2Mrc2eGv79yz5EE4LDL4lIrCKaoPUMT054ELSOiDSMtHZw RhfSUrjedDYaEau/UMvWlp9B26uZT8c60p3yiab5KzHBNxpocDK/NUVeJCRLhEpxYjl5 0guGcQTHXwWpyJJeUfrUmbXa35d4wQ7WKyMORRtwIK0Em4re8jbMEuVr0O+wY1XCDbX7 yJDz0eqlB17kBqMLkOaiUH/rqje4hRfDCi7wtrtQKEe0FjEmWyU8IRdiyShp/kq04nue ZkGw== X-Gm-Message-State: ABUngveFu9iTGdi590DLBKLmsgQyqMcxEZX8NS46Afl55bgZfZUMNHW2aJqLZitKH3qaAQ== X-Received: by 10.36.68.65 with SMTP id o62mr6036285ita.82.1477151212082; Sat, 22 Oct 2016 08:46:52 -0700 (PDT) Original-Received: from zony ([45.2.7.130]) by smtp.googlemail.com with ESMTPSA id 80sm3970950iot.36.2016.10.22.08.46.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Oct 2016 08:46:51 -0700 (PDT) In-Reply-To: <87h997nkqp.fsf@secretsauce.net> (Dima Kogan's message of "Fri, 23 Sep 2016 00:22:38 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124838 Archived-At: Dima Kogan writes: > Here's yet another revised patch. The (call-interactively) at the end of > (diff-apply-hunk) was important, it turns out. This would force it to > use the new logic to move to the next hunk, instead of the legacy logic. > I purposely left the behavior of (diff-next-hunk) unchanged from before > when running non-interactively, and here I explicitly want the new > behavior. If both behaviours are needed, it would be much better if lisp code could choose between them without having to use call-interactively, that's quite an awkward interface.