From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: npostavs@users.sourceforge.net Newsgroups: gmane.emacs.bugs Subject: bug#25936: Fix for whitespace.el to make it read tab-width and indent-tabs-mode correctly Date: Thu, 23 Mar 2017 20:06:51 -0400 Message-ID: <874lyj4jxg.fsf@users.sourceforge.net> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1490313979 30574 195.159.176.226 (24 Mar 2017 00:06:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 24 Mar 2017 00:06:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 25936@debbugs.gnu.org, Stephen Deasey , Vinicius Jose Latorre To: Reuben Thomas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 24 01:06:14 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crCk5-0006jP-UC for geb-bug-gnu-emacs@m.gmane.org; Fri, 24 Mar 2017 01:06:10 +0100 Original-Received: from localhost ([::1]:59268 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crCk9-0005SD-UX for geb-bug-gnu-emacs@m.gmane.org; Thu, 23 Mar 2017 20:06:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36538) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1crCk3-0005S6-Ri for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2017 20:06:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1crCjy-0001As-IF for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2017 20:06:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43352) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1crCjy-0001Ao-DA for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2017 20:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1crCjx-000656-Uu for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2017 20:06:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Mar 2017 00:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25936 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 25936-submit@debbugs.gnu.org id=B25936.149031393823342 (code B ref 25936); Fri, 24 Mar 2017 00:06:01 +0000 Original-Received: (at 25936) by debbugs.gnu.org; 24 Mar 2017 00:05:38 +0000 Original-Received: from localhost ([127.0.0.1]:41551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crCjZ-00064Q-NX for submit@debbugs.gnu.org; Thu, 23 Mar 2017 20:05:37 -0400 Original-Received: from mail-io0-f173.google.com ([209.85.223.173]:35029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crCjW-00064C-KH for 25936@debbugs.gnu.org; Thu, 23 Mar 2017 20:05:35 -0400 Original-Received: by mail-io0-f173.google.com with SMTP id z13so7880760iof.2 for <25936@debbugs.gnu.org>; Thu, 23 Mar 2017 17:05:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=PTyc4Nl8diHuJ6BHLgM+X67x+j1gJFxtsABV1ZxppJ0=; b=IBV16T4KCWIN3jSD11M8k99kXWO+ZJF/Li5yP8Jf1pqGWmsORhKkn/IpIYrkDtAF8n yp+BQpiTTkbEawsibC8yVYLbb3Ro+wo8vK4QIX05eELewsGYqQh8L11w+vUGluKywZkl LHp0YtQFDuDRHgYLj72J4SCzMhkhTvhvTbrD3ESIN/WvjxXaEtu1YvteDhLchwEu4hSh ysFDqSU+8nXwg1t7//S1+ZoV1JVxFCmuB8kRy1Aqk0YOXOw6SjvRCF5FTsD14wnmerYS bpMPl42v4dpzAQhNWaBcjSOVtR3jpXsSI+PXa/qmXrEPXY1erHkEGfpuUwtOpktYzC7J P8+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=PTyc4Nl8diHuJ6BHLgM+X67x+j1gJFxtsABV1ZxppJ0=; b=iS/B9q1Jzi01Yuozw9E+g/eeF+eTJ5eOPcCg1u/Ao3VICscSR5p8LafGoBdE367xXM 9HCuiJiT5glLSrwM635i520b5mqHBrjFvwD7dXp+MNA4QwALkBvLMsmSh9Gaz1Hai5TZ A5tbDpJ68vhfvU4E1d2G56n7rc3lk9oIircJhwwXyMqSO/eQKHCENj+TrHlVrDzPfZDR DcNSrnkczB3+Z05s7gO7sX/J8q45Xt7l5/LrFH9tAEqMEf/eILGUwpjuzp9zZRUOwt0L pMdMHW1+hKfOrExEJVg09LRkazCn4f9JVKTRBOKy/zayCwfG6BzxpzC6PLUOsch6YKGv 42rA== X-Gm-Message-State: AFeK/H0ULekYroJRJOb7zHkni3DvRJw6NYSSviPkskRO0HkZA2DHuFtDN+duDoxNpnskqg== X-Received: by 10.107.205.197 with SMTP id d188mr5359394iog.206.1490313929059; Thu, 23 Mar 2017 17:05:29 -0700 (PDT) Original-Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id g103sm393234iod.44.2017.03.23.17.05.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Mar 2017 17:05:28 -0700 (PDT) In-Reply-To: (Reuben Thomas's message of "Thu, 2 Mar 2017 13:48:19 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:130861 Archived-At: Reuben Thomas writes: > However, on further investigation, I can't see why these local variables > are needed. Currently, whitespace-mode makes buffer-local copies of > indent-tabs-mode and tab-width, with names prefixed by "whitespace-". But > these variables are buffer-local if necessary already, and whitespace-mode > never tries to change them. These variables seem to have been introduced in [1: 55d1cfe870]. I agree that it looks like there is no need for them, but I'll wait another couple weeks in case someone else has some insights. Adding author of that commit (and the person mentioned as "suggesting" it) on CC in case they might remember anything about it. 1: 2008-04-16 03:41:17 +0000 55d1cfe8703c5829bacc8d129277f1f9b33950f6 Honor the indent-tabs-mode and tab-width setting from user.