unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: Glenn Morris <rgm@gnu.org>
Cc: 27708@debbugs.gnu.org, eggert@cs.ucla.edu
Subject: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc.
Date: Thu, 03 Aug 2017 16:20:12 -0400	[thread overview]
Message-ID: <874lto9zer.fsf@lifelogs.com> (raw)
In-Reply-To: <pf3798tz3t.fsf@fencepost.gnu.org> (Glenn Morris's message of "Thu, 03 Aug 2017 12:06:30 -0400")

On Thu, 03 Aug 2017 12:06:30 -0400 Glenn Morris <rgm@gnu.org> wrote: 

GM> This causes a test failure in test-gnutls-000-availability.
GM> https://hydra.nixos.org/build/57926906

GM> (Reproduced on rhel7 with gnutls-3.3.24.)

I think that this means that one of MD5, SHA1, SHA224, SHA256, SHA384,
or SHA512 (the `secure-hash-algorithms' members currently) are not in
that version of GnuTLS.

That is not really necessary. I was overzealous writing the tests; we
can just test the `secure-hash-algorithms' that are in GnuTLS. Can we
check the patch below against Hydra without pushing it to master yet?

(I'm having a strange problem building Emacs as of this morning, so I
haven't been able to test the patch fully. Sorry.)

Thanks
Ted

diff --git a/test/lisp/net/gnutls-tests.el b/test/lisp/net/gnutls-tests.el
index 9dbb6c05b9..94dcb6c4ce 100644
--- a/test/lisp/net/gnutls-tests.el
+++ b/test/lisp/net/gnutls-tests.el
@@ -41,8 +41,10 @@ gnutls-tests-hexstring-equal
   (and (stringp a) (stringp b) (string-equal (encode-hex-string a) (encode-hex-string b))))

 (defvar gnutls-tests-internal-macs-upcased
-  (mapcar (lambda (sym) (cons sym (intern (upcase (symbol-name sym)))))
-          (secure-hash-algorithms)))
+  (cl-intersection
+   (mapcar (lambda (sym) (cons sym (intern (upcase (symbol-name sym)))))
+           (secure-hash-algorithms))
+   (mapcar 'car (gnutls-macs))))

 (defvar gnutls-tests-tested-macs
   (when (gnutls-available-p)






  reply	other threads:[~2017-08-03 20:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-15 16:14 bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc Paul Eggert
2017-07-15 16:33 ` Eli Zaretskii
2017-07-15 19:11   ` Ted Zlatanov
2017-07-15 19:22     ` Eli Zaretskii
2017-07-16  0:31       ` Paul Eggert
2017-07-16  2:36         ` Eli Zaretskii
2017-07-16 15:18           ` Paul Eggert
2017-07-16 16:08             ` Eli Zaretskii
2017-07-17 15:03               ` Ted Zlatanov
2017-07-26 21:04                 ` Ted Zlatanov
2017-07-26 23:23                   ` Paul Eggert
2017-07-27 21:11                     ` Ted Zlatanov
2017-08-03  2:50                       ` Paul Eggert
2017-08-03 16:06                         ` Glenn Morris
2017-08-03 20:20                           ` Ted Zlatanov [this message]
2017-08-03 20:31                             ` Paul Eggert
2017-08-03 20:45                               ` Ted Zlatanov
2017-08-03 21:32                             ` Glenn Morris
2017-08-04  1:41                               ` Paul Eggert
2017-08-04 13:32                                 ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lto9zer.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=27708@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).