From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Date: Sat, 14 Oct 2017 19:47:15 -0400 Message-ID: <874lr19trw.fsf@users.sourceforge.net> References: <87infi9t0p.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1508024904 9029 195.159.176.226 (14 Oct 2017 23:48:24 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 14 Oct 2017 23:48:24 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.60 (gnu/linux) Cc: 28803@debbugs.gnu.org To: John Williams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 15 01:48:17 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3WA6-0000Co-QV for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Oct 2017 01:48:10 +0200 Original-Received: from localhost ([::1]:55505 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3WAB-0000k1-0b for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Oct 2017 19:48:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46181) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e3WA3-0000jl-1X for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 19:48:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e3W9y-0002GQ-WC for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 19:48:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60295) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e3W9y-0002Fc-R9 for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 19:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e3W9y-0001YY-Co for bug-gnu-emacs@gnu.org; Sat, 14 Oct 2017 19:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Oct 2017 23:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.15080248465913 (code B ref 28803); Sat, 14 Oct 2017 23:48:02 +0000 Original-Received: (at 28803) by debbugs.gnu.org; 14 Oct 2017 23:47:26 +0000 Original-Received: from localhost ([127.0.0.1]:40740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3W9N-0001XH-PP for submit@debbugs.gnu.org; Sat, 14 Oct 2017 19:47:26 -0400 Original-Received: from mail-io0-f177.google.com ([209.85.223.177]:46585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e3W9L-0001X2-Jl for 28803@debbugs.gnu.org; Sat, 14 Oct 2017 19:47:24 -0400 Original-Received: by mail-io0-f177.google.com with SMTP id 101so12480413ioj.3 for <28803@debbugs.gnu.org>; Sat, 14 Oct 2017 16:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=HtQjyUHBi5FsczsJRvR8lO8/sHDr2FXSShavAtLSlfk=; b=LfwjzJ5ei+E0ibip6BHJ2ghw/X1P23rO7QwnUVsXpoexhFFXs41GAwzEyKPFPQd0VK 1Qny3abnDIEJMzPGni+cYoU/Mlr9NjZNNHRpke/Mj0jZuUcBXMlX0ixVXETagnzywbGw 1en0vHQJ+yljm3LlO8hYO3HRx2N5HqFQoilZa48i+dyatm3Z65BIVzLM2pLxdUfjnWdQ PnJnYEHbYQvD0d3GhBQyWwgiCKf85mteFUjfrsZgiOTmCbgbzYXp+hPc2adjVJobT7V5 Pl1OuncCZUPZp+G1Z4ajNY2dHLjYKdp6dRr1X1R+td28dckgkZY5XMkoOd2fYSAcsC1w 2SFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=HtQjyUHBi5FsczsJRvR8lO8/sHDr2FXSShavAtLSlfk=; b=R5fLsbJ7RwnXu7bNB6t8pUdve0cYODHTIAEGGlnG04MBQpZAV0mU1RgZMldCmE/StN VgH3vbs5LJ6b6hOOaeL7L6t+n2gT0BGviwPRe8p4oSBozGhitUEvdTqakfsuFZzvVNdn 9WKHeT+wK1+1xyjip46Gm2DEN5eYHavYpSzdE0LH/ULzeBm6kDIJ2TncqVbp0vOhkrxL uuWBlOxpbI93k4/194MRJN8rggGeF48UHNXzLiGLj8nsuNzl3HgKoQ8DGuS8/OGQ5hDT QRAJYQOCnH/nBiKpAKF+G5b6y8qzrRVQgnORdV5h7stJuia61d9heJeY5P2y1AtYBv8U NaUw== X-Gm-Message-State: AMCzsaXtI8sI/fagaF+BuT4WB2vqEqHg3DA2qkdS9Njr4Z1tecx5PMNS EQl0xWl+MRrLCl9Dmi9/ASVOkg== X-Google-Smtp-Source: ABhQp+RT8lXJUuET9HiKiP8f2HdFuTZaGFDerOhtWu96Q3Gsvq/ImTvc5aps2TpL3aXHlj4QhapsGA== X-Received: by 10.107.159.5 with SMTP id i5mr6572261ioe.300.1508024837599; Sat, 14 Oct 2017 16:47:17 -0700 (PDT) Original-Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id c13sm2201089itd.32.2017.10.14.16.47.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 14 Oct 2017 16:47:16 -0700 (PDT) In-Reply-To: (John Williams's message of "Sat, 14 Oct 2017 15:55:21 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138429 Archived-At: John Williams writes: > Oops. Is there anything that can be salvaged from my patch? Aside > from fixing the bug, it also adds a unit test and refactors the logic > for finding a function's argument list into a separate function > that's not part of the help system. We could add the test, it seems to be passing in emacs-26. Have you assigned copyright to Emacs? (It's okay if you haven't, the patch is small enough to go in regardless, we would just need to mark it.) I don't think there's much need for moving the function argument retrieval out of the help system. (By the way, if you've spent some time looking at help-function-arglist, perhaps you have some ideas about Bug#26270? https://debbugs.gnu.org/cgi/bugreport.cgi?bug=26270)