unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Noam Postavsky <npostavs@users.sourceforge.net>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 20609@debbugs.gnu.org
Subject: bug#20609: 25.0.50; How to I easily generate the "action stamp" given a commit hash?
Date: Mon, 27 Nov 2017 08:08:24 -0500	[thread overview]
Message-ID: <874lpfoomv.fsf@users.sourceforge.net> (raw)
In-Reply-To: <86617on3so.fsf@yandex.ru> (Dmitry Gutov's message of "Tue, 19 May 2015 15:35:19 +0300")

[-- Attachment #1: Type: text/plain, Size: 703 bytes --]

Dmitry Gutov <dgutov@yandex.ru> writes:

> CONTRIBUTE prohibits referencing commits the easy way, and instead asks
> me to use "RFC3339 date followed by followed by the committer's email".
>
> If reversing this decision is not an option

I would like to propose doing away with this "action stamp" thing.  It
is okay for its original purpose: an almost-guaranteed-unique identifier
for an automated repository format conversion tool.  But it is not very
human-readable.  It is fairly awkward to come up with a git command that
comes up with the correct UTC timestamp.  We hardly use it anyway.

Giving just the date (no timestamp) plus summary line should be unique
enough, and is very human readable.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1199 bytes --]

From e2bfcc9f9a51e33215d30d4226216c029c182ec3 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Mon, 27 Nov 2017 07:56:39 -0500
Subject: [PATCH] * CONTRIBUTE: Don't recommend action stamps (Bug#20609).

---
 CONTRIBUTE | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/CONTRIBUTE b/CONTRIBUTE
index c324375bb0..79c127fbdc 100644
--- a/CONTRIBUTE
+++ b/CONTRIBUTE
@@ -232,10 +232,9 @@ them right the first time, so here are guidelines for formatting them:
   switches to a different VCS.  So we recommend against that.
 
   One way to identify revisions is by quoting their summary line.
-  Another is with an action stamp - an RFC3339 date followed by !
-  followed by the committer's email - for example,
-  "2014-01-16T05:43:35Z!esr@thyrsus.com".  Often, "my previous commit"
-  will suffice.
+  Prefixing the summary with the commit date can give useful context
+  (use 'git show -s "--pretty=format:%cd \"%s\"" --date=short HASH' to
+  produce that).  Often, "my previous commit" will suffice.
 
 - There is no need to mention files such as NEWS and MAINTAINERS, or
   to indicate regeneration of files such as 'lib/gnulib.mk', in the
-- 
2.11.0


  reply	other threads:[~2017-11-27 13:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 12:35 bug#20609: 25.0.50; How to I easily generate the "action stamp" given a commit hash? Dmitry Gutov
2017-11-27 13:08 ` Noam Postavsky [this message]
2019-09-29 23:57 ` Stefan Kangas
2019-10-03 12:53   ` Noam Postavsky
2020-09-25 14:11     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874lpfoomv.fsf@users.sourceforge.net \
    --to=npostavs@users.sourceforge.net \
    --cc=20609@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).