From: Noam Postavsky <npostavs@gmail.com>
To: "Clément Pit-Claudel" <clement.pitclaudel@live.com>
Cc: 30812@debbugs.gnu.org, jeffersoncarpenter2@gmail.com
Subject: bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de)
Date: Tue, 20 Mar 2018 20:26:39 -0400 [thread overview]
Message-ID: <874llatgsg.fsf@gmail.com> (raw)
In-Reply-To: <c2760cec-0a04-2cb0-a5b4-bb7d1df212e5@live.com> ("Clément Pit-Claudel"'s message of "Tue, 13 Mar 2018 19:14:56 -0400")
unarchive 27613
notfixed 27613 26.1
quit
Clément Pit-Claudel <clement.pitclaudel@live.com> writes:
> I think the following commit was a bit too enthusiastic, as variables
> like @temp are now highlighted in font-lock-type-face.
I've reverted this from emacs-26 [1: f8cad16bb3].
> - ("\\<\\(local\\|my\\)\\>" . font-lock-type-face)
> + ;; Fontify declarators and prefixes as types.
> + ("\\<\\(anon\\|argument\\|has\\|local\\|my\\|our\\|state\\|supersede\\)\\>" . font-lock-type-face) ; declarators
> + ("\\<\\(let\\|temp\\)\\>" . font-lock-type-face) ; prefixes
> Am I missing something? (I don't speak Perl, so I noticed this in a regression test)
I missed this in the originating thread, but according to what I'm
getting from web searches, most of those keywords are perl 6 specific.
I think perl-mode shouldn't support them.
[1: f8cad16bb3]: 2018-03-20 20:14:40 -0400
Revert "Support all perl variable declarators and prefixes"
https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=f8cad16bb3272a8069b3008019f9d18516aef1a5>
next prev parent reply other threads:[~2018-03-21 0:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 23:14 bug#30812: Perl syntax highlighting regression in fix for #27613? (feecb66b6fe41c977b8e11b5f2d419c9544f42de) Clément Pit-Claudel
2018-03-21 0:26 ` Noam Postavsky [this message]
2018-03-21 4:21 ` Clément Pit-Claudel
2020-08-22 16:03 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874llatgsg.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=30812@debbugs.gnu.org \
--cc=clement.pitclaudel@live.com \
--cc=jeffersoncarpenter2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).