From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#31388: 27.0.50; message-mode hard-codes key bindings in docstring Date: Tue, 08 May 2018 20:06:26 +0100 Message-ID: <874lji6k7h.fsf@tcd.ie> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1525806314 856 195.159.176.226 (8 May 2018 19:05:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 8 May 2018 19:05:14 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Lars Ingebrigtsen To: 31388@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 08 21:05:10 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fG7v8-0008Ta-MK for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 May 2018 21:05:06 +0200 Original-Received: from localhost ([::1]:52951 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG7xF-0006ix-KT for geb-bug-gnu-emacs@m.gmane.org; Tue, 08 May 2018 15:07:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG7x6-0006is-OB for bug-gnu-emacs@gnu.org; Tue, 08 May 2018 15:07:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG7x1-0007LK-Pv for bug-gnu-emacs@gnu.org; Tue, 08 May 2018 15:07:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46627) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fG7x1-0007LE-M8 for bug-gnu-emacs@gnu.org; Tue, 08 May 2018 15:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fG7x0-0004WG-DK; Tue, 08 May 2018 15:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: larsi@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 May 2018 19:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 31388 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Lars Ingebrigtsen Original-Received: via spool by submit@debbugs.gnu.org id=B.152580640817350 (code B ref -1); Tue, 08 May 2018 19:07:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 May 2018 19:06:48 +0000 Original-Received: from localhost ([127.0.0.1]:54523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fG7wm-0004Vm-2Q for submit@debbugs.gnu.org; Tue, 08 May 2018 15:06:48 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fG7wk-0004Va-R9 for submit@debbugs.gnu.org; Tue, 08 May 2018 15:06:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG7we-0007Ct-P8 for submit@debbugs.gnu.org; Tue, 08 May 2018 15:06:41 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:58717) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fG7we-0007Cn-Lw for submit@debbugs.gnu.org; Tue, 08 May 2018 15:06:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36981) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG7wd-0006iB-Kx for bug-gnu-emacs@gnu.org; Tue, 08 May 2018 15:06:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG7wY-0007A6-Lv for bug-gnu-emacs@gnu.org; Tue, 08 May 2018 15:06:39 -0400 Original-Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:35446) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fG7wY-00078s-Ea for bug-gnu-emacs@gnu.org; Tue, 08 May 2018 15:06:34 -0400 Original-Received: by mail-wm0-x22d.google.com with SMTP id o78-v6so23471011wmg.0 for ; Tue, 08 May 2018 12:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:mail-followup-to:date:message-id:user-agent :mime-version:content-transfer-encoding; bh=umbE7geYxzwHJqv1joeSmlv8BunGiBGR1gjPnXOpXLU=; b=e4m+ESeL9uAELcUO+mx0rgJIwa0oEmrttZNGv+084QZA8xfF4OHTEddFcFgfKl4xbR 9jqiYOGQ6XeXSkeic6mpucfrAa8H3PhystU1biuhv+6IQmoJY+etihVtE2erdCsXK6E1 fEtAYPN5WBrbRJbNxefX9GXEnLoHjSDk+VATtqo4CbqHdxnKOVJKF/UaDtXAW9LRPq8l 4TQT3d688SI7L1IJEl8tt/5QQYzB7uJxlYuDRRs9aVKXbPwNk1nCpwWeWs5Eag58lImp muX99BmKT+LoN7UbhT9aJp1ilaGxmLs/zQ016G5D0bHk2PZ/nWcQcWgeIzMjs1wTJd5G StDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:mail-followup-to:date:message-id :user-agent:mime-version:content-transfer-encoding; bh=umbE7geYxzwHJqv1joeSmlv8BunGiBGR1gjPnXOpXLU=; b=Kw3u1DRHvZNZxXcS3frn3098tmx3SouJnYNwgzz1B6s4tpjgSYpdoygKcSZ/c3gUXs s0Qw8L7XSKJv2Y1eyoOE1vMzMFXw++L23PDK2gAD0+U1Adr2pJfH7N42kFprYw6fnu2x Hn+TXYPL9d8TGgOEJ8Bdy7gN59Id3Tb+n7SKIIsFoeGTH50Y8W5hrlf8HK3VQue325VY Vjo2ZD6b2X5/r37P/ZmDm5aVcMAV4GD1VLMX9XK6nQbcKK/hkJjMD0Ld2P1X0hDTOjRD E0zlDHOcvjocTriWuWHQlsIihqvoTXbGtSN711SGHbb1NKE20sOOJxKnlt2OhAMp09Bh lHZg== X-Gm-Message-State: ALQs6tAJxgaqXS3SQSKF0K2Zjl5KFDH0c8p2K2MjmPNXxxj8ZPV4IELv 2FsrIqmTWMQiyXfqE0mo4EtLdoTN X-Google-Smtp-Source: AB8JxZrsZ/5k9ZJxuYTsu1MbIT/OucUYaI21Cd4vMK6cxGZm+bSSEgfrqTAeWn2g56+BoO2RfgApUA== X-Received: by 2002:a50:b042:: with SMTP id i60-v6mr56279761edd.68.1525806391689; Tue, 08 May 2018 12:06:31 -0700 (PDT) Original-Received: from localhost ([89.100.107.149]) by smtp.gmail.com with ESMTPSA id a2-v6sm150010edd.39.2018.05.08.12.06.30 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 08 May 2018 12:06:31 -0700 (PDT) Mail-Followup-To: bug-gnu-emacs@gnu.org X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146081 Archived-At: The docstring of message-mode currently hard-codes the bindings provided by message-mode-map. For example: 1. emacs -Q 2. Evaluate: (with-eval-after-load 'message (define-key message-mode-map "\C-c\C-c" #'ignore)) 3. C-x m 4. C-c ? still reports "C-c C-c =E2=80=98message-send-and-exit=E2=80=99". Is this intentional? I realise that this affords summary, custom layout, and descriptions of the available bindings, but isn't it confusing to report the wrong thing in the case that users customise (or use packages which customise) their bindings? One solution is to replace the hard-coded bindings with \[command]-sequences; another to replace the whole listing with \{message-mode-map}. In both cases, the binding listed for message-insert-or-toggle-importance will be C-c C-u instead of C-c C-f C-i, due to the higher precedence of the former. WDYT? P.S. I have, over time, accumulated a set of 12 patches for message.el with refactors such as defining message-mode-map in a single (let ...) calculation, replacing '-quotes with #'-quotes where applicable, removing calls to mapcar where the result is unused, adding tests, etc. I also have a couple of minor and relevant questions to ask. Would patches of this nature be welcome? If so, should I send them here, submit a new bug report, or send mail to emacs-devel? Thanks, --=20 Basil