From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#31692: Emacs sometimes drops key events Date: Mon, 11 Jun 2018 23:08:06 +0200 Message-ID: <874li9116x.fsf@web.de> References: <83wovgd2aj.fsf@gnu.org> <87po163v65.fsf@web.de> <83in6yarhe.fsf@gnu.org> <877encq5co.fsf@web.de> <8336y0x9c3.fsf@gnu.org> <87zi078r8n.fsf@web.de> <83efhiwrmj.fsf@gnu.org> <83602uwq3y.fsf@gnu.org> <87zi042a9g.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1528751378 5445 195.159.176.226 (11 Jun 2018 21:09:38 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 11 Jun 2018 21:09:38 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: radon.neon@gmail.com, 31692@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jun 11 23:09:34 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSU4D-0001Jc-VF for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jun 2018 23:09:34 +0200 Original-Received: from localhost ([::1]:51408 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSU6K-0000ev-Ta for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Jun 2018 17:11:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fSU3l-00076D-I0 for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 17:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fSU3i-0001Sx-C9 for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 17:09:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35848) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fSU3i-0001Sp-7P for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 17:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fSU3h-00055o-Vv for bug-gnu-emacs@gnu.org; Mon, 11 Jun 2018 17:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Jun 2018 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31692 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31692-submit@debbugs.gnu.org id=B31692.152875130519537 (code B ref 31692); Mon, 11 Jun 2018 21:09:01 +0000 Original-Received: (at 31692) by debbugs.gnu.org; 11 Jun 2018 21:08:25 +0000 Original-Received: from localhost ([127.0.0.1]:43745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSU37-000551-JJ for submit@debbugs.gnu.org; Mon, 11 Jun 2018 17:08:25 -0400 Original-Received: from mout.web.de ([212.227.17.11]:35707) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fSU35-00054m-DG for 31692@debbugs.gnu.org; Mon, 11 Jun 2018 17:08:23 -0400 Original-Received: from drachen.dragon ([188.110.196.170]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M8Qpi-1gE8wf2838-00vzNS; Mon, 11 Jun 2018 23:08:07 +0200 In-Reply-To: <87zi042a9g.fsf@web.de> (Michael Heerdegen's message of "Sat, 09 Jun 2018 00:17:47 +0200") X-Provags-ID: V03:K1:YPIlfE+1h3/ZQZKIxR1MTwgFPSGP3mBhJI6XzYcoLpk5tB/Um9r Yr+hdnWnxmO9c9a9cWALhC9GR1PzQ++IEBxWWnTGNoc5nDwkBz1+IEAhpbUmUgjvEoud0b1 nMotsZ/Xyfj/kZUypqrh7fQj4zLao36cbTwIwW42MPud6WiGNvr6AiX0D60AEzcWmr9einP avaMz6ewGf+wT9pebI4Og== X-UI-Out-Filterresults: notjunk:1;V01:K0:lw6aHVgKPOA=:jOGOpuyKSzb06JE0zXw/v9 y5m/7EP3GCHQJRMF+DPkkPk030l3zpqbh2cgfgYuJW3nEiMwpM4ysu8QGNXYgMAL2yL1uOWmY v87lFZDm2fsR2gqaoshqix+YghC4b74lu9/e9jSaMecBQeQFsZwksFE6Be8KzRecAA8hj/PVh hlmFBZp2kWConhECRwfxy6qMcjLCtCGt+CwLbxy6d0MOvFvMEsNVLZmUDe07LfGqzMa5J3dZA hMv6nMhqTtQAT09j828ANvWE3c4jY+DY4nt4IxDPthsxttUxznZHaTDSx+5X1X4dg6cdGs+1d 7PUs16N2uJw0ynMTaxE7AZ4ct3vMsS99w89tVBbb5u7NyUqRcX/t42vI8/e/qPsvQMUb1UeDQ kTv/nIxXiuLZZv/8dmHcn0OFf8q7qHDL/U1KQldjtvs1ptY4ik9wUeOGoBCZEXKFvzWnd4qGL sc5HVZW4qTG3OCmkXyABLHiX/unhHvsuN+EL9f3+290Sr68LTrqTbKh3WGDxRyLvSQTNyc3pU P1ZvkkICa8tMzMlVxXbmdNEjg4QXy87PVM8rXgUGuB/9ZPcscbvam8k4EOMkzEtUmLbIxkh/Q xMqilgmWRnO7ivsg5Yh4d5pDMpkYhnvAtAUczXjFulbVkMdzki2wDIkqDSRPyKHXQdyx3Kjp4 s433nfCI2BB6XQT3BsHKdaNTsYSTghrkCpNBS6NAsch+LSaSs90VZOPMA8rfkKkUSxTyIPscn 7ryYCSkjqu7ygjI22I4KK22qItPLrsO/8bVytNwQdTAqGKj0/jDSMf6pe0NN4CfHvTRk+4hQ X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:147302 Archived-At: Hello, is this ok to install (Eli)? > I tried to adapt Eli's patch accordingly. To avoid confusion, I simply > use the concrete value - the CATCH-SYM - and just return t instead of > throwing: > > diff --git a/lisp/subr.el b/lisp/subr.el > index 914112ccef..7734006d87 100644 > --- a/lisp/subr.el > +++ b/lisp/subr.el > @@ -3520,9 +3520,25 @@ while-no-input > (let ((catch-sym (make-symbol "input"))) > `(with-local-quit > (catch ',catch-sym > - (let ((throw-on-input ',catch-sym)) > - (or (input-pending-p) > - (progn ,@body))))))) > + (let ((throw-on-input ',catch-sym) > + val) > + (setq val > + (or (input-pending-p) > + (progn ,@body))) > + (cond > + ;; If quit-flag is bound to the CATCH-SYM, it means BODY > + ;; didn't test quit-flag, and therefore ran to completion > + ;; even though input arrived before it finished. In that > + ;; case, we must reset quit-flag (and return t), because > + ;; otherwise quit-flag will remain set, and we get Quit to > + ;; top-level, which has undesirable consequences, such as > + ;; discarding input etc. > + ((eq quit-flag ',catch-sym) > + (setq quit-flag nil) > + t) > + ;; This is in case the user actually quits while BODY runs. > + (quit-flag nil) > + (t val))))))) > > (defmacro condition-case-unless-debug (var bodyform &rest handlers) > "Like `condition-case' except that it does not prevent debugging.