From: Noam Postavsky <npostavs@gmail.com>
To: Stephen Berman <stephen.berman@gmx.net>
Cc: 32212@debbugs.gnu.org
Subject: bug#32212: 26; `subword-mode' doc string shows empty key-binding list
Date: Sun, 22 Jul 2018 16:22:51 -0400 [thread overview]
Message-ID: <874lgr58bo.fsf@gmail.com> (raw)
In-Reply-To: <87r2jyjo92.fsf@gmx.net> (Stephen Berman's message of "Fri, 20 Jul 2018 10:38:17 +0200")
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
tags 32212 + patch
quit
Stephen Berman <stephen.berman@gmx.net> writes:
> Maybe due to this change:
> (defvar subword-mode-map
> - (let ((map (make-sparse-keymap)))
> - (dolist (cmd '(forward-word backward-word mark-word kill-word
> - backward-kill-word transpose-words
> - capitalize-word upcase-word downcase-word
> - left-word right-word))
> - (let ((othercmd (let ((name (symbol-name cmd)))
> - (string-match "\\([[:alpha:]-]+\\)-word[s]?" name)
> - (intern (concat "subword-" (match-string 1 name))))))
> - (define-key map (vector 'remap cmd) othercmd)))
> - map)
> + ;; We originally remapped motion keys here, but now use Emacs core
> + ;; hooks. Leave this keymap around so that user additions to it
> + ;; keep working.
> + (make-sparse-keymap)
Aha, then we should just remove it from the docstring, right?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1047 bytes --]
From 6fd80dcf0fc6261de80c130fb535ad334858cbf3 Mon Sep 17 00:00:00 2001
From: Noam Postavsky <npostavs@gmail.com>
Date: Sun, 22 Jul 2018 16:15:43 -0400
Subject: [PATCH] Omit keymap from subword-mode docstring (Bug#32212)
* lisp/progmodes/subword.el (subword-mode): Remove listing of
subword-mode-map bindings, since it is empty as of 2014-03-23 "Merge
capitalized-words-mode and subword-mode".
---
lisp/progmodes/subword.el | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lisp/progmodes/subword.el b/lisp/progmodes/subword.el
index cbaa273a7a..c09ba37c85 100644
--- a/lisp/progmodes/subword.el
+++ b/lisp/progmodes/subword.el
@@ -113,9 +113,7 @@ subword-mode
NSGraphicsContext => \"NS\", \"Graphics\" and \"Context\"
This mode changes the definition of a word so that word commands
-treat nomenclature boundaries as word boundaries.
-
-\\{subword-mode-map}"
+treat nomenclature boundaries as word boundaries."
:lighter " ,"
(when subword-mode (superword-mode -1))
(subword-setup-buffer))
--
2.11.0
next prev parent reply other threads:[~2018-07-22 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 15:10 bug#32212: 26; `subword-mode' doc string shows empty key-binding list Drew Adams
2018-07-20 0:58 ` Noam Postavsky
2018-07-20 7:01 ` Eli Zaretskii
2018-07-20 8:38 ` Stephen Berman
2018-07-22 20:22 ` Noam Postavsky [this message]
2018-07-22 22:36 ` Phil Sainty
2018-07-23 1:01 ` Drew Adams
2018-07-23 4:15 ` Phil Sainty
2018-07-23 4:19 ` Drew Adams
2018-07-23 2:26 ` Eli Zaretskii
2018-07-23 12:22 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874lgr58bo.fsf@gmail.com \
--to=npostavs@gmail.com \
--cc=32212@debbugs.gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).