From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Tino Calancha Newsgroups: gmane.emacs.bugs Subject: bug#32969: "Confirm--do you mean to use =?UTF-8?Q?=E2=80=98*=E2=80=99?= as a wildcard? (y or n)" stays in minibuffer Date: Mon, 08 Oct 2018 02:44:12 +0900 Message-ID: <874ldx649f.fsf@calancha-pc.dy.bbexcite.jp> References: <87murquen9.fsf@jidanni.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1538934186 7473 195.159.176.226 (7 Oct 2018 17:43:06 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 7 Oct 2018 17:43:06 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 32969@debbugs.gnu.org To: =?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 07 19:43:02 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9D53-0001nL-0v for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Oct 2018 19:43:01 +0200 Original-Received: from localhost ([::1]:43086 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9D79-0004Ev-C2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 07 Oct 2018 13:45:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1g9D73-0004Em-QP for bug-gnu-emacs@gnu.org; Sun, 07 Oct 2018 13:45:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1g9D70-0006lX-Ih for bug-gnu-emacs@gnu.org; Sun, 07 Oct 2018 13:45:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35334) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1g9D70-0006lJ-DW for bug-gnu-emacs@gnu.org; Sun, 07 Oct 2018 13:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1g9D70-0005He-8j for bug-gnu-emacs@gnu.org; Sun, 07 Oct 2018 13:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tino Calancha Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Oct 2018 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32969 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 32969-submit@debbugs.gnu.org id=B32969.153893426620244 (code B ref 32969); Sun, 07 Oct 2018 17:45:02 +0000 Original-Received: (at 32969) by debbugs.gnu.org; 7 Oct 2018 17:44:26 +0000 Original-Received: from localhost ([127.0.0.1]:39592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9D6P-0005GS-UO for submit@debbugs.gnu.org; Sun, 07 Oct 2018 13:44:26 -0400 Original-Received: from mail-wr1-f49.google.com ([209.85.221.49]:37493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9D6O-0005GF-6P for 32969@debbugs.gnu.org; Sun, 07 Oct 2018 13:44:24 -0400 Original-Received: by mail-wr1-f49.google.com with SMTP id y11-v6so7616993wrd.4 for <32969@debbugs.gnu.org>; Sun, 07 Oct 2018 10:44:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=z2Of2yu9q6BGZFWargy9Ru9oZUNJdElcSMs5zfWccjY=; b=rZlviijm9KdUNbIIzz4liFpUlvolgcqxRWKy8Hjt9fo59BYUEKSbMEfjy2CdDZmk9b LZEiLjjlIZRC8eZELnEYhEX8O1RSwT0D1hiINWI1gfVnFdcClC3zPaxp28uAfNH7IGVo eCIahaxH/OfASWHWTArI44DMydHqgatEm3agCL7iRfp+go53VHGi3TrSiL3owS+avmMg CpJ8FXnHQHxWD7lt0THfGWnsPnqMStDv3Ahab6N2AXJpIszz5LkfhYp8dTwYYs4Z0gY3 vUHtQCcZZnF0YLnkrmg3ADb3r1phvN7OhXsc0vx4EI55h+dRgqeeHtgkKdHM2WwoUPwd FpdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=z2Of2yu9q6BGZFWargy9Ru9oZUNJdElcSMs5zfWccjY=; b=Zx/Wuwoj2YcvvfTblszWY1nmhc+8Ao5M+vxSIQs8EDUzdoeddbet+SspiuMBJMGQGt A+2uULwj6oeJLv+vzvAtSjUBrb6ArgfoYa55IHHvZWYhyx4sgIfC+QHUbkFDyTU7Gtmn HdWmAGhugwR9RtZ35b8eLIJV3t8sL1Qq00nbxHFGjPYHolKNSmoCfc/tj8N74m634Hf8 /U5dmrTtLT5r4bQGMq09kCHhl0RbE0N73AuQFaLCk5jeBXw5Js7aetjw1Jj1yFW0GXVl XrJn7EwX/xDk2RuohrgaxDPdIY8vJbXCSe1CT0c+vOrePCn9ZwTSWAdcrP3q+Jo8Dnhx zKEA== X-Gm-Message-State: ABuFfojXhDXXT5pULpBgN/wRnlek6ElF2WJk3HzW2e4GZcnWsURTDOyH 0NJ8ri8Ntue16mZNp6W51es0Zf3MRXg= X-Google-Smtp-Source: ACcGV62Y/I1ab4A0BBJk1+v4P6zv7mGNkzooUpqP01joxZbc5RG/OtiqPgcQGGU9Y47iJhy0tCnP4w== X-Received: by 2002:adf:fdc2:: with SMTP id i2-v6mr10407778wrs.276.1538934258001; Sun, 07 Oct 2018 10:44:18 -0700 (PDT) Original-Received: from calancha-pc.dy.bbexcite.jp (15.red-83-50-151.dynamicip.rima-tde.net. [83.50.151.15]) by smtp.gmail.com with ESMTPSA id z12-v6sm1962241wrv.46.2018.10.07.10.44.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 07 Oct 2018 10:44:17 -0700 (PDT) In-Reply-To: <87murquen9.fsf@jidanni.org> ("=?UTF-8?Q?=E7=A9=8D=E4=B8=B9=E5=B0=BC?= Dan Jacobson"'s message of "Sun, 07 Oct 2018 20:26:02 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:150984 Archived-At: =E7=A9=8D=E4=B8=B9=E5=B0=BC Dan Jacobson writes: > Dired has a message: > Confirm--do you mean to use =E2=80=98*=E2=80=99 as a wildcard? (y or n) > if one answers "n" the message just stays in the minibuffer. > > It should instead say "command aborted", else the user thinks it used > '*' in its other (text replacement) way. Which it turns out it doesn't. Thank you for the report! I agree. --8<-----------------------------cut here---------------start------------->= 8--- commit e76bbfa62b7185cd3284d69483704366dc54e7e8 Author: Tino Calancha Date: Mon Oct 8 02:40:30 2018 +0900 dired-do-shell-command: Notify users after abort the command =20=20=20=20 * lisp/dired-aux.el (dired-do-shell-command): Notify users that the command have aborted when they answer 'n' to the prompt (Bug#32969). diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index 1f13204b7c..a4145eb67a 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -763,16 +763,17 @@ dired-do-shell-command (y-or-n-p (format-message "Confirm--do you mean to use `?' as a wildcard? "))) (t)))) - (when ok - (if on-each - (dired-bunch-files (- 10000 (length command)) - (lambda (&rest files) - (dired-run-shell-command - (dired-shell-stuff-it command files t arg)= )) - nil file-list) - ;; execute the shell command - (dired-run-shell-command - (dired-shell-stuff-it command file-list nil arg))))))) + (cond ((not ok) (message "OK, canceled")) + (t + (if on-each + (dired-bunch-files (- 10000 (length command)) + (lambda (&rest files) + (dired-run-shell-command + (dired-shell-stuff-it command files t= arg))) + nil file-list) + ;; execute the shell command + (dired-run-shell-command + (dired-shell-stuff-it command file-list nil arg)))))))) =20 ;; Might use {,} for bash or csh: (defvar dired-mark-prefix "" --8<-----------------------------cut here---------------end--------------->= 8---