From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#29360: Add full-buffer choice for `isearch-lazy-highlight' Date: Mon, 29 Oct 2018 00:34:32 +0200 Organization: LINKOV.NET Message-ID: <874ld5g233.fsf_-_@mail.linkov.net> References: <87o9bfqfc3.fsf@mail.linkov.net> <72ae3efe-0aa6-430e-ba99-2d8bc47d3a34@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1540766357 7754 195.159.176.226 (28 Oct 2018 22:39:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 28 Oct 2018 22:39:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 29360@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 28 23:39:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGtiB-0001v9-09 for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Oct 2018 23:39:11 +0100 Original-Received: from localhost ([::1]:42423 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGtkH-0000pn-Fs for geb-bug-gnu-emacs@m.gmane.org; Sun, 28 Oct 2018 18:41:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45321) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGtkA-0000pb-J2 for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 18:41:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGtk3-0001vk-Qz for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 18:41:13 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45171) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gGtjy-0001rH-Eq for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 18:41:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gGtjy-0000m0-Bc for bug-gnu-emacs@gnu.org; Sun, 28 Oct 2018 18:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 28 Oct 2018 22:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29360 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 29360-submit@debbugs.gnu.org id=B29360.15407664422917 (code B ref 29360); Sun, 28 Oct 2018 22:41:02 +0000 Original-Received: (at 29360) by debbugs.gnu.org; 28 Oct 2018 22:40:42 +0000 Original-Received: from localhost ([127.0.0.1]:49425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGtjd-0000kz-UL for submit@debbugs.gnu.org; Sun, 28 Oct 2018 18:40:42 -0400 Original-Received: from fossa.birch.relay.mailchannels.net ([23.83.209.62]:46249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gGtjb-0000ko-Sl for 29360@debbugs.gnu.org; Sun, 28 Oct 2018 18:40:40 -0400 X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 065CC122876; Sun, 28 Oct 2018 22:40:38 +0000 (UTC) Original-Received: from pdx1-sub0-mail-a9.g.dreamhost.com (unknown [100.96.33.121]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id BF7181228F4; Sun, 28 Oct 2018 22:40:37 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|jurta@jurta.org Original-Received: from pdx1-sub0-mail-a9.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384) by 0.0.0.0:2500 (trex/5.16.2); Sun, 28 Oct 2018 22:40:37 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|jurta@jurta.org X-MailChannels-Auth-Id: dreamhost X-Glossy-Stupid: 178ef0f63c2687ff_1540766437856_3655494661 X-MC-Loop-Signature: 1540766437856:1575721800 X-MC-Ingress-Time: 1540766437856 Original-Received: from pdx1-sub0-mail-a9.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTP id 88C597F7BC; Sun, 28 Oct 2018 15:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=linkov.net; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=linkov.net; bh=F3OhYOdU6+dQHPAZ4r7BwNHIy1Y=; b= nhVADwOgOSOnqQje1fN0S3HBU8/8boZOU7q2BgKSYKEN8QAqjkEP0e6KHCsppNYR Z9jIkGCp4iKv0TOQg3Q14iAajHPUBeI/wSJ90f2bpLquI183x+EJig0TBPW3nDj9 BRSg6M46NtGLhiyOwF6CoQc9tqUoTEO5CeNc5xEhKiE= Original-Received: from mail.jurta.org (m91-129-105-154.cust.tele2.ee [91.129.105.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a9.g.dreamhost.com (Postfix) with ESMTPSA id 9B19A7F7B7; Sun, 28 Oct 2018 15:40:34 -0700 (PDT) X-DH-BACKEND: pdx1-sub0-mail-a9 In-Reply-To: <72ae3efe-0aa6-430e-ba99-2d8bc47d3a34@default> (Drew Adams's message of "Sat, 27 Oct 2018 17:35:03 -0700 (PDT)") X-VR-OUT-STATUS: OK X-VR-OUT-SCORE: -100 X-VR-OUT-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedtkedrheeigdduieejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgdpffftgfetoffjqffuvfenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhephffvufhofhffjgfkfgggtgesthdtredttdertdenucfhrhhomheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqeenucfkphepledurdduvdelrddutdehrdduheegnecurfgrrhgrmhepmhhouggvpehsmhhtphdphhgvlhhopehmrghilhdrjhhurhhtrgdrohhrghdpihhnvghtpeeluddruddvledruddthedrudehgedprhgvthhurhhnqdhprghthheplfhurhhiucfnihhnkhhovhcuoehjuhhriheslhhinhhkohhvrdhnvghtqedpmhgrihhlfhhrohhmpehjuhhriheslhhinhhkohhvrdhnvghtpdhnrhgtphhtthhopegurhgvfidrrggurghmshesohhrrggtlhgvrdgtohhmnecuvehluhhsthgvrhfuihiivgeptd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:151759 Archived-At: >> I guess that since your patch to the bug thread you just renamed >> isearch-lazy-highlight-buffer to lazy-highlight-buffer and you >> renamed isearch-lazy-highlight-buffer-p to >> isearch-lazy-highlight-buffer. I renamed isearch-lazy-highlight-buffer to lazy-highlight-buffer after realizing that the same feature might be needed also in query-replace, therefore generalized it by removing the prefix isearch-. > Hm. Seems like you also removed `isearch-lazy-highlight-match-function', > which was present in your patches. Why is that? I know that you > you used only `isearch-lazy-highlight-match' as the value, but did > you have something else in mind for it? Can I expect that you will > add back that variable? I strive to keep my changes as minimal as possible to not introduce unused variables. However, if you can demonstrate a real need we could add it when necessary.