From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Noam Postavsky Newsgroups: gmane.emacs.bugs Subject: bug#12857: Re: rcirc.el: make default PART and QUIT reasons customizable Date: Sat, 01 Jun 2019 20:11:52 -0400 Message-ID: <874l586e2f.fsf@gmail.com> References: <50AFB18A.8020806@dogan.se> <50BE7E86.9020601@dogan.se> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="52305"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) Cc: 12857@debbugs.gnu.org, deniz@dogan.se To: Daniel Ralston Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 02 02:17:17 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hXEBZ-000DSc-DO for geb-bug-gnu-emacs@m.gmane.org; Sun, 02 Jun 2019 02:17:17 +0200 Original-Received: from localhost ([127.0.0.1]:42822 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXEBY-0002VF-7c for geb-bug-gnu-emacs@m.gmane.org; Sat, 01 Jun 2019 20:17:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hXEBR-0002Tp-Aj for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 20:17:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hXE6U-00029f-Ez for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 20:12:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53724) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hXE6U-00029U-AK for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 20:12:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hXE6U-0006If-46 for bug-gnu-emacs@gnu.org; Sat, 01 Jun 2019 20:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Jun 2019 00:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12857 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12857-submit@debbugs.gnu.org id=B12857.155943432124210 (code B ref 12857); Sun, 02 Jun 2019 00:12:02 +0000 Original-Received: (at 12857) by debbugs.gnu.org; 2 Jun 2019 00:12:01 +0000 Original-Received: from localhost ([127.0.0.1]:39035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXE6T-0006IQ-7V for submit@debbugs.gnu.org; Sat, 01 Jun 2019 20:12:01 -0400 Original-Received: from mail-io1-f51.google.com ([209.85.166.51]:41556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hXE6Q-0006I2-Vh; Sat, 01 Jun 2019 20:11:59 -0400 Original-Received: by mail-io1-f51.google.com with SMTP id w25so11331591ioc.8; Sat, 01 Jun 2019 17:11:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=rwu3bs5mtW/okOZHWNbP614XozxSAA0w1p0y+dbiwqA=; b=JSFk4jJ2nI/ZeFA+XnN0HG7M4S8UNlgncEEv7Nr5jNw6YB8DOQsltlm2Ek/UjndWBU Nq6o3L8Y0fDBUB2Vd5s2j43n+6ah8GraiamIncpvzMzWC3vOM8gVyQy+TmNZVo+Z2DzU xGiIyqVMF2MPxcYymVxpjG+Ez9g4KCiVqrXByZmJRKVZ/cZarqQDFh/ZPdkYd1BohSEq 38VkaWnxQi+syan/LG/ChoqN8JRpv+BJVA78wtgo54IyIHbT+lQWkebSQ26hUkFRv38B w4K0rJpNwWaaP79Lg6bVdKySkVW42b8APwqoQlQD1XuUt9n9LLA7wc41mqayBROok13x pHFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=rwu3bs5mtW/okOZHWNbP614XozxSAA0w1p0y+dbiwqA=; b=qKvHo/rjIA3hnq6kfgtwJQyEcZ7VDEdXIBRVdOp0XVP7yw+Md8QfY88BRMF66jr4Yo uW53jN3i3Ya/0p/36DUIfviIwB1uZu2zU26/PnfA7J1UbbLr2Etjt1/Pl6c1dSYuzcQn p7no3n+AhWRL/NWk93OnR9C4N8+8CuJqPJJmU9QH/H8OBu0JLX3S3coad5cwFT2mkrSq ZAF5RKlV960ye5Wy9Oub1fLY5lQODhDLkR+9RogEn3MXN2bt28/zL4+fLOPWQSs2PkTt 9WSy+C69g/mX35/riBhXrtr+Eqjyok3axG6EIXGrBVoVxvNz+KweJOUwTmCXZCymkU0G 7vmg== X-Gm-Message-State: APjAAAVv60xcytHOIuYE0p/0yi+vv1bOZF3h4lsem0tktYHvEgCv5ZDX guG/tza19n1EKMwweTpTQbGRnAAM X-Google-Smtp-Source: APXvYqyk0b7NnzcnvfPcBAZU0sepi6UnomcRq1EEQf1PZKb1YUVi5oeB10jXAmxOFNWn93cR2EvZwQ== X-Received: by 2002:a6b:e711:: with SMTP id b17mr11319558ioh.3.1559434313140; Sat, 01 Jun 2019 17:11:53 -0700 (PDT) Original-Received: from minid (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.gmail.com with ESMTPSA id 62sm4644186itx.8.2019.06.01.17.11.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Jun 2019 17:11:52 -0700 (PDT) In-Reply-To: (Daniel Ralston's message of "Thu, 13 Dec 2012 07:05:08 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160015 Archived-At: tags 12857 fixed close 12857 27.1 quit Daniel Ralston writes: > That's a much cleaner way of doing it. I hadn't really looked into > composite types before, so thanks for the suggestion! >> This is a good patch! In my opinion it would be nicer if we use a >> composite customization type for rcirc-default-part-reason and >> rcirc-default-quit-reason, letting the user choose between the default >> (rcirc-id-string) and a custom message. I removed the part that puts the default into the customization type, since the customization machinery already handles default values just fine. Pushed to master, with followup NEWS entry. aa9d57eed1 2019-06-01T20:01:43-04:00 "; Add NEWS entry for previous change" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=aa9d57eed17ee6a8006c9cdd4f8636100482cd71 d3f14ffae4 2019-06-01T20:01:43-04:00 "Make rcirc PART and QUIT reasons customizable (Bug#12857)" https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d3f14ffae4078688a57acdff30fdd91747386f17