From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#31800: suggestion of improvement for sort-numeric-fields function. Date: Sat, 13 Jul 2019 05:41:56 +0200 Message-ID: <874l3qy517.fsf@mouse.gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="81397"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 31800@debbugs.gnu.org To: SK Kim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 13 05:42:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hm8vH-000L24-V4 for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Jul 2019 05:42:08 +0200 Original-Received: from localhost ([::1]:53538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hm8vG-00084x-EB for geb-bug-gnu-emacs@m.gmane.org; Fri, 12 Jul 2019 23:42:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54807) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hm8vD-00084f-GB for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 23:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hm8vC-0005Sa-GW for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 23:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60670) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hm8vC-0005SR-DD for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 23:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hm8vC-0001At-Ac for bug-gnu-emacs@gnu.org; Fri, 12 Jul 2019 23:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Jul 2019 03:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31800 X-GNU-PR-Package: emacs Original-Received: via spool by 31800-submit@debbugs.gnu.org id=B31800.15629893214508 (code B ref 31800); Sat, 13 Jul 2019 03:42:02 +0000 Original-Received: (at 31800) by debbugs.gnu.org; 13 Jul 2019 03:42:01 +0000 Original-Received: from localhost ([127.0.0.1]:41258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hm8vB-0001Ae-5n for submit@debbugs.gnu.org; Fri, 12 Jul 2019 23:42:01 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:54914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hm8v9-0001AW-Vn for 31800@debbugs.gnu.org; Fri, 12 Jul 2019 23:42:00 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hm8v6-0005AN-Pe; Sat, 13 Jul 2019 05:41:59 +0200 In-Reply-To: (SK Kim's message of "Wed, 13 Jun 2018 01:09:17 +0900") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162841 Archived-At: SK Kim writes: > This is not likely a bug but sort-numeric-fields function does not > allow region with blank lines, while sort-lines does. > > This was because sort-skip-fields occurs error with blank line. And > when I added condition for sort-skip-fields like below, > sort-numeric-fields was working with blank lines too. > > (when (not (string-match-p "^\\s-*$" (thing-at-point 'line))) > (sort-skip-fields field)) > > So, I just hope sort-numeric-fields would work for region with blank > lines too. Can you create a patch for this fix? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no