unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: "Štěpán Němec" <stepnem@gmail.com>
Cc: 36852@debbugs.gnu.org
Subject: bug#36852: 27.0.50; ietf-drums-parse-address doesn't handle non-ascii properly
Date: Sun, 15 Sep 2019 14:00:28 +0200	[thread overview]
Message-ID: <874l1d6a77.fsf@gnus.org> (raw)
In-Reply-To: <871ry7g9ve.fsf@gmail.com> ("Štěpán Němec"'s message of "Tue, 30 Jul 2019 11:16:53 +0200")

Štěpán Němec <stepnem@gmail.com> writes:

> ietf-drums-parse-address (AKA mail-header-parse-address) uses
> ietf-drums-atext-token to parse display-name, but the regexp range only
> contains ASCII characters, so e.g. as used in debbugs-gnu-show-reports,
> the following happens:
>
>   (mail-header-parse-address
>    (decode-coding-string "Áaááá Ůůůůů <aaa@example.net>" 'utf-8))
>
>   ;;=> ("aaa@example.net" . "aááá")

That's not a valid email address, so perhaps `ietf-drums-parse-address'
should return a blank string as the name here...  On the other hand,
calling that function on something that's not an email address (which
debbugs-gnu does here) it should probably be free to return whatever.

> I'm not quite sure what the proper fix is, as the ASCII-only thing seems
> to be intentional. Maybe it's just not supposed to be used the way it is
> used in debbugs-gnu.el?

Indeed.  I've now changed debbugs-gnu to split the "OCTETS
<MORE-OCTETS>" string returned by the debbugs web server correctly.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      parent reply	other threads:[~2019-09-15 12:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  9:16 bug#36852: 27.0.50; ietf-drums-parse-address doesn't handle non-ascii properly Štěpán Němec
2019-07-30  9:53 ` Robert Pluim
2019-09-15 12:00 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874l1d6a77.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=36852@debbugs.gnu.org \
    --cc=stepnem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).