From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#37515: 27.0.50; button.el doesn't support help-echo function Date: Mon, 30 Sep 2019 20:53:53 +0100 Message-ID: <874l0tftm6.fsf@tcd.ie> References: <87zhirdv75.fsf@gnus.org> <87ftki1xby.fsf@gnus.jao.io> <87sgodftxd.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="225716"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Katsumi Yamaoka , Lars Ingebrigtsen , 37515@debbugs.gnu.org To: "Jose A. Ortega Ruiz" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 30 21:55:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iF1lH-000wX2-4J for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Sep 2019 21:55:11 +0200 Original-Received: from localhost ([::1]:56526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iF1lG-0004HW-0E for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Sep 2019 15:55:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41750) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iF1l9-0004HM-A7 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 15:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iF1l8-0007bi-8B for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 15:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51710) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iF1l8-0007bS-4u for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 15:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iF1l7-0004Ra-Q7 for bug-gnu-emacs@gnu.org; Mon, 30 Sep 2019 15:55:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Sep 2019 19:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37515 X-GNU-PR-Package: emacs Original-Received: via spool by 37515-submit@debbugs.gnu.org id=B37515.156987324417007 (code B ref 37515); Mon, 30 Sep 2019 19:55:01 +0000 Original-Received: (at 37515) by debbugs.gnu.org; 30 Sep 2019 19:54:04 +0000 Original-Received: from localhost ([127.0.0.1]:60531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iF1kC-0004QE-3s for submit@debbugs.gnu.org; Mon, 30 Sep 2019 15:54:04 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:51515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iF1k9-0004Ph-KO for 37515@debbugs.gnu.org; Mon, 30 Sep 2019 15:54:02 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id 7so789762wme.1 for <37515@debbugs.gnu.org>; Mon, 30 Sep 2019 12:54:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=67i32KTn729CehBN3/G298YaDbVOVPOrbQyeGZ8/0UQ=; b=olRMDDk/gqDUY2mc+S98Ny0otLph87qqKIdvFLg6/sAg68KVM7yP8Dh++GEcJdI9ay aT3284YwDJol0H/qnZx82WJaF6cJXcerVtsA6+AglIatC18bMllDpM9NnAlEw4enc6ri sDAm090CrjDVyCgm9uIt4tL3Tf74SPhRZ9V0i4bzgkddCaAeKDQXnzHljscm9/I/O89A fnGoaqFmyOxeNvLpq62KjSCqq0DyI4swdr4DLjZYATV6pmRQE88V5lzuMLCNNrf57p3V VcKXHg5ryrfk7l1lvHVADU8zP9KQrJsy4Skp11BqSF4UitN9FDJI2leF6p66p75Tp8W2 Ncvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=67i32KTn729CehBN3/G298YaDbVOVPOrbQyeGZ8/0UQ=; b=oWpsqEHhq88GyVu0x/Smmqg78LofsHCJjieC1cJp6ZmlWzBfkyK+bw6i5di0BKWSXm 3HDwX8cxHnmegVIvimJ+cWrPJAvp+M1FFEoCZWbrUqBjTaTu+XD9GR8MrTS5cECXypji pQMqQKj2zwPIOcN2+FQabmXY8NwfRNb1hQros0ya1vCaMrSI9lSu1tV2gUAaEu0CgBt8 u1TNO+3h9t4XEf3aFj1LJicMDSTxxgBnmQVk1avWAr3vx/l/GqndIsT0g1cTY+fuqEOi 2QkQXydlQyiHC8JZ4xOb1CmG8VKGFruOHeV4slHJYvRUyzI9CD9tTqH7gtG45U3SJQmG pCVA== X-Gm-Message-State: APjAAAVda+o3YBQ6Jr8nc/zwjyXytPKdbltEzeXZHU7a7ARlrI98TtTZ 4iKZqVDqf4Br21OM95bjPIWJmw== X-Google-Smtp-Source: APXvYqxSBoDwgKlNeKw9ridaMF55VFn0Y/3JXVf8BO0chdpYgrSdKry7I1p15Ougw1O2fq6xpxo2Hw== X-Received: by 2002:a05:600c:351:: with SMTP id u17mr696013wmd.130.1569873235673; Mon, 30 Sep 2019 12:53:55 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id s5sm14121854wro.27.2019.09.30.12.53.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2019 12:53:54 -0700 (PDT) In-Reply-To: <87sgodftxd.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 30 Sep 2019 20:47:10 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:167944 Archived-At: "Basil L. Contovounesios" writes: > diff --git a/lisp/button.el b/lisp/button.el > index 9112e518b0..ae2488bac6 100644 > --- a/lisp/button.el > +++ b/lisp/button.el > @@ -470,13 +470,22 @@ push-button > (button-activate button use-mouse-action) > t)))) > > +(defun button--help-echo (button) > + "Evaluate BUTTON's `help-echo' property and return its value." > + (let ((help (button-get button 'help-echo))) > + (if (functionp help) > + (let ((obj (if (overlayp button) button (current-buffer)))) > + (funcall help (selected-window) obj (button-start button))) > + (eval help lexical-binding)))) Note that I intend to enable lexical-binding in button.el in a future patch, in which case this call to eval will not need changing. -- Basil