From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: "Jose A. Ortega Ruiz" <jao@gnu.org>
Cc: Katsumi Yamaoka <yamaoka@jpl.org>,
Lars Ingebrigtsen <larsi@gnus.org>,
37515@debbugs.gnu.org
Subject: bug#37515: 27.0.50; button.el doesn't support help-echo function
Date: Mon, 30 Sep 2019 20:53:53 +0100 [thread overview]
Message-ID: <874l0tftm6.fsf@tcd.ie> (raw)
In-Reply-To: <87sgodftxd.fsf@tcd.ie> (Basil L. Contovounesios's message of "Mon, 30 Sep 2019 20:47:10 +0100")
"Basil L. Contovounesios" <contovob@tcd.ie> writes:
> diff --git a/lisp/button.el b/lisp/button.el
> index 9112e518b0..ae2488bac6 100644
> --- a/lisp/button.el
> +++ b/lisp/button.el
> @@ -470,13 +470,22 @@ push-button
> (button-activate button use-mouse-action)
> t))))
>
> +(defun button--help-echo (button)
> + "Evaluate BUTTON's `help-echo' property and return its value."
> + (let ((help (button-get button 'help-echo)))
> + (if (functionp help)
> + (let ((obj (if (overlayp button) button (current-buffer))))
> + (funcall help (selected-window) obj (button-start button)))
> + (eval help lexical-binding))))
Note that I intend to enable lexical-binding in button.el in a future
patch, in which case this call to eval will not need changing.
--
Basil
next prev parent reply other threads:[~2019-09-30 19:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 1:14 bug#37515: 27.0.50; button.el doesn't support help-echo function Katsumi Yamaoka
2019-09-26 1:26 ` Katsumi Yamaoka
2019-09-26 13:49 ` Lars Ingebrigtsen
[not found] ` <esr-pdhHsyCqhSoZbW_3iLp4UdujyDpcbOuBdPROA9aG3j9CO0niyrK5O_Tf33N-le-e5hmaqbYZLyuNc6kd3A==@protonmail.internalid>
2019-09-26 21:44 ` Katsumi Yamaoka
2019-09-26 22:56 ` Jose A. Ortega Ruiz
2019-09-30 19:47 ` Basil L. Contovounesios
2019-09-30 19:53 ` Basil L. Contovounesios [this message]
2019-10-01 12:29 ` Basil L. Contovounesios
2019-10-01 12:28 ` Lars Ingebrigtsen
2019-10-01 12:32 ` Basil L. Contovounesios
2019-10-03 23:00 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874l0tftm6.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=37515@debbugs.gnu.org \
--cc=jao@gnu.org \
--cc=larsi@gnus.org \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).