From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#32344: Add option to keep colorization in comint, use it in python.el Date: Tue, 22 Oct 2019 23:37:31 +0300 Organization: LINKOV.NET Message-ID: <874l00wnlo.fsf@mail.linkov.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="267386"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (x86_64-pc-linux-gnu) Cc: 32344@debbugs.gnu.org To: Carlos Pita Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 22 22:46:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iN12t-0017Lo-IQ for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 22:46:23 +0200 Original-Received: from localhost ([::1]:44380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iN12r-0000Up-Mw for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 16:46:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47841) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iN12a-0000UU-H6 for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 16:46:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iN12Z-0005rS-CT for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 16:46:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51713) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iN12Y-0005rG-Qw for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 16:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iN12Y-0005dg-Kq for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 16:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Oct 2019 20:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32344 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32344-submit@debbugs.gnu.org id=B32344.157177714621647 (code B ref 32344); Tue, 22 Oct 2019 20:46:02 +0000 Original-Received: (at 32344) by debbugs.gnu.org; 22 Oct 2019 20:45:46 +0000 Original-Received: from localhost ([127.0.0.1]:60534 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN12H-0005d4-TD for submit@debbugs.gnu.org; Tue, 22 Oct 2019 16:45:46 -0400 Original-Received: from pdx1-sub0-mail-fallback-a1.dreamhost.com ([64.90.62.138]:47620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iN12F-0005cm-AU for 32344@debbugs.gnu.org; Tue, 22 Oct 2019 16:45:44 -0400 Original-Received: from pdx1-sub0-mail-a90.g.dreamhost.com (unknown [10.35.43.115]) by pdx1-sub0-mail-fallback-a1.dreamhost.com (Postfix) with ESMTP id 8893927509A; Tue, 22 Oct 2019 13:45:37 -0700 (PDT) Original-Received: from mail.jurta.org (m91-129-98-153.cust.tele2.ee [91.129.98.153]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: jurta@jurta.org) by pdx1-sub0-mail-a90.g.dreamhost.com (Postfix) with ESMTPSA id 3B0878240F; Tue, 22 Oct 2019 13:45:05 -0700 (PDT) In-Reply-To: (Carlos Pita's message of "Mon, 21 Oct 2019 17:53:06 -0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:170008 Archived-At: >> But I wonder if you could just replace add-text-properties with >> add-face-text-property? It will keep your previous text properties >> and will just merge them with the comint-highlight-input face. > > I'm not sure about this: > >> If any text in the region already has a non-nil =E2=80=98face=E2=80=99= property, those >> face(s) are retained. > > Is the default face represented as a nil face property? Will it be > overridden? In that case the mix could be ugly. Merging with nil is a no-op anyway. > In general I'd prefer to keep both paths of execution as separate as > possible so as to avoid regressions. The result would be very nice when font-lock faces that highlight keyword= s are merged with the background color specified by the comint-highlight-in= put face.