From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#36101: 26.1; epg--status-*SIG does not always precent decode Date: Tue, 22 Oct 2019 16:49:19 +0200 Message-ID: <874l00n8cw.fsf@gnus.org> References: <87pnnsm8cu.fsf@poincare.umons.ac.be> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="76769"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36101@debbugs.gnu.org To: Christophe TROESTLER Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 22 16:50:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMvUG-000Ji7-AX for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 16:50:16 +0200 Original-Received: from localhost ([::1]:59648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMvUE-0000CC-Os for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Oct 2019 10:50:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50326) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iMvU3-000083-N3 for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 10:50:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iMvU2-0007WC-E5 for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 10:50:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51464) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iMvU2-0007Vt-AL for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 10:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iMvU1-0003Me-W5 for bug-gnu-emacs@gnu.org; Tue, 22 Oct 2019 10:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Oct 2019 14:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36101 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 36101-submit@debbugs.gnu.org id=B36101.157175576812867 (code B ref 36101); Tue, 22 Oct 2019 14:50:01 +0000 Original-Received: (at 36101) by debbugs.gnu.org; 22 Oct 2019 14:49:28 +0000 Original-Received: from localhost ([127.0.0.1]:60282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMvTT-0003LT-Lt for submit@debbugs.gnu.org; Tue, 22 Oct 2019 10:49:27 -0400 Original-Received: from quimby.gnus.org ([80.91.231.51]:42954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iMvTQ-0003LF-KK for 36101@debbugs.gnu.org; Tue, 22 Oct 2019 10:49:26 -0400 Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iMvTM-0006AR-3d; Tue, 22 Oct 2019 16:49:22 +0200 In-Reply-To: <87pnnsm8cu.fsf@poincare.umons.ac.be> (Christophe TROESTLER's message of "Wed, 5 Jun 2019 14:09:55 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169981 Archived-At: Christophe TROESTLER writes: > I received a message with a S/MIME signature that verified correctly (using gpgsm). However, the button has undecoded percent escapes. It turns out that the culprit is the function `epg--status-*SIG' which, when (epg-context-protocol context) is 'CMS and `epg-dn-from-string' triggers an error, does not perform the decoding of percent escapes. > > If, in the body of `epg-dn-from-string', one changes > > (condition-case nil > (if (eq (epg-context-protocol context) 'CMS) > (setq user-id (epg-dn-from-string user-id)) > (setq user-id (epg--decode-percent-escape user-id))) > (error)) > > into > > (condition-case nil > (if (eq (epg-context-protocol context) 'CMS) > (setq user-id (epg-dn-from-string user-id))) > (error)) > (setq user-id (epg--decode-percent-escape user-id)) > > it works (provided http://debbugs.gnu.org/cgi/bugreport.cgi?bug=36098 has been fixed first). I do not think `epg--decode-percent-escape' can trigger `error' but it is protected everywhere it is used so maybe one should write Do you have an example here to display the bug? (epg-dn-from-string "CN=Steve Kille,O=Isode Limited,C=GB") => (("CN" . "Steve Kille") ("O" . "Isode Limited") ("C" . "GB")) so we can't run the output of that from epg--decode-percent-escape. So in your case, what are the parameters to epg--status-*SIG? I.e., the STRING? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no