From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#24721: 25.1; Reverse the order of `isearch-message-prefix' prefixes from function advice property Date: Mon, 11 Nov 2019 04:33:40 +0100 Message-ID: <874kzbqe7f.fsf@marxist.se> References: <39fe0ad4-edb6-4364-b611-146e97097695@default> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="177386"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 24721@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 11 04:34:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iU0Sz-000k0R-Q0 for geb-bug-gnu-emacs@m.gmane.org; Mon, 11 Nov 2019 04:34:14 +0100 Original-Received: from localhost ([::1]:48856 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iU0Sy-0004ey-8C for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 Nov 2019 22:34:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33198) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iU0Ss-0004ed-8f for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2019 22:34:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iU0So-0001wT-Jf for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2019 22:34:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44218) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iU0So-0001vf-FM for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2019 22:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iU0So-0006Q9-9l for bug-gnu-emacs@gnu.org; Sun, 10 Nov 2019 22:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Nov 2019 03:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24721 X-GNU-PR-Package: emacs Original-Received: via spool by 24721-submit@debbugs.gnu.org id=B24721.157344322924661 (code B ref 24721); Mon, 11 Nov 2019 03:34:02 +0000 Original-Received: (at 24721) by debbugs.gnu.org; 11 Nov 2019 03:33:49 +0000 Original-Received: from localhost ([127.0.0.1]:53039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iU0Sb-0006Ph-1Q for submit@debbugs.gnu.org; Sun, 10 Nov 2019 22:33:49 -0500 Original-Received: from host.gofardesign.uk ([208.79.239.190]:43379) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iU0SZ-0006PR-WA for 24721@debbugs.gnu.org; Sun, 10 Nov 2019 22:33:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tlZS+ejgBqbpOtTtWJovxArAwpfU6NRE7wIq9TUG0zw=; b=SG4nJZDpRCsXY01Bwet0bLbfjN Yw/KjYJwZcXSRtAklfSYXsYR+16A6sr3d0lxcPM+pXaKpYrZIwA0ZPqCgR7fIiZv6LkD9uH2hzIFl eQdcpvCIHjY7fivhTyulguhQ6+wB5vCqTw4umC6phdc3Dv69cGCE2V5BKeeqXNuxuDCk=; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:47626 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iU0ST-0001SV-Rx; Sun, 10 Nov 2019 21:33:42 -0600 In-Reply-To: <39fe0ad4-edb6-4364-b611-146e97097695@default> (Drew Adams's message of "Mon, 17 Oct 2016 15:16:50 -0700 (PDT)") X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:171414 Archived-At: Drew Adams writes: > When there is multiple advice (from `add-function') of > `isearch-filter-predicate' that has property `isearch-message-prefix', > these prefixes are currently shown left to right in the Isearch prompt, > with the first added being on the left and the last added being on the > right. > > I think this is backwards from what a user expects. I've reversed the > order in my own copy, and I think it is more helpful: The first one you > see is the latest applied. Entries are added and removed on the left, > not the right. The most important such prefix is typically the last > one applied, and having it on the left makes it more noticeable (IMO). > > If you agree, all that's required is changing, in the > `isearch-message-prefix' code, (concat np prefix) to (concat prefix np). I think I agree with the reasoning here, and although the issue is minor, the change also seems easy enough. My only concern would be that users would find the change confusing or bothersome, since they are already too used to the current behaviour. Perhaps the trade-off is worth it. Does anyone else have an opinion here? Best regards, Stefan Kangas