From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Kangas Newsgroups: gmane.emacs.bugs Subject: bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists Date: Mon, 20 Jan 2020 19:54:01 +0100 Message-ID: <874kwqt0vq.fsf@marxist.se> References: <87ftijz9df.fsf@gmail.com> <874kyxt78p.fsf@cassou.me> <87lfs8thwv.fsf@cassou.me> <87lfs8b6dx.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="2712"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Damien Cassou , 38284@debbugs.gnu.org, Nicolas Petton To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 20 19:55:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itcCh-0000do-Vv for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 19:55:16 +0100 Original-Received: from localhost ([::1]:42954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itcCh-0003WG-1a for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Jan 2020 13:55:15 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60739) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itcCV-0003W3-Nv for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 13:55:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itcCU-00027a-EB for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 13:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40075) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itcCU-00026U-3O for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 13:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itcCU-0006dc-20 for bug-gnu-emacs@gnu.org; Mon, 20 Jan 2020 13:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Jan 2020 18:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38284 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38284-submit@debbugs.gnu.org id=B38284.157954645725455 (code B ref 38284); Mon, 20 Jan 2020 18:55:01 +0000 Original-Received: (at 38284) by debbugs.gnu.org; 20 Jan 2020 18:54:17 +0000 Original-Received: from localhost ([127.0.0.1]:46048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itcBk-0006cU-SC for submit@debbugs.gnu.org; Mon, 20 Jan 2020 13:54:17 -0500 Original-Received: from ted.gofardesign.uk ([67.225.143.91]:34608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itcBi-0006cE-UI for 38284@debbugs.gnu.org; Mon, 20 Jan 2020 13:54:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1nY9ghOmaHH5eBNS6RIl7S67NLKImAaT1UZd9/kjdv0=; b=eoNfWF+J2+6EAvyPxSlFDBmEAm Q4ugDgHEPCPdI0uEqJ5YljBYWcXKUNkWxw39pYTCstP6YM3OB67270zYLHgbkkTvSA7vBHnnOmmIw tPQu5AoixUCFDM0qIq+By3B4X6QWpRefR4tEdfLZXkSm+fUc5pp/TwcBs2gPs2rmi/0hPP16+vO56 1j9L9vx1+VliNVWKVZyIVdSZKx7AlWlcXuMrrXKvu8d9MWgW9fFgRuBUTNrxUrHynsGZsoo6sNzt1 D5VhpKIiv6Nh+S0rz36zU6vk2m/HZBQq8ml6kKjlC6WsQzxi/wUHWF09Ulwp1YvBGrkT3NAyjkEWe hGRSKAPw==; Original-Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:33338 helo=localhost) by ted.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1itcBa-001nFl-87; Mon, 20 Jan 2020 13:54:06 -0500 In-Reply-To: <87lfs8b6dx.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Fri, 22 Nov 2019 09:35:38 +0000") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - ted.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: ted.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: ted.gofardesign.uk: stefan@marxist.se X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:174942 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Damien Cassou writes: > >> Can you please merge the attached patch with yours? > > No, but you can do that, because it's your work (I can push it for you > though). Anyway, now I read the test you wrote, I agree it's a good > test. You are testing auth-source-pass-match-entry-p, much higher up > than auth-source-pass--generate-entry-suffixes, the function I changed. > > Of course, only someone who was involved in the design would be able to > confidently place the tests at that correct level, the finding of which > is the most difficult part. If the test is good, I think it should be installed. Unfortunately, it seems like it doesn't apply cleanly to current master. Damien, could you please re-send the patch formatted by "git format-patch -1"? Please also include a commit message with a ChangeLog entry as described in the CONTRIBUTE file. Best regards, Stefan Kangas