From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#38284: 27.0.50; [PATCH] Make auth-source-pass-search understand port lists Date: Tue, 21 Jan 2020 20:25:08 +0100 Message-ID: <874kwo6297.fsf@cassou.me> References: <87ftijz9df.fsf@gmail.com> <874kyxt78p.fsf@cassou.me> <87lfs8thwv.fsf@cassou.me> <87lfs8b6dx.fsf@gmail.com> <874kwqt0vq.fsf@marxist.se> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="14298"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 38284@debbugs.gnu.org, Nicolas Petton To: Stefan Kangas , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 21 20:26:21 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1itzAL-0003cS-Fv for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jan 2020 20:26:21 +0100 Original-Received: from localhost ([::1]:60074 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itzAK-0004WD-CD for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Jan 2020 14:26:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60951) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1itzA5-0004Qn-GN for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 14:26:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1itzA1-00019k-Qm for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 14:26:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42541) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1itzA1-00019d-Mp for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 14:26:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1itzA1-0006Ir-K3 for bug-gnu-emacs@gnu.org; Tue, 21 Jan 2020 14:26:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Jan 2020 19:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38284 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38284-submit@debbugs.gnu.org id=B38284.157963472124149 (code B ref 38284); Tue, 21 Jan 2020 19:26:01 +0000 Original-Received: (at 38284) by debbugs.gnu.org; 21 Jan 2020 19:25:21 +0000 Original-Received: from localhost ([127.0.0.1]:48514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itz9N-0006HQ-5x for submit@debbugs.gnu.org; Tue, 21 Jan 2020 14:25:21 -0500 Original-Received: from mail.choca.pics ([80.67.172.235]:51552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1itz9I-0006HA-Ak for 38284@debbugs.gnu.org; Tue, 21 Jan 2020 14:25:19 -0500 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id AB725181B8185; Tue, 21 Jan 2020 20:25:13 +0100 (CET) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id dEa9loix987j; Tue, 21 Jan 2020 20:25:10 +0100 (CET) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 3F6FF181B817F; Tue, 21 Jan 2020 20:25:10 +0100 (CET) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id fGJfDqlm2nDY; Tue, 21 Jan 2020 20:25:10 +0100 (CET) Original-Received: from luz4 (57.139.120.78.rev.sfr.net [78.120.139.57]) by mail.choca.pics (Postfix) with ESMTPSA id DC0201819578D; Tue, 21 Jan 2020 20:25:09 +0100 (CET) In-Reply-To: <874kwqt0vq.fsf@marxist.se> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:175026 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan Kangas writes: > If the test is good, I think it should be installed. Unfortunately, > it seems like it doesn't apply cleanly to current master. > > Damien, could you please re-send the patch formatted by "git > format-patch -1"? Please also include a commit message with a > ChangeLog entry as described in the CONTRIBUTE file. The patch was only meant to be added to Jo=C3=A3o's own patch. Here is a standalone one. --=20 Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-test-lisp-auth-source-pass-tests.el-Test-for-multipl.patch >From 7e4c1aaa934f155e3aa3c69ba0a3460c1b6b90f3 Mon Sep 17 00:00:00 2001 From: Damien Cassou Date: Tue, 21 Jan 2020 20:13:54 +0100 Subject: [PATCH] * test/lisp/auth-source-pass-tests.el: Test for multiple ports. --- test/lisp/auth-source-pass-tests.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/test/lisp/auth-source-pass-tests.el b/test/lisp/auth-source-pass-tests.el index 10ed9c39fb..677abb33cc 100644 --- a/test/lisp/auth-source-pass-tests.el +++ b/test/lisp/auth-source-pass-tests.el @@ -353,6 +353,10 @@ auth-source-pass--matching-entries-find-entries-with-a-port (auth-source-pass--with-store '(("bar.com:8080")) (should (auth-source-pass-match-entry-p "bar.com:8080" "bar.com" nil "8080")))) +(ert-deftest auth-source-pass--matching-entries-find-entries-with-a-port-when-passed-multiple-ports () + (auth-source-pass--with-store '(("bar.com:8080")) + (should (auth-source-pass-match-entry-p "bar.com:8080" "bar.com" nil '("http" "https" "80" "8080"))))) + (ert-deftest auth-source-pass--matching-entries-find-entries-with-slash () ;; match if entry filename matches user (auth-source-pass--with-store '(("foo.com/user")) -- 2.24.1 --=-=-=--