From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#41531: 28.0.50; proper Eldoc async support Date: Sat, 06 Jun 2020 00:28:05 +0100 Message-ID: <874krpjdoa.fsf@gmail.com> References: <87eeqwm101.fsf@gmail.com> <87img5lqty.fsf@gmail.com> <87img55rmm.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="45157"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41531@debbugs.gnu.org, Andrii Kolomoiets , mvoteiza@udel.edu, Stefan Monnier , Dmitry Gutov , Fredrik Bergroth To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 06 01:29:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhLls-000Bdv-Q9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jun 2020 01:29:08 +0200 Original-Received: from localhost ([::1]:60682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhLlr-0006IM-TK for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Jun 2020 19:29:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhLlm-0006ID-5Z for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 19:29:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38794) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhLll-0006nJ-T2 for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 19:29:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhLll-0001nU-Qu for bug-gnu-emacs@gnu.org; Fri, 05 Jun 2020 19:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Jun 2020 23:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41531 X-GNU-PR-Package: emacs Original-Received: via spool by 41531-submit@debbugs.gnu.org id=B41531.15913996956852 (code B ref 41531); Fri, 05 Jun 2020 23:29:01 +0000 Original-Received: (at 41531) by debbugs.gnu.org; 5 Jun 2020 23:28:15 +0000 Original-Received: from localhost ([127.0.0.1]:50338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhLl1-0001mS-5L for submit@debbugs.gnu.org; Fri, 05 Jun 2020 19:28:15 -0400 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:39382) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhLkz-0001mF-LJ for 41531@debbugs.gnu.org; Fri, 05 Jun 2020 19:28:13 -0400 Original-Received: by mail-wm1-f47.google.com with SMTP id k26so10577955wmi.4 for <41531@debbugs.gnu.org>; Fri, 05 Jun 2020 16:28:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-transfer-encoding; bh=5RoegJxkV05gWENSCdtH9Jxl2IdE6g7mXtYCzoCFDMo=; b=IQYazU0xKJNlbKSwX5diUO5+2yno17srluZzz045ssfKhXeDZERbIYQpVyi2lwDVlb WMujL67FgNQyA0go3iXpyzcNlvONZhLACjdxi6j6wWimLT/F2hE0puJvZRiibBGGOoMM lbvpbzuofI6CddK3ReuUE0koZKK5i6hTFeYiUR4Zu2B8t+WUON+ekW9Yo37PE2ZhLh6y dZW0fFS8Z39Bqb7KP2x2QfDj+EMBGkU3S1tJ3aeS0unbUrjYqT53MheDVheznoPT3SX2 I2GYd1VhSoJ30OtJtU8S2n/TSUJ9GsamvQW2ZJmxgFWT2zzJs5WpMIIDRljRCnCb00sd RzGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-transfer-encoding; bh=5RoegJxkV05gWENSCdtH9Jxl2IdE6g7mXtYCzoCFDMo=; b=BF1iQA9hkzc0/V2uWqpC/nCEW2628rfxEXivJIRgbTIa2ji343QJjn7+vngo6ueY2k q1wxAZlx++n2w+Tir0267Ng7GGnz3Et1atkn/pEhOi6CMTKC6Sfi0nja40qWUclQdyYM fKNe9SmYGaErDb3Zq1kAQf8SuTpRJBXrR6pfx4FUbg2H7Ar/NCt3kEsOaF0HVwPvwo8U HNNWeSL6Wq3SuNJDwkQ8l46D8yd0zTLWQcILjbtu2JURoNbRFLjvxz95u3yi4Qa/jIKI ljA4dY+6z5H7sdVBxRifTaXAGRfgZAR0+vNgFFZ9/p7CQElppSRdSO61hUbVrTeUuxmL 2EMQ== X-Gm-Message-State: AOAM530iSMSkyCjRhQHybNdt7VLRM9cOBC2qZjK29t+y8pF9kCy631+U 80dRIO145XWdTvUOYesqDhU= X-Google-Smtp-Source: ABdhPJx7NXKRUVDOAJ3kIT+7LHVrTEJsaveZZwN39NmieTwDLAVc6nPqvRaVZ4CmKSP15kSoJ5bemg== X-Received: by 2002:a1c:f401:: with SMTP id z1mr4696647wma.44.1591399687875; Fri, 05 Jun 2020 16:28:07 -0700 (PDT) Original-Received: from krug ([89.180.147.39]) by smtp.gmail.com with ESMTPSA id a1sm12851031wmj.29.2020.06.05.16.28.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Jun 2020 16:28:07 -0700 (PDT) In-Reply-To: <87img55rmm.fsf@thornhill.no> (Theodor Thornhill's message of "Fri, 05 Jun 2020 17:50:38 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181587 Archived-At: Theodor Thornhill writes: > Bug 1:=20=20=20=20=20=20 > 1. Open a file > 2. Start eglot > 3. Hover something with "C-h ." > 4. Switch to the new window that popped up. > 5. C-x k (kill buffer) > 6. Repeat step 3. > 7. "invalid buffer" and eldoc is dead.=20 > 8. Starting and stopping eldoc doesn't work=20=20=20 > > This seems to happen since it uses the new buffer and updates it. When th= at buffer is deleted, it gets confused. Thanks. This is easy to fix. It's a buffer-live-p call somewhere. > Bug 2: > 1. (setq eldoc-echo-area-use-multiline-p nil) > 2. eglot spits the whole thing on one line. This looks a bit weird since = it uses both the signature and the documentation. > > This may not be a bug, but right now IMO it looks a bit strange. It was intended. But I agree it's not good. I will change it: instead of joining all lines, then trucating, I will just truncate the first line if needed. > Bug 3: > 1. "M-:" > 2. Type "(" > 3. Minibuffer shows: eldoc-error: (wrong number of arguments (0 . 0) 1) I couldn't reproduce this one. > I think the first bug is the most problematic one though :) > > However, I've started to take a liking to the no options set, with > this version. I think I like the "truncate, press M-x ..." message > more than the previous one. Yes, and if `eldoc-doc-buffer` is bound to something shorter, then it will be even simpler to read. I will eventually recommend we rebind `C-h .` (display-local-help) to it. But in the meantime, I think I will make Eglot bind it to that key, as an exception to Eglot's no-keybindings policy. Jo=C3=A3o