From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#41706: 26.1; sort-subr predicate cannot be set successfully Date: Wed, 10 Jun 2020 20:59:30 +0200 Message-ID: <874kriiw6l.fsf@web.de> References: <20200604110922.GA9116@atlantis> <87pnafxc7e.fsf@web.de> <20200604190526.GA14104@atlantis> <83d06dc3po.fsf@gnu.org> <87h7vpg85k.fsf@web.de> <83a71hbuvo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="9364"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 41706@debbugs.gnu.org, post+ebugs@guelker.eu To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 10 21:00:53 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jj5y1-0002Of-43 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jun 2020 21:00:53 +0200 Original-Received: from localhost ([::1]:50688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jj5xz-0004r8-O3 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Jun 2020 15:00:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jj5xD-0004oL-Ls for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 15:00:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52060) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jj5xD-00050R-4i for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 15:00:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jj5xD-0000Z7-1T for bug-gnu-emacs@gnu.org; Wed, 10 Jun 2020 15:00:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Jun 2020 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41706 X-GNU-PR-Package: emacs Original-Received: via spool by 41706-submit@debbugs.gnu.org id=B41706.15918155812096 (code B ref 41706); Wed, 10 Jun 2020 19:00:02 +0000 Original-Received: (at 41706) by debbugs.gnu.org; 10 Jun 2020 18:59:41 +0000 Original-Received: from localhost ([127.0.0.1]:35369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj5wq-0000Xk-QL for submit@debbugs.gnu.org; Wed, 10 Jun 2020 14:59:41 -0400 Original-Received: from mout.web.de ([212.227.17.12]:48267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jj5wp-0000XV-GY for 41706@debbugs.gnu.org; Wed, 10 Jun 2020 14:59:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1591815572; bh=NLi6KIKH+bDIz6D9++VyryuiPcKn9woWG6dxwdlhZrk=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Uas1e2e5gkd6lLJLvlcTC3j+6a8aRZiTtd02uci2RDv+RlivcCnEl8fOTjCex0RZ+ VcqRlbJ2T7e2igV8tXQn41snTskrhXGBcY6AFinwl0N/awAMzMvZcWRXzEke8mOKFn Z5s/PiDVvia/alZuhMkztAPqmNVx9WMgDIdGFfu4= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.217.119.187]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MnpGi-1j8MQQ1a4w-00pMYH; Wed, 10 Jun 2020 20:59:32 +0200 In-Reply-To: <83a71hbuvo.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 05 Jun 2020 14:43:39 +0300") X-Provags-ID: V03:K1:BUdh0W6I4ma1+RgBOV+g5ztciR+3IEcsBifxpSBKhDUaIj8eW9d 9KxyqWTa5WGvAxbq0yI/BgkbnW9kDGT7ntgz8RTT0LNIJEHGi0CC8uj+OLNoVCkNwC6XCyq StFXsT8hBzaMCeQDeVIgcie0ys3WTU76crCoyddBUKZU/ITxXBcwIj2VuHi1iCOrPypJIwO R9tBFIcutkPffFVBJ3mHw== X-UI-Out-Filterresults: notjunk:1;V03:K0:WTCfR/7ko6Y=:kVzBsCm7QWtOxpWFhjtBbX +ikbKpz/J37DpE1c5njXmNWzXvvKjWqfue5xJQZiJh5sZaD9O0pYL+5JP1fIl74y2lVcsptVa ILrRlTdDaT7Yiht9mZNO5TOeifTXnNmBRj/xTEIK6fih7z/5jBLru/jgqr9Y9XTaSSpu4wlPh DJ1bsF04u9ngeFEyxT+/vrKkDB4Y47uBlWrkLKFx4ozz064eiCRvclc9h3t+giH1T4Sy2qdmr RUC52vgLJW/G8jmvu48V66df5g0AXdVWZkUqmh+5pJKM+cvBe3b8YuHhauPTpytHi6S4zzXTg cRJtrNlmm1txxJHV2MN57eZd5++uCSci4AP5wLYmfNibwoYI0SPbJg+4sQB4jHjXfrnFoEEoH Ctxh8TFbFj8JpEII6/e4lUKlDSqeEb0AzaK43W2+7lF1dUxuIa3dkahiQQvINSh+aCZ+FsZ30 D+qoxK3vnzzxUTWSe7Bwgv68yrdtgazQkULpm+ikz+q3iDgDyhsFW95fDKo4qfzRHhtqwOD4G YMOHVMM51pFYZ0BFQXguLMJI43qcVKAfBGwC6nOfH1nqJzYsOoZbQrEAsD8J7fnlndOXVdw9B l8mRNCxGzwskEaPvENJ6gt8ym0K0EGVZJPm1kR5Bv8uAfcKsAq1I8TqASWbep5U9ecPhryHn6 EeuNp5Qj0i0xk6C70ClQj8he6uB14aQhH7LpTfN0uJi7Yo5gXRFglXYTo/GkzOm6f9UjB8x0+ qBFixptdR06Fzws2H0zmDTbwDQNWGE+zeuzR5u+weZkmsebA+Isp65KU9UyTRgtzAapLo1gh X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181826 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: > > This is the sentence that misled the OP I think. Could we be more > > precise and tell that the key is actually the cons cell (BEG . END) > > denoting these strings? > > Patches welcome. Something like this (maybe enhanced using better English): --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=subr.patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/sort.el b/lisp/sort.el index de0e1b9519..a87f33eaee 100644 =2D-- a/lisp/sort.el +++ b/lisp/sort.el @@ -67,11 +67,12 @@ sort-subr ENDRECFUN is called with point within the record. It should move point to the end of the record. -STARTKEYFUN moves from the start of the record to the start of the key. -It may return either a non-nil value to be used as the key, or -else the key is the substring between the values of point after -STARTKEYFUN and ENDKEYFUN are called. If STARTKEYFUN is nil, the key -starts at the beginning of the record. +STARTKEYFUN moves from the start of the record to the start of +the key. It may return either a non-nil value to be used as the +key, or else the key is a cons (BEG . END) designating the +substring of the record between the values of point after +STARTKEYFUN and ENDKEYFUN are called. If STARTKEYFUN is nil, the +key starts at the beginning of the record. ENDKEYFUN moves from the start of the sort key to the end of the sort key= . ENDKEYFUN may be nil if STARTKEYFUN returns a value or if it would be the --=-=-= Content-Type: text/plain Then the doc should already list all possible key formats AFAIU. BTW, what about the suggestion to support collation order out of the box? Thanks, Michael. --=-=-=--