From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39600: [PATCH] Fix handling of non-exclusive non-prefix completion functions Date: Sat, 08 Aug 2020 16:04:10 +0200 Message-ID: <874kpdz12d.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7148"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 39600@debbugs.gnu.org, Stefan Monnier To: Amai Kinono Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 08 16:05:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4PTC-0001kr-Kn for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Aug 2020 16:05:10 +0200 Original-Received: from localhost ([::1]:43654 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k4PTB-0005oW-GQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Aug 2020 10:05:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47508) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k4PT4-0005oO-Tn for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 10:05:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47855) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k4PT4-00072x-KS for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 10:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k4PT4-00079b-FJ for bug-gnu-emacs@gnu.org; Sat, 08 Aug 2020 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Aug 2020 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39600 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39600-submit@debbugs.gnu.org id=B39600.159689546327448 (code B ref 39600); Sat, 08 Aug 2020 14:05:02 +0000 Original-Received: (at 39600) by debbugs.gnu.org; 8 Aug 2020 14:04:23 +0000 Original-Received: from localhost ([127.0.0.1]:59401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4PSR-00078e-4l for submit@debbugs.gnu.org; Sat, 08 Aug 2020 10:04:23 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:52346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k4PSP-00078P-AA for 39600@debbugs.gnu.org; Sat, 08 Aug 2020 10:04:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8r2pyxp5QVphmwAob9SMZfcEnannx5ScKyFQZeMOTFw=; b=gzUOLDVrc9TqCRT7IDBu76jgH3 QYG1lBNX8jhJPGG7KT2YW6KtnQzJ+uEVkH9MJ6DsQX2hCRGOM/ILPPgWUIBsJG+ZCnnqdfkXOVyHB TOA3pJFWn0M2dBQGw9bTuFxccXF3lXJmvBDn7HXsqiQiQIkWXsnIaCzd9MVxzne9HSic=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k4PSF-0005DX-TT; Sat, 08 Aug 2020 16:04:14 +0200 In-Reply-To: (Amai Kinono's message of "Fri, 14 Feb 2020 15:34:19 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184352 Archived-At: Amai Kinono writes: > Currently, with non-exclusive completion functions, Emacs will do > `try-completion` on the current text, and decide whether to try next > completion function based on that. This makes completion functions that > can do non-prefix completions fails when the current text only occurs in > the middle of the candidates. This is a problem I found in a FIXME in > the code. > > # How does this work? > > I use `completion-all-completions` instead. As far as I know, this > respects the `completion-styles`. [...] Stefan, how does this patch look to you? > - ;; FIXME: Here we'd need to decide whether there are > - ;; valid completions against the current text. But this depends > - ;; on the actual completion UI (e.g. with the default completion > - ;; it depends on completion-style) ;-( > - ;; We approximate this result by checking whether prefix > - ;; completion might work, which means that non-prefix completion > - ;; will not work (or not right) for completion functions that > - ;; are non-exclusive. > - (null (try-completion (buffer-substring-no-properties > - (car res) (point)) > - (nth 2 res) > - (plist-get (nthcdr 3 res) :predicate))) > + (null (completion-all-completions > + (buffer-substring-no-properties (car res) (point)) > + (nth 2 res) > + (plist-get (nthcdr 3 res) :predicate) > + (- (point) (car res)))) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no