From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#29565: [PATCH] Support xwidget webkit for macOS X Date: Wed, 12 Aug 2020 12:44:34 +0200 Message-ID: <874kp8qh2l.fsf@gnus.org> References: <87pn7y38sp.fsf@gnus.org> <20200810190612.GA40992@breton.holly.idiocy.org> <87tux9xx3i.fsf@gnus.org> <83eeod438f.fsf@gnu.org> <87mu31rvwa.fsf@gnus.org> <83364tox53.fsf@gnu.org> <875z9prnk1.fsf@gnus.org> <83tux9nfjf.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31184"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: alan@idiocy.org, veshboo@gmail.com, rms@gnu.org, stefan@marxist.se, 29565@debbugs.gnu.org, pcr910303@icloud.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 12 12:45:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5oFq-000808-HU for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 12:45:10 +0200 Original-Received: from localhost ([::1]:49062 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k5oFp-0002el-DO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 12 Aug 2020 06:45:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k5oFi-0002eS-6j for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 06:45:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59676) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k5oFh-0006aD-TA for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 06:45:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k5oFh-0002I3-QV for bug-gnu-emacs@gnu.org; Wed, 12 Aug 2020 06:45:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Aug 2020 10:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29565 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 29565-submit@debbugs.gnu.org id=B29565.15972290958772 (code B ref 29565); Wed, 12 Aug 2020 10:45:01 +0000 Original-Received: (at 29565) by debbugs.gnu.org; 12 Aug 2020 10:44:55 +0000 Original-Received: from localhost ([127.0.0.1]:42989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5oFb-0002HQ-0o for submit@debbugs.gnu.org; Wed, 12 Aug 2020 06:44:55 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:43250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k5oFW-0002H9-Un for 29565@debbugs.gnu.org; Wed, 12 Aug 2020 06:44:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JMBgQrlmMld+Sqf/89AZhjnJcdVtWRu9sCqsRKMdPTM=; b=POjyQs2LX95OM6//QlJzABHI08 Wkas7mQeiD6ivF0OILRu7b3F9YixFWrJzABv+8C4Dx8UouXSAKgGGY4Xlrab9TCkHPNkPFMVrdQel IUo/R5QH8dx+pI+KywloeHORWdX18bjRtlelTzMTp7dRtERuIMxLm2YRJNRSIHpoxLi4=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5oFI-00081O-To; Wed, 12 Aug 2020 12:44:42 +0200 In-Reply-To: <83tux9nfjf.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 11 Aug 2020 22:33:40 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:184770 Archived-At: Eli Zaretskii writes: >> I think the intention is to signal an error if rel_pos is anything other >> than -1, 0 or 1... > > In that case, just call args_out_of_range_3 by hand, after testing > that the value is within bounds. You can see examples of that in > several source files. Yup. I just wondered where that macro came from... Anyway, I've now applied all of Sungbin's patches to Emacs 28, and things seem to work for me. I've tested compiling on Debian and the latest Macos, and xwidget seems to work well on Macos now. Thanks for implementing this, Sungbin. There's a couple added compilation warnings (on Macos) that should be fixed, but before looking at that, I noticed that an unrelated patch made the build spew out all these warnings: In file included from print.c:25: ./lisp.h:1830:12: warning: the argument to '__builtin_assume' has side effects that will be discarded [-Wassume] eassume (0 <= i && i < bool_vector_size (a)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ./lisp.h:182:32: note: expanded from macro 'eassume' # define eassume(cond) assume (cond) ^~~~ etc etc. Was that from one of Paul's patches yesterday? Anyway, I'm closing this bug report now, and we can open new ones for any problems that may crop up... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no