unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Robert Brown <robert.brown@gmail.com>
Cc: 43001@debbugs.gnu.org
Subject: bug#43001: 27.1; bad fontification of Common Lisp uninterned symbols
Date: Mon, 24 Aug 2020 14:35:51 +0200	[thread overview]
Message-ID: <874kosdxw8.fsf@gnus.org> (raw)
In-Reply-To: <CAPNkkpm=YcX6D+stPcVXGoReFJdFdzTKau1vnCuRg1uEN+XR9A@mail.gmail.com> (Robert Brown's message of "Sun, 23 Aug 2020 16:08:25 -0400")

Robert Brown <robert.brown@gmail.com> writes:

> An uninterned symbol looks like "#:my-symbol".  The change causes "#:"
> to be displayed with one face and "my-symbol" with another.  That's bad.
> Fontification signals a semantic property The entire thing is a symbol,
> so it should be displayed using one face.  What face should we use?
> Keyword symbols are displayed using font-lock-builtin-face, so that's
> what I would use.

Makes sense; I've now made this change in Emacs 28.

> Why I'm commenting on Lisp fontification ...  Symbols that start with an
> ampersand character are currently being displayed using
> font-lock-type-face, which doesn't make much sense, since they too are
> symbols.  Perhaps they should be displayed using font-lock-builtin-face
> too.

I think it's fine to use that face in Lisp mode (since it's largely
unused in Lisp mode otherwise).  The face names aren't very descriptive,
though.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      reply	other threads:[~2020-08-24 12:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-23 20:08 bug#43001: 27.1; bad fontification of Common Lisp uninterned symbols Robert Brown
2020-08-24 12:35 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kosdxw8.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=43001@debbugs.gnu.org \
    --cc=robert.brown@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).