From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 10899@debbugs.gnu.org, Alan Mackenzie <acm@muc.de>,
Dani Moncayo <dmoncayo@gmail.com>
Subject: bug#10899: 24.0.93; c-forward-conditional should not move the mark
Date: Tue, 25 Aug 2020 14:34:31 +0200 [thread overview]
Message-ID: <874koqaoq0.fsf@gnus.org> (raw)
In-Reply-To: <jwvbooioc2c.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 28 Feb 2012 16:59:30 -0500")
Alan, I don't know if you saw this bug report? The gist of it is that
is seems inconsistent for `c-forward-conditional' and
`c-backward-conditional' to do a `push-mark'.
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> a. `c-forward-conditional' and `c-backward-conditional' should not set
>> the mark, because each one has an inverse movement command.
>> b. Even if you disagree, those commands should not set the mark when
>> it is active.
>
> FWIW I completely agree.
Juri Linkov <juri@jurta.org> writes:
>> Regarding your patch, I think it clearly improve the current behavior,
>> but I want to emphasize again that, IMO, setting the mark in too many
>> commands is bad, because it overfills the mark ring, thus making
>> harder to return to earlier positions.
>
> What I wanted to achieve is to make C movement commands to behave exactly
> as their Lisp counterparts. I see the following correspondence:
>
> leaves mark behind?
> c-beginning-of-defun beginning-of-defun yes
> c-end-of-defun end-of-defun yes
> c-mark-function mark-defun yes
> c-up-conditional backward-up-list no
> c-down-conditional down-list no
> c-backward-conditional backward-list no
> c-forward-conditional forward-list no
>
> So I agree that `c-forward-conditional' and `c-backward-conditional'
> should not push the mark.
>
> Regarding bug#10906, I think `c-mark-function' should be rewritten
> to follow the logic of `mark-defun'.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
prev parent reply other threads:[~2020-08-25 12:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-27 19:06 bug#10899: 24.0.93; c-forward-conditional should not move the mark Dani Moncayo
2012-02-27 19:29 ` Dani Moncayo
2012-02-27 20:28 ` Eli Zaretskii
2012-02-27 20:59 ` Dani Moncayo
2012-02-28 7:42 ` Dani Moncayo
2012-02-28 10:30 ` Juri Linkov
2012-02-28 11:12 ` Dani Moncayo
2012-02-29 0:14 ` Juri Linkov
2012-02-28 21:59 ` Stefan Monnier
2020-08-25 12:34 ` Lars Ingebrigtsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874koqaoq0.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=10899@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=dmoncayo@gmail.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).