From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#20664: 25.0.50; Customize: Link option or face name to the source definition Date: Thu, 17 Sep 2020 20:46:54 +0200 Message-ID: <874knwmeap.fsf@gnus.org> References: <0ef05975-f3ab-4601-81bb-e4fc17d0cb87@default> <877frup37r.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4195"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 20664@debbugs.gnu.org To: Oleh Krehel Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 17 20:48:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIyx2-0000wM-Am for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 20:48:12 +0200 Original-Received: from localhost ([::1]:50846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIyx1-0001KQ-Bj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Sep 2020 14:48:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33322) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIyws-0001Hs-Sd for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 14:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55729) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIyws-0003ON-In for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 14:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIyws-0007SG-H9 for bug-gnu-emacs@gnu.org; Thu, 17 Sep 2020 14:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Sep 2020 18:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20664 X-GNU-PR-Package: emacs Original-Received: via spool by 20664-submit@debbugs.gnu.org id=B20664.160036842728582 (code B ref 20664); Thu, 17 Sep 2020 18:48:02 +0000 Original-Received: (at 20664) by debbugs.gnu.org; 17 Sep 2020 18:47:07 +0000 Original-Received: from localhost ([127.0.0.1]:39039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyvz-0007Qv-Iu for submit@debbugs.gnu.org; Thu, 17 Sep 2020 14:47:07 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:44538) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIyvx-0007Q9-7Y for 20664@debbugs.gnu.org; Thu, 17 Sep 2020 14:47:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8gaRnKhJ4mqd9aU/cE0uFveh3zP7ak1FE01M8KVaEW8=; b=I+p033GT3Yv3g/Amgd8D2JI1SR ZQqJ3UR8CJPjX9C6yxb3y4R0TPRF0uoYsWYdR4YgPe498foYuAQMlcZJxFuFmYkY0gHPaiTFcebWi e9TwDFd/uYubAAPEjZtoWgQ5SpOqWH0kC0onswC5wshhg3NUBVcjGK4mVFnNzGbiQeME=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIyvn-0003kL-KJ; Thu, 17 Sep 2020 20:46:58 +0200 X-Now-Playing: Neil Young's _Tonight's the Night_: "Speakin' Out" In-Reply-To: <877frup37r.fsf@gmail.com> (Oleh Krehel's message of "Wed, 27 May 2015 15:19:52 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188245 Archived-At: Oleh Krehel writes: > * lisp/cus-edit.el (custom-face-value-create): Make the face name into > a button that calls `find-face-definition'. [...] > + (setq opoint (point)) > + ;; Face name (tag). > + (insert " " tag) > + (make-button opoint (point) > + 'follow-link t > + 'action (lambda (&rest _x) (find-face-definition symbol)))) Makes sense to me. I tweaked it a bit before applying, though -- used insert-text-button for convenience. > With this patch, "RET" works as expected, while "" is giving an > error for a reason I don't understand. In order to make it work for the > mouse, I have to do something contorted instead of a plain > `make-button': I think that's just a bug in Customize -- I think I've now fixed that, but it involved some refactoring, so hopefully I didn't break anything. But a standard Customize buffer seems to have the same number of things that work before/after the rework, so I'm hopeful. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no