From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#39452: [PATCH] vc-git-state fails for filenames with wildcards Date: Sun, 20 Sep 2020 11:54:06 +0200 Message-ID: <874knssri9.fsf@gnus.org> References: <83h802g77h.fsf@gnu.org> <8f427281-510c-30c3-995f-364e22d9c1e2@yandex.ru> <85y2texxso.fsf@gmail.com> <52f47a82-b93e-d9c2-ee94-752b289d4b96@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10890"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Noam Postavsky , 39452@debbugs.gnu.org, Wolfgang Scherer To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 20 11:55:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJw3x-0002iG-Ep for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 11:55:17 +0200 Original-Received: from localhost ([::1]:57876 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJw3w-00081q-3i for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 20 Sep 2020 05:55:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58790) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJw3i-00081M-Ot for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 05:55:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37205) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJw3i-00053r-Fp for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 05:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kJw3i-0000zJ-FQ for bug-gnu-emacs@gnu.org; Sun, 20 Sep 2020 05:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 Sep 2020 09:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39452 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39452-submit@debbugs.gnu.org id=B39452.16005956593743 (code B ref 39452); Sun, 20 Sep 2020 09:55:02 +0000 Original-Received: (at 39452) by debbugs.gnu.org; 20 Sep 2020 09:54:19 +0000 Original-Received: from localhost ([127.0.0.1]:48751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJw30-0000yJ-Ok for submit@debbugs.gnu.org; Sun, 20 Sep 2020 05:54:19 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:58608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJw2y-0000y1-Ci for 39452@debbugs.gnu.org; Sun, 20 Sep 2020 05:54:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CuQRINnirgFy/ONQhYKcfgGdXRDIlS7PmUwDS1qHDXw=; b=ClWyYOeS/1VPnPYUyWBS/Dnfyo ggjvGg6/m5zeyM4Q6mk0y7pmxTTlS5vwQxLfoWOL42PyzK4NfywdGHenmILY7QUgLD3Xzbb02DDgG P9a4Q9IjqawQkOI6kYBkcdH/OuykyfQqQ2jGsWTt2pkB+8ymd95w/VEjnFGCPl93i+V0=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJw2p-0005ta-MY; Sun, 20 Sep 2020 11:54:10 +0200 X-Now-Playing: Andrew Poppy's _On Zang Tuum Tumb (3): Under the Son_: "The Sequence" In-Reply-To: (Dmitry Gutov's message of "Fri, 14 Feb 2020 01:23:50 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188478 Archived-At: Dmitry Gutov writes: > Eli, what do you think is better, applying a more verbose fix (which > prepends stuff to every file name) and spending some of our complexity > budged on that. > > Or using the simple fix and documenting the git hooks erratum in the > manual (or somewhere else). > > I'm inclining toward the latter, esp. considering that the problem > should be familiar to Magit users already, and thus the fix is > prominently documented on the Internet. It seems like everybody agreed that adding the environment variable and documenting the problem would be the best fix here, but it doesn't look like that was applied? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no