From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#32676: [PATCH] Add option to highlight the 'next-error' error message Date: Wed, 14 Oct 2020 07:47:03 +0200 Message-ID: <874kmxz7e0.fsf@gnus.org> References: <20180910050802.25922-1-erjoalgo@gmail.com> <83a7ollcq2.fsf@gnu.org> <874let1o3k.fsf@gmail.com> <831s9xl54b.fsf@gnu.org> <874leq1hw4.fsf@mail.linkov.net> <87worlgh0k.fsf@mail.linkov.net> <878swkxqo1.fsf_-_@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19032"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Ernesto Alfonso , Robert Pluim , 32676@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Oct 14 07:48:15 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSZe2-0004qj-Fr for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 07:48:14 +0200 Original-Received: from localhost ([::1]:40014 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSZe1-0008R9-HL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 14 Oct 2020 01:48:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34716) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSZdp-0008Px-W0 for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 01:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38256) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSZdp-00036T-KK for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 01:48:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSZdp-0003xQ-I4 for bug-gnu-emacs@gnu.org; Wed, 14 Oct 2020 01:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Oct 2020 05:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32676-submit@debbugs.gnu.org id=B32676.160265444113900 (code B ref 32676); Wed, 14 Oct 2020 05:48:01 +0000 Original-Received: (at 32676) by debbugs.gnu.org; 14 Oct 2020 05:47:21 +0000 Original-Received: from localhost ([127.0.0.1]:49799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSZdB-0003bq-5A for submit@debbugs.gnu.org; Wed, 14 Oct 2020 01:47:21 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSZd8-0003Vz-UO for 32676@debbugs.gnu.org; Wed, 14 Oct 2020 01:47:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=aNwwG7WWkfTW1PngwBBkPNqC2eLcWc+qeQjmAIjwuQo=; b=rY/Ufv60dnUhBUzLq/NoLs77ka afdGhfovrItK5IkfahNrw9iAqLskVH/gMe5VvwjEvAilgDzpmVyjg3NobKXdwUHcl8J6HEAyEgLtT xi5VDvQmhcJFHqkwPJm5HdJg2peAJ2BuXXNkvCXylbdgjyPaQhK+5CvqzWjOt8GFhEjE=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSZcu-0007cF-Qx; Wed, 14 Oct 2020 07:47:12 +0200 X-Now-Playing: Efterklang's _Tripper_: "=?UTF-8?Q?Doppelg=C3=A4nger?=" In-Reply-To: <878swkxqo1.fsf_-_@mail.linkov.net> (Juri Linkov's message of "Mon, 08 Apr 2019 22:36:38 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190480 Archived-At: Juri Linkov writes: >> I'd like to know if this patch is still being considered? > > Why not? Your patch provides a helpful feature. I see only 2 problems > with its latest version: I've now applied the patch (after reworking slightly), and it seems to work well, so I've pushed it to Emacs 28. > 1. compilation-current-error should be generalized not to be too > compilation-specific; Reading the code, it looks like that variable is always set, even in grep buffers and the like? So it's a bad name, but... Is there a different variable that should be used instead? > 2. next-error-hook should not be used for core features, > you could call next-error-message-highlight directly > from next-error-found. Fixes. > PS: maybe a better name for defcustom would be next-error-message-highlight, > not next-error-message-highlight-p, to be more future-proof, > for the case when someone might want to add more choices later > (e.g. fringe, timers, etc.) And this. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no