From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file Date: Sun, 01 Nov 2020 13:06:00 +0100 Message-ID: <874km9ffiv.fsf@gnus.org> References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> <83r1pfalc4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12526"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: simenheg@runbox.com, 44303@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 01 13:08:11 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZC9a-00039o-H0 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 13:08:10 +0100 Original-Received: from localhost ([::1]:52336 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZC9Z-0001oT-In for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Nov 2020 07:08:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47450) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZC8U-0001Nv-9B for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 07:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52507) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZC8T-0006qC-Vi for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 07:07:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kZC8T-0004ZL-Pw for bug-gnu-emacs@gnu.org; Sun, 01 Nov 2020 07:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 12:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44303 X-GNU-PR-Package: emacs Original-Received: via spool by 44303-submit@debbugs.gnu.org id=B44303.160423237417506 (code B ref 44303); Sun, 01 Nov 2020 12:07:01 +0000 Original-Received: (at 44303) by debbugs.gnu.org; 1 Nov 2020 12:06:14 +0000 Original-Received: from localhost ([127.0.0.1]:35820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZC7i-0004YH-D6 for submit@debbugs.gnu.org; Sun, 01 Nov 2020 07:06:14 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:33346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZC7f-0004Y4-IW for 44303@debbugs.gnu.org; Sun, 01 Nov 2020 07:06:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Fw5u6K/4DFHCa26emsWZpZSrDT/eEwCnOVApd87XRLM=; b=HSBf+zThczhGmlmZfaBSDEVyHJ D3JFlgBOlWPMjYCCzHhCK5UF9Srlkd4JDF4Jl14C2tCbO+xIj8A8+feJZm+L08z31vlWClYZJn/By cxxtdpaovARGMx93bkIktYp/kdn4D45RXfVIxZ8M8Ae7UXkpaqY9WG/QIHPgS5lur/1s=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZC7W-00083i-0s; Sun, 01 Nov 2020 13:06:05 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEUIBQQiGhtHPjwx KypgWFUnHiCQiniooJHEuLGCenDZz8aMe4X///8w5ysyAAAAAWJLR0QMgbNRYwAAAAd0SU1FB+QL AQsmO/DtIKEAAAGrSURBVDjLjZK/T+NQDMftXqqu7xEiVmg6ICaSkIWpaqOrgOVClf8AFdgYqvrB hBCQiBmBxC0IEOllug3p7p/jvVKgJEZgOT/kT7527GcAAUIIAJDaUb4ZfG3uxOcB212A7mvU9uKd OOx40LPrZx3PvL3YTU6DNBukVq5ktpurQT4F10QjRUQWqZhGdE70Bs73M6JTi1Kkw8de7x0M9fc0 tGgk9XNvRqFIK3SNIzmmPKN0Cvqh33cDz8WuD82gq/0bDRoTjh6G+CUdpzQSISXG+h5L5zMtfrNG pSYXbAPUHjigx9gYc5KLv9AoWHAP1h8ulcpx4dhaZcB4vThotKuAsqPieIEBWyq7OFlZrILoiYpC MTVaW0/ZmKpx8CNfpUMGBG6NfncY0F+qRf+5E048sR1xQHrgz3kMcBJ9cbPCPhvVW5II4E1WAQaB +6IqWT1q6s6wskIIKEwQy7l+DH9eTYZUzoVusDZpGeOypp6EZtvQjktgvhWZ4tJ0zzWiwcdc1uXG zhT4H0GnZU7IkU643C4lMX9qB2GweTvTRmJHpjjYzWbr392sQAiUzxdMYtqOsupyAAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIwLTExLTAxVDExOjM4OjU5KzAwOjAwB6UZzAAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMC0xMS0wMVQxMTozODo1OSswMDowMHb4oXAAAAAASUVORK5CYII= X-Now-Playing: Melanie de Biasio's _A stomach is burning_: "Blue" In-Reply-To: <83r1pfalc4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 30 Oct 2020 15:34:51 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:192349 Archived-At: Eli Zaretskii writes: > But we then have this: > > if (modification_hooks_inhibited) > { > signal_after_change (BEGV, size_a, ZV - BEGV); > update_compositions (BEGV, ZV, CHECK_INSIDE); > } > > Does this not work, or fail to unlock the file? This does not unlock the file in the test case. >> But is that even needed here? Don't the later >> Finsert_buffer_substring/del_range_both functions do the necessary >> bookkeeping? > > We disable that by binding inhibit_modification_hooks, and we do that > for speed, see the comment before that code. Ah, I see. The missing piece of the puzzle was this bit, which I wasn't aware of: ---- Setting this variable non-nil also inhibits file locks and checks whether files are locked by another Emacs session, as well as handling of the active region per =E2=80=98select-active-regions=E2=80=99. ---- --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no