From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Karl Fogel Newsgroups: gmane.emacs.bugs Subject: bug#12507: [debbugs-tracker] Processed: severity 12507 wishlist Date: Sat, 28 Nov 2020 19:07:43 -0600 Message-ID: <874kl9t1gg.fsf@red-bean.com> References: Reply-To: Karl Fogel Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19053"; mail-complaints-to="usenet@ciao.gmane.io" To: 12507-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 29 02:08:19 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjBCM-0004qv-Fj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 02:08:18 +0100 Original-Received: from localhost ([::1]:33578 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjBCK-0005QW-Un for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Nov 2020 20:08:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjBCE-0005QC-Mn for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 20:08:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37852) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjBC6-0004vj-Gj for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 20:08:10 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kjBC6-00060m-Bw for bug-gnu-emacs@gnu.org; Sat, 28 Nov 2020 20:08:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Karl Fogel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Nov 2020 01:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12507 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 12507-done@debbugs.gnu.org id=D12507.160661206723084 (code D ref 12507); Sun, 29 Nov 2020 01:08:02 +0000 Original-Received: (at 12507-done) by debbugs.gnu.org; 29 Nov 2020 01:07:47 +0000 Original-Received: from localhost ([127.0.0.1]:49398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjBBq-00060G-Ld for submit@debbugs.gnu.org; Sat, 28 Nov 2020 20:07:46 -0500 Original-Received: from newsp.red-bean.com ([45.79.25.59]:42140 helo=sanpietro.red-bean.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjBBp-000605-EZ for 12507-done@debbugs.gnu.org; Sat, 28 Nov 2020 20:07:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date: Reply-To:Subject:To:From:Sender:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:In-Reply-To:References; bh=Je/vZaZHWfU6xUAJvCisvOB9edsdEKRk8HQHeAg1BS8=; t=1606612065; x=1607821665; b=afRkLBUCNAH33dG1jAUF1G7+nm7XII6fp0KJsUfKCO1Gn7OEQZQSVcjQIP+04bQMLXQWlXbrY7 jWrz2Jcbz+BnbOStIKvjy0dYYJRbaHocOq1N2UoUtyPdSH8uUTFC+QgeoFOP5oL/oQf6CvJkHJUGn PAxhVbc/93dJY2vAmbUSJOyK8aoYWOl/Uxd392FIFzm8oQ1+faHUVH+VfKUfhV43J3+1VsdpG3wn2 5tPJcolfXNitSLiB7sUMWjZbUTX13KK05LdrqDjl7kVHclRHNlNMLM6/ENe8dGHDFnfaxeU0SVQKg NLlTX/sj3lvn0GiyCKjOWv6i7I8wfPYb4BoWw==; Original-Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:33682 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjBBo-0006xm-Id for 12507-done@debbugs.gnu.org; Sun, 29 Nov 2020 01:07:44 +0000 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194521 Archived-At: Okay, this is done now: | commit 17fa17be3d93fc10f6ca91d738d5056b1b9f1f1e | Author: Karl Fogel | AuthorDate: Sat Nov 28 18:17:46 2020 -0600 | | Save bookmarks by using `write-file' (bug#12507) | | Go back to using `write-file' to save bookmarks, instead of using | `write-region'. This means numbered backups of the bookmark file may | get made again, depending on the value of `bookmark-version-control'. | | Thanks especially to Drew Adams and Eli Zaretskii for their | persistence in tracking down information relevant to this change. I committed it on the 'emacs-27' branch. That seemed like the right place for a small and safe change like this (in addition to running 'make check', I tested it manually to make sure it has the effects we expected). Although there's been a fair amount of activity in bookmark.el on 'master' recently (e.g., Stefan Kangas's changes to base `bookmark-bmenu-mode' on `tabulated-list-mode', for bug #39293), my commit does not conflict with any of that activity, so there should be no problem when 'emacs-27' is next automerged to 'master'. Closing bug #12507 with this message. Best regards, -Karl On 29 Sep 2020, Drew Adams wrote: >> >What's wrong with the obvious, simple solution to the >> >real, recognized problem of no backups for bookmark >> >files: use `write-file'? That's the first question >> >to ask and answer, no? >> >> I can't think of any reason now. I have a vague memory that there *was* a >> specific reason, but if there was, I failed to document adequately at the >> time and have been unable to recover it now. >> >> Eli helpfully linked to Richard's message >> (https://urldefense.com/v3/__https://lists.gnu.org/archive/html/emacs- >> devel/2005- >> 05/msg01376.html__;!!GqivPVa7Brio!OesHeMbHNKqFeUCyyW2WJ0UeXBZjSXngBYlvA1Q5G9F >> zXXgAa30g7LGrcwolObMB$ ), in which Richard points out that if bookmark visits >> the file anyway when reading, then there's nothing to be gained (from the >> perspective of saveplace.el interference) from avoiding visiting it when >> writing. >> >> And `bookmark-load' *does* visit the file when reading, so I'm leaning toward >> just taking your suggestion and reverting to `write-file' -- but this time >> leaving better historical breadcrumbs (in comments and/or log messages) in >> case my vaguely-remembered bug turns out to be real and reappears. >> >> I will do this as soon as I have time to focus on it and make sure I don't >> make a silly blunder; that may be several days. > >Thanks for looking into this, Karl. (No hurry.)