From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#46387: 28.0.50; Compiled code making a variable dynamic stopped working Date: Wed, 10 Feb 2021 04:20:46 +0100 Message-ID: <874kiksj5d.fsf@web.de> References: <87h7mm79ij.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3140"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 46387@debbugs.gnu.org, monnier@iro.umontreal.ca To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 10 04:22:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9g4v-0000ib-Fh for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Feb 2021 04:22:09 +0100 Original-Received: from localhost ([::1]:54946 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9g4u-0002N0-IW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 09 Feb 2021 22:22:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47782) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9g4o-0002Mt-0R for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 22:22:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43725) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9g4n-0000vR-Pz for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 22:22:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l9g4n-0005w8-Lh for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 22:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Feb 2021 03:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46387 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.161292728022769 (code B ref -1); Wed, 10 Feb 2021 03:22:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 Feb 2021 03:21:20 +0000 Original-Received: from localhost ([127.0.0.1]:55271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9g48-0005vB-5q for submit@debbugs.gnu.org; Tue, 09 Feb 2021 22:21:20 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:56558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l9g46-0005v3-Rq for submit@debbugs.gnu.org; Tue, 09 Feb 2021 22:21:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47688) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9g46-0002Lr-KT for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 22:21:18 -0500 Original-Received: from mout.web.de ([217.72.192.78]:51033) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9g43-0000Zc-Jv for bug-gnu-emacs@gnu.org; Tue, 09 Feb 2021 22:21:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1612927248; bh=FD0FCZQeXeUeTCbSZZxDlZn8WOTt7lymmvLaOh8PpcA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=NKCW5MHn+KjW1DQfe/w2jnO9mNWWzka2Y66qYFoHjpaRU00uVLtymWSQE9W0UG6Z4 PwUr8grJpG45RYbvSQxHduLTAcqsYkHt/iI//7am9cK3gq8pr/jM7OcnUB8mWLv45u qD0rxWFupjHUqEom3rINUGWzTkz7cYs1gWF9X6yM= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([94.218.220.60]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LkPjj-1lkOip2omp-00cN39; Wed, 10 Feb 2021 04:20:48 +0100 In-Reply-To: ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Tue, 9 Feb 2021 11:32:58 +0100") X-Provags-ID: V03:K1:KDEocYeqMKmz0LsoTWqXg9bffhEMwDHoVC6j4fGYfoVbiJXhjxY Cb9iny6rWZEoOnPgJ2hpYyBZHwN6QvNnM4fnR1M69+m48V/MtfHYoZpmLVXIrJtsgx/n4Aw ool5piwB/K0Zunc9bbYdbffM1zXWkGg6hySPzP6Napl2AqK1dfpHkzMEMF290MkOVwPz/ZZ VKQlzTXD+UcMRPLKxL7Cw== X-UI-Out-Filterresults: notjunk:1;V03:K0:nGxDqyYw7+0=:pQYTh87gQKqkHFijKPTk/T yuUyPmIYoRuo+Y5TQ0j6sJ/t8HLBHJr8rc6bUoRvyUY02JDB0zBS4arfuit5NUrErY9QR4a49 ZaYRs8oHRh1Axyb/sEMV3bX8srRVEsA9pMm487S33E8UBdoG7/8c7k5tspuGh5TVvjzZaBumO msDw5zo9Mb9mpoJXtmWqfdgwb7gCSwP0hy9ZiybXUta+nsMAMnMOuzSRoiHkzzBLAYlIcf/gJ VmHta28KOfaqOSwcd+sjbLXGePhwmSiBQlRh7RtOgvPlu3XYv28NsM8TC0xsl08DUy8YRrdax lhh42PvnJ9S8ltzggmOKyWGoW9gVAyqi51F4rslf4PxDIYIrlnJhCHYUkn/VG/JcZhnB74aMm t3LH5U+xuzN9WjWk4rR5Tn/4xa20UCkFfs3NWtJ+tm4JDPVJCIBzEFtbtqImJOdJC+XAAyc0i /AfrNIEiBiKcMTNvrDEpDGV/vw+OXtBfpd8F95n4zoy0N0Q0Ah9w1v5yjGw+yppLd3YwKC1gG 65G6JNSGeKwWn6cWiqGDkf+gk3/NFfu8b6kVBs05s8d0yhk9Nj9S/0eS2+cSNH5qcFpMyefar 9GgtHqq3ITqudvV1S3e4YxGpzmLG3l6mCmTJ3CoBBPze8M8L3VlemdK+/TF/gnrKaZlECvOLT 3+WoxUbg9fn/ODL0QsHJLFpG5DNcGXkxtfU0vVj/FM4XYHgbhNVTAPT8etVvWITEmz/zfGZOn ThzgBRZ3Ddc7B5bs3agq8LtH7/ZoBRNXcmr2FCxnwXWp50ssHv391yrpHxoll5ge7QiBFJ+d Received-SPF: pass client-ip=217.72.192.78; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199754 Archived-At: Mattias Engdeg=C3=A5rd writes: > As it turns out, parts of the implementation have different opinions > about that. As you observed, the recently added optimisation on master > takes a strict syntactic view: even a `progn` is a lexical scope, and > `with-suppressed-warnings` wraps its body in a `progn`; thus your > `defvar` declarations have no effect outside that construct. Seems this is the related code change (took quite a while until I found that): 83983b6b7a115474572973b62eb5e42251713e63 Author: Mattias Engdeg=C3=A5rd AuthorDate: Sat Feb 6 18:34:45 2021 +0100 (defun byte-optimize-body (forms all-for-effect) ;; Optimize the cdr of a progn or implicit progn; all forms is a list of @@ -590,6 +763,7 @@ byte-optimize-body ;; all-for-effect is true. returns a new list of forms. (let ((rest forms) (result nil) + (byte-optimize--dynamic-vars byte-optimize--dynamic-vars) fe new) (while rest (setq fe (or all-for-effect (cdr rest))) Should that line just be removed? TIA, Michael.