From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: handa Newsgroups: gmane.emacs.bugs Subject: bug#45379: 28.0.50; Degraded Performance of describe-buffer-bindings Date: Sun, 07 Mar 2021 10:42:39 +0900 Message-ID: <874khnzqls.fsf@gnu.org> References: <87a6u5m566.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28031"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stephen.berman@gmx.net, 45379@debbugs.gnu.org, stefan@marxist.se, juri@linkov.net, handa@gnu.org, monnier@iro.umontreal.ca, styang@fastmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 07 02:44:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lIiSw-0007C9-As for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Mar 2021 02:44:18 +0100 Original-Received: from localhost ([::1]:35678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIiSv-0006yC-9U for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Mar 2021 20:44:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lIiSg-0006y1-0S for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 20:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55336) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lIiSf-0005sc-OL for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 20:44:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lIiSf-0002rF-LK for bug-gnu-emacs@gnu.org; Sat, 06 Mar 2021 20:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: handa Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Mar 2021 01:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45379 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch confirmed Original-Received: via spool by 45379-submit@debbugs.gnu.org id=B45379.161508138210903 (code B ref 45379); Sun, 07 Mar 2021 01:44:01 +0000 Original-Received: (at 45379) by debbugs.gnu.org; 7 Mar 2021 01:43:02 +0000 Original-Received: from localhost ([127.0.0.1]:38649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIiRe-0002pR-90 for submit@debbugs.gnu.org; Sat, 06 Mar 2021 20:43:02 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lIiRZ-0002pB-94 for 45379@debbugs.gnu.org; Sat, 06 Mar 2021 20:42:56 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49440) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lIiRR-0005ot-Vn; Sat, 06 Mar 2021 20:42:46 -0500 Original-Received: from fl1-60-236-248-230.iba.mesh.ad.jp ([60.236.248.230]:49514 helo=shatin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1lIiRQ-0000no-EE; Sat, 06 Mar 2021 20:42:45 -0500 Original-Received: from handa by shatin with local (Exim 4.93) (envelope-from ) id 1lIiRL-0003E4-Aw; Sun, 07 Mar 2021 10:42:39 +0900 In-Reply-To: <83v9a4wve3.fsf@gnu.org> (message from Eli Zaretskii on Sat, 06 Mar 2021 10:15:16 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:201706 Archived-At: In article <83v9a4wve3.fsf@gnu.org>, Eli Zaretskii writes: > > From: Stefan Kangas > > Date: Fri, 5 Mar 2021 20:44:33 -0800 > > Cc: Juri Linkov , martin rudalics , Eli Zaretskii , > > 45379@debbugs.gnu.org, Stefan Monnier , > > Stephen Berman > > > > It turns out that we were doing unnecessary looping due to the above > > mentioned commit. Could you show me what is "the above mentioned commit"? > > While working on this, I also found that we can get > > rid of an unnecessary call to char_table_ref_and_range, which should > > make this function run even faster. Is the patch for the above improvement the one included in the file 0001-Fix-describe-buffer-bindings-performance-regression.patch? > > I'm also copying in Kenichi Handa, who was the last to touch this code. > > Handa-san, please let us know if you have any comments on this patch. > > Thanks in advance. > AFAICT, you didn't CC Kenichi; I have now added him to the discussion. It was more than 10 years ago that I last read keymap.c, and since then, the code has been changed a lot. It will take some time to understand the latest code. --- K. Handa handa@gnu.org