From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#48037: 28.0.50; add-change-log-entry does not detect name with digit Date: Tue, 27 Apr 2021 09:30:19 +0200 Message-ID: <874kfskwvo.fsf@gmx.de> References: <87mttlkpvb.fsf@gmx.de> <87k0oo1i7l.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40525"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 48037@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 27 09:31:29 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lbIBt-000ADo-1s for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Apr 2021 09:31:29 +0200 Original-Received: from localhost ([::1]:48458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lbIBs-0004F0-1M for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Apr 2021 03:31:28 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lbIBS-0004DL-BO for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 03:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36393) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lbIBS-0007pF-36 for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 03:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lbIBS-0002zz-0l for bug-gnu-emacs@gnu.org; Tue, 27 Apr 2021 03:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Apr 2021 07:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48037 X-GNU-PR-Package: emacs Original-Received: via spool by 48037-submit@debbugs.gnu.org id=B48037.161950863011461 (code B ref 48037); Tue, 27 Apr 2021 07:31:01 +0000 Original-Received: (at 48037) by debbugs.gnu.org; 27 Apr 2021 07:30:30 +0000 Original-Received: from localhost ([127.0.0.1]:47933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbIAw-0002yn-3Y for submit@debbugs.gnu.org; Tue, 27 Apr 2021 03:30:30 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:48825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lbIAt-0002yW-6I for 48037@debbugs.gnu.org; Tue, 27 Apr 2021 03:30:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619508621; bh=kxGIBoQQOlsMuRMSo9KYC80EbEbNEJO7Cbq3mIYptIw=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=i8TgGiEp6atPhK6e6SFrsgye9UtgIMepMxCKiknWVJxTntSUbjHp9Ur4dheVjVGsv oVe5UmTSw9HMfzTEj2lsIEqeDGxjmwk29GVtyh+HA6ep4QD7+IlIObNIuj7h7GHOZk IhphjLzvI1k+2RPosQrSVANpK6WudV3DOa20d79g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.54.40]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mt79F-1lLXVN3Ci9-00tTW7; Tue, 27 Apr 2021 09:30:20 +0200 In-Reply-To: <87k0oo1i7l.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 27 Apr 2021 06:09:50 +0200") X-Provags-ID: V03:K1:PY7a5QLF7WGnZCt+jYCmzCdn1RJcR3lKXW9f3t38BLYOxmcIbDt Pc+bRdxxpDjCdmU86Db2fc/xYJEWSKLDizNdNLJiPxMvKlofo03P4gD9/yybA8gdzv27tb+ hVSSSbKB3NsS/cTVY1YC0MFRGHUzTEFAGhnlvHPvGIRmNj61+B7+JW995t7T4O8UyDcUC5A GCmavStrXftL7HMB47xkA== X-UI-Out-Filterresults: notjunk:1;V03:K0:0esXg7+yWjE=:XNKXAl6q4s+dp8kR9Or3Jr qE1taqzpZH6H0VfiHbfQKMBTQTzpYz74W0+yixKje/TFvaAUcCI6afUDuML+UzAbPGesQTH11 Ae5rebUdd0HAhWOzMYQJs57lr+JuILrJ13jsGXDPXnnz8KLF29CpFqd9L2KOETmIRoIbqfbv2 +LLSFdA5iVI6W2MKaUZmtgK1xw770G1u9s65Tl1P4km5OJWYWHoKhNy/yIuuGs1G0TVjxd8as 2XAdRsMrMOmBRlhj2UNoCzYH4XHLDmcLDde/zoPnEMOI6hQq1BdG/4LEJIudA8+P4zhmQ/yWg 4VOCkKIhsb/7qjynNq/Tdy0x6RuxybkFkMZ6xd+rqYAi3VQlNv9+6sgW4i005IStNnV4RUGDm RGwTtmAKKtLjVqQa0We8e+2ReJKTjiB9HhNPznl2xOkwKcMSnIGAfg+CH+R03HvsxNlRuJyK2 SQuj8PQdUasLGcXYyvdgj+0iBEO0tHijyjdA/PfeyXE0sr31CCe9UGrmAfHZ2BgDUAJwkEzA5 1oi829YGnBYaMMzqiavlkTCNF3xUGk8/7tisB5KPX1mjNgOyYJruKV8OXSla/7MDgzdnCCO1S P2SbfZAU5lVQXMtmNSln2NKOyllzww1XBMP1O+pxEja9We6RhWM2ZZ3Sp6hbs+9czERSfRGJ7 TYU3IP2Ds40d8BOo6vydimi9YK1fOuEiyZbTPHtW00+81Cd10tWgb3BfJ8xtQnlHbiBnzqRLu Tz0Tki63PIF/ic4Z7l9LiPF0iPkxiC+HarQNncI/zIwSsAeYm6qP+wLshunDm23ZstMDv2TK X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205002 Archived-At: Lars Ingebrigtsen writes: Hi Lars, >> (defcustom add-log-current-defun-header-regexp >> - "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alpha:]]+\\)[ \t]*[:=]" >> + "^\\([[:upper:]][[:upper:]_ ]*[[:upper:]_]\\|[-_[:alnum:]]+\\)[ \t]*[:=]" >> "Heuristic regexp used by `add-log-current-defun' for unknown major modes. > > This would also catch stuff like > > 2: > stage: slow > > which looks like a false positive? So I think there should be some > alpha in there. Probably. Yes. However, the existing regexp hits also entries like -: stage: slow Looks also strange. So my proposal won't get worse. Remember, add-log-current-defun-header-regexp is just a heuristic. Alternatively, I could just give gitlab-ci.yml a file-local value for this variable, and let the lions sleep :-) Best regards, Michael.