From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" Newsgroups: gmane.emacs.bugs Subject: bug#48179: bookmark-fontify [PATCH] Date: Thu, 06 May 2021 20:41:36 +0100 Message-ID: <874kff645r.fsf@tcd.ie> References: <20210503091204.qhc2tda76wh6345w@E15-2016.optimum.net> <87im40cgxz.fsf@gnus.org> <20210503095828.66mcqkxyznb2vdja@E15-2016.optimum.net> <87v97yan85.fsf@gnus.org> <87lf8uan2m.fsf@gnus.org> <87zgxan7lx.fsf@tcd.ie> <878s4t8up2.fsf@gnus.org> <8735v1jrit.fsf@tcd.ie> <20210505163038.bq4oupkuiago6kcd@E15-2016.optimum.net> <8735uzvgo8.fsf@tcd.ie> <20210506191305.udoxdyv3jfcta6x6@E15-2016.optimum.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13602"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 48179@debbugs.gnu.org To: Boruch Baum Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 21:42:43 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lejtS-0003Q9-TN for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 21:42:42 +0200 Original-Received: from localhost ([::1]:34012 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lejtS-0008W0-04 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 15:42:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lejsq-0008VS-5S for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 15:42:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56005) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lejsn-00054C-LI for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 15:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lejsn-0007Cr-JR for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 15:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 19:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48179 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch fixed Original-Received: via spool by 48179-submit@debbugs.gnu.org id=B48179.162033010627691 (code B ref 48179); Thu, 06 May 2021 19:42:01 +0000 Original-Received: (at 48179) by debbugs.gnu.org; 6 May 2021 19:41:46 +0000 Original-Received: from localhost ([127.0.0.1]:39316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lejsX-0007CZ-TR for submit@debbugs.gnu.org; Thu, 06 May 2021 15:41:46 -0400 Original-Received: from mail-wr1-f41.google.com ([209.85.221.41]:39702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lejsV-0007CT-K8 for 48179@debbugs.gnu.org; Thu, 06 May 2021 15:41:45 -0400 Original-Received: by mail-wr1-f41.google.com with SMTP id v12so6813135wrq.6 for <48179@debbugs.gnu.org>; Thu, 06 May 2021 12:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=D7QXeSFZZ5B+VR3llESwoC5bhnlqU7rBVAvE2gyA5Ns=; b=Xe8GbJcXoxQf5JztyoPMZzHO1eqZS8nNQ8v4h7jJzRgCwDsH5ynhLYbK6CbSt0EL0m HdJUIancYeRKhrRXRj64s6Pay2VgKX94vQVuIMxOkAO/ldtFzxf5JqZiGlhd+J9nChom FWbYiOR40j1FWihcAMeGmYk89axQR2WBD7BDOf+M31CewqlVM3P974usIt9+MgKV8FUW mOLOgxJ76/3XaD0NuD4DBpB49+uG4LcXwt+SoUv1/xeNCk6a2R62crBwdTrhFh//dy/v f6HVjU6bZ4jyGHkR6H4dVVF4jJzunxzZLMowycaxcYwv80Msiw+4CvKd3jviZPurVJBq D5Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=D7QXeSFZZ5B+VR3llESwoC5bhnlqU7rBVAvE2gyA5Ns=; b=jr6DeDySceBjzjJtAnuGUa/N5dldk9s5utqgW5CVWQPiCy7oqS5+jqJZ5xgi6voF+p ejC7EN+xbiyBJKyXGAvFNs4hAI7IL23kfXUb+ip5CC68GAmLM/7VmuQ31NB1zgaJbeNQ 0AbCwgNp1kJT2aEwOhjtn/uB+LHIZ4HXqFc8qNZFwsCow0lLNIimZq3FIziJsxFlNAU3 nuZ9LvNtJChDMAuRWbZQU6P82DKuyeCIcNFNZ/2LY4Rfs0krWPt9u4N/l0jtj7rlBcoK goLoYkB32tMXFp3VI+EA7rYOiYqb0xPvhzAJk7LBRZ0aD1rEzgQOukSuzwv+/wj1GTBw EIFQ== X-Gm-Message-State: AOAM532OIQHfyRbo7LJt+XVU//C3UGOolqXVaQ29U9RfdGV2E9OGw7Ov xNpmj8eJKsXXUnuo0zuyx3C36A== X-Google-Smtp-Source: ABdhPJwHiC4CZ3XH3wPCVyTInkKwJhDUfw7x5nTiIEitILXn9bAd4nhQs6JGBeGDXWRphMaKcaa0+g== X-Received: by 2002:a5d:674c:: with SMTP id l12mr7303977wrw.357.1620330097761; Thu, 06 May 2021 12:41:37 -0700 (PDT) Original-Received: from localhost ([2a02:8084:20e2:c380:d15:339e:aa10:60f1]) by smtp.gmail.com with ESMTPSA id j18sm4143585wmq.27.2021.05.06.12.41.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 May 2021 12:41:37 -0700 (PDT) In-Reply-To: <20210506191305.udoxdyv3jfcta6x6@E15-2016.optimum.net> (Boruch Baum's message of "Thu, 6 May 2021 15:13:05 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205877 Archived-At: Boruch Baum writes: > On 2021-05-06 19:52, Basil L. Contovounesios wrote: >> I wouldn't worry, since I only set out to fix a couple of typos - I >> don't intend to work on bookmark.el any time soon. > > Not what you did. No, that's exactly what I did: I set out to fix a couple of typos. Once I'd set out to do that, I noticed that the new bookmark-face was using an old-fashioned face spec syntax and two docstrings referenced 'defcustom' without quoting it where the English phrase "user option" is more commonly used. While there, I noticed that bookmark--fontify could use 1+ and bookmark--unfontify could use dolist, to make it clearer to the next reader what that loop is doing, and when it will terminate. Just like the log message promises: ; Fix and simplify last change in bookmark.el. 7d0067f297 2021-05-04 10:54:24 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=7d0067f297b131c98a5198eb52d49891a83ac5aa -- Basil