From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spencer Baugh Newsgroups: gmane.emacs.bugs Subject: bug#48264: [PATCH v3 06/15] Rearrange set_internal for buffer forwarded symbols Date: Fri, 07 May 2021 10:26:20 -0400 Message-ID: <874kfer56b.fsf@catern.com> References: <877dkbsj9d.fsf@catern.com> <20210506213346.9730-7-sbaugh@catern.com> <838s4qddpd.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36798"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48264@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 07 16:27:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf1Rd-0009PV-FM for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 16:27:09 +0200 Original-Received: from localhost ([::1]:52286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf1Rc-000295-Ey for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 May 2021 10:27:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf1RW-00028z-Q4 for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 10:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60942) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lf1RW-0006QI-Iw for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 10:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lf1RW-0007QE-FP for bug-gnu-emacs@gnu.org; Fri, 07 May 2021 10:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Spencer Baugh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2021 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48264 X-GNU-PR-Package: emacs Original-Received: via spool by 48264-submit@debbugs.gnu.org id=B48264.162039758928517 (code B ref 48264); Fri, 07 May 2021 14:27:02 +0000 Original-Received: (at 48264) by debbugs.gnu.org; 7 May 2021 14:26:29 +0000 Original-Received: from localhost ([127.0.0.1]:44253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf1Qy-0007Pt-P3 for submit@debbugs.gnu.org; Fri, 07 May 2021 10:26:28 -0400 Original-Received: from venus.catern.com ([68.183.49.163]:33618) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lf1Qx-0007Pn-1V for 48264@debbugs.gnu.org; Fri, 07 May 2021 10:26:27 -0400 Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=98.7.229.235; helo=localhost; envelope-from=sbaugh@catern.com; receiver= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=catern.com; s=mail; t=1620397581; bh=+sX5Cj8JEeUvWtDc3Vtc74JNrbizF6CQTWPUUuclVgU=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=FYKMIGnk3Uer9Pru7dc8mXK2DzhJHVNb1+yChlI23mAQalfX0YCCwwOIBrSPVDi8O EruC1SiMF+svqwKuKvSrzd15jCNTGd2/ayOnQI5aoxRdPt+EABigviW8lD9BI6FWfU 4F65uZFDAi5ICgaPYGIo8lpUE1MnDZPppa3j3qvA= Original-Received: from localhost (cpe-98-7-229-235.nyc.res.rr.com [98.7.229.235]) by venus.catern.com (Postfix) with ESMTPSA id 452802E4579; Fri, 7 May 2021 14:26:21 +0000 (UTC) In-Reply-To: <838s4qddpd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205944 Archived-At: Eli Zaretskii writes: >> From: Spencer Baugh >> Date: Thu, 6 May 2021 17:33:37 -0400 >> Cc: Spencer Baugh >> >> --- a/src/data.c >> +++ b/src/data.c >> @@ -1320,6 +1320,9 @@ store_symval_forwarding (lispfwd valcontents, Lisp_Object newval, >> if (buf == NULL) >> buf = current_buffer; >> set_per_buffer_value (buf, offset, newval); >> + int idx = PER_BUFFER_IDX (offset); >> + if (idx > 0) >> + SET_PER_BUFFER_VALUE_P (buf, idx, 1); > > It looks like you customized indent-tabs-mode to nil in C modes (or > maybe don't use Emacs?) because your indentation uses only spaces. > Please use our conventions in C sources, which uses TABs and spaces, > per indent-tabs-mode's default value. > > This is a general comment, because I see signs of this in all of your > patches. Sorry about that, I reverted indent-tabs-mode to t a while ago, but I forgot to convert some of these some of these patches to use tabs.