From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#20846: 24.4; Electric-indent-mode does not call indent-line-function after hitting RET inside a comment Date: Sat, 29 May 2021 04:26:29 +0200 Message-ID: <874kemwa0a.fsf@gnus.org> References: <871r9t6pgd.fsf@gnus.org> <838s40acf9.fsf@gnu.org> <87sg273fqo.fsf@gnus.org> <83fsy78l2p.fsf@gnu.org> <49c82e08-f15e-e564-1740-86271fc94f3b@yandex.ru> <8335u780u6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5798"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: robin.neatherway@gmail.com, 20846@debbugs.gnu.org, Dmitry Gutov To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 29 04:27:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmogw-0001Kk-82 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 29 May 2021 04:27:10 +0200 Original-Received: from localhost ([::1]:48666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lmogu-0003oX-LI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 28 May 2021 22:27:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41444) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lmogo-0003oM-C0 for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 22:27:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lmogo-0006AC-1n for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 22:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lmogn-000594-Oh for bug-gnu-emacs@gnu.org; Fri, 28 May 2021 22:27:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 May 2021 02:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20846 X-GNU-PR-Package: emacs Original-Received: via spool by 20846-submit@debbugs.gnu.org id=B20846.162225520119751 (code B ref 20846); Sat, 29 May 2021 02:27:01 +0000 Original-Received: (at 20846) by debbugs.gnu.org; 29 May 2021 02:26:41 +0000 Original-Received: from localhost ([127.0.0.1]:55597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmogT-00058V-IM for submit@debbugs.gnu.org; Fri, 28 May 2021 22:26:41 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:33234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lmogR-00058H-Ao for 20846@debbugs.gnu.org; Fri, 28 May 2021 22:26:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VAxu0lYSZLgCfYADQvCybe/N/7UB/BXTjMiqjoBTZAA=; b=cq7RgHeEUdovPNlU4DlrZiVpqm q18zoc/6okADO4DyE5JUlInS3SbFVrtxj7B9qG83P1lZ+TWNcHUg+Yi077Cw7iYwYNv5mTnZt25an sNmCNfc2Tg7/cGequmIku9QWFTn5ck65iWkHVGXQp2KXXdgjJ6AXBiN0ynTJRZ7iitDk=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lmogH-0008PS-Uv; Sat, 29 May 2021 04:26:32 +0200 X-Now-Playing: Joni Mitchell's _Joni Mitchell_: "Sisotowbell Lane" In-Reply-To: (Stefan Monnier's message of "Fri, 28 May 2021 10:09:41 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207483 Archived-At: Stefan Monnier writes: > The (nth 8 (syntax-ppss)) test has been in `electric-indent-mode` from > the very beginning, but I must say I can't remember why I put it in, > I think it was a mistake and we should remove it. This bit? (when (and [...] (not (or (memq act '(nil no-indent)) ;; In a string or comment. (unless (eq act 'do-indent) (nth 8 (syntax-ppss)))))))) Uhm... I stared at that logic for a couple of minutes, but I'm still not able to convince myself that I understand it, so could you do the necessary here? :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no