From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#11301: 24.1.50; `define-minor-mode' should set `custom-mode-group' according to :group Date: Thu, 03 Jun 2021 09:45:34 +0200 Message-ID: <874kefbdcx.fsf@gnus.org> References: <3208B35C4FFE47FFBD0A7029AB2DBB8C@us.oracle.com> <87wnrc7o3p.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22328"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 11301@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 03 09:46:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loi3j-0005Zq-SD for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Jun 2021 09:46:31 +0200 Original-Received: from localhost ([::1]:52480 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loi3i-0000rk-Bq for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 03 Jun 2021 03:46:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60264) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loi3H-0000qj-Pc for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 03:46:07 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58720) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loi3G-0000ML-Jc for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 03:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loi3G-0002go-FV for bug-gnu-emacs@gnu.org; Thu, 03 Jun 2021 03:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Jun 2021 07:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11301 X-GNU-PR-Package: emacs Original-Received: via spool by 11301-submit@debbugs.gnu.org id=B11301.16227063489583 (code B ref 11301); Thu, 03 Jun 2021 07:46:02 +0000 Original-Received: (at 11301) by debbugs.gnu.org; 3 Jun 2021 07:45:48 +0000 Original-Received: from localhost ([127.0.0.1]:42033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loi31-0002UB-Rr for submit@debbugs.gnu.org; Thu, 03 Jun 2021 03:45:48 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:39462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loi2z-0002N8-NS for 11301@debbugs.gnu.org; Thu, 03 Jun 2021 03:45:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Gj6stauylHZb4r10PyoJXAr7Tl3mVAVShdWNM31+KLM=; b=fLGUhKcNnu5tIZzcGB/g6kRYTj o/W6mSpcxl1G5a332JoJs5i+/jeKheW/p/d3mHiias68D6KAVcmEM31u9GRBmhF1RpKhigjQXHg5G lDaDThC2e0u+ifW67zWT/oLow8JUasffor5GY+ZVg35CBEePeTI8dMEfB7mjK9Q1B7BU=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1loi2p-0007vd-FL; Thu, 03 Jun 2021 09:45:38 +0200 X-Now-Playing: Little Simz's _Grey Area_: "Offence" In-Reply-To: (Stefan Monnier's message of "Wed, 02 Jun 2021 09:25:18 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207899 Archived-At: Stefan Monnier writes: > Since the `:group` was only used for the `defcustom`, I just removed > this special handling. It doesn't mean it doesn't work any more, but > now it's just another one of the keyword args that are simply passed > as-is to `defcustom`. Ah, I see. But it seems like `define-minor-mode' just discards :group now. Here's a test case: (define-minor-mode foo-mode "doc" :group 'mouse) Since this isn't a global minor mode, we end up in this branch: ((not globalp) `(progn :autoload-end (defvar-local ,mode ,init-value ,(concat (format "Non-nil if %s is enabled.\n" pretty-name) (internal--format-docstring-line "Use the command `%s' to change this variable." mode))))) and :group (which ends up in `extra-keywords') isn't used. Should this instead use `defcustom' with :local t? I.e., basically merge with the global case in that cond? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no