From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ivan Sokolov Newsgroups: gmane.emacs.bugs Subject: bug#49609: [PATCH] Add option for handling SGR control sequences in compilation-mode Date: Tue, 20 Jul 2021 00:47:45 +0300 Message-ID: <874kcqm0vy.fsf@ya.ru> References: <87a6mkohob.fsf@ya.ru> <877dhooh5w.fsf@ya.ru> <875yx8v5i9.fsf@gnus.org> <87tuksmou1.fsf@ya.ru> <83o8b02jx3.fsf@gnu.org> <87zguio1ex.fsf@gnus.org> <834kcq71eu.fsf@gnu.org> <87zguijo4t.fsf@gnus.org> <83v9565kdk.fsf@gnu.org> <87tukqi6q0.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37169"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49609@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 19 23:49:19 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5b8Z-0009Tf-D4 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 23:49:19 +0200 Original-Received: from localhost ([::1]:45020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5b8Y-00078F-68 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 17:49:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36212) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5b8H-000747-Sh for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 17:49:01 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48991) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5b8H-0000uN-KB for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 17:49:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5b8H-0002Pe-Hm for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 17:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Sokolov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jul 2021 21:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49609 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49609-submit@debbugs.gnu.org id=B49609.16267312859213 (code B ref 49609); Mon, 19 Jul 2021 21:49:01 +0000 Original-Received: (at 49609) by debbugs.gnu.org; 19 Jul 2021 21:48:05 +0000 Original-Received: from localhost ([127.0.0.1]:60537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5b7N-0002OW-6c for submit@debbugs.gnu.org; Mon, 19 Jul 2021 17:48:05 -0400 Original-Received: from forward104j.mail.yandex.net ([5.45.198.247]:56541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5b7M-0002Ny-3t for 49609@debbugs.gnu.org; Mon, 19 Jul 2021 17:48:04 -0400 Original-Received: from sas1-5f1844c300c3.qloud-c.yandex.net (sas1-5f1844c300c3.qloud-c.yandex.net [IPv6:2a02:6b8:c14:5781:0:640:5f18:44c3]) by forward104j.mail.yandex.net (Yandex) with ESMTP id 9551F4A1266; Tue, 20 Jul 2021 00:47:57 +0300 (MSK) Original-Received: from sas1-e00c2743cdb8.qloud-c.yandex.net (sas1-e00c2743cdb8.qloud-c.yandex.net [2a02:6b8:c14:3a22:0:640:e00c:2743]) by sas1-5f1844c300c3.qloud-c.yandex.net (mxback/Yandex) with ESMTP id hV3oBsecPX-lvHKTJgW; Tue, 20 Jul 2021 00:47:57 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ya.ru; s=mail; t=1626731277; bh=SlQWRc46QzISqpo2aYO1UgqNyBPhBl+c4x+HeDyOqXg=; h=In-Reply-To:References:Date:Subject:To:From:Message-ID:Cc; b=e9JlbTGuAZgn0g6WzP0rEKK5xq064tCTtHKF5hx/NaDfhP3p9xvFvvuKDmJUeZBx0 gfLUmfvZZ3HERZMuyl25oSX8i0KnGI5V6FId/E2kl7UK4P5fa4GbduqNq00PkrH2bZ LRPD3oVpsb3266apsKDKu9R85WWq6HOuU60AxHrA= Authentication-Results: sas1-5f1844c300c3.qloud-c.yandex.net; dkim=pass header.i=@ya.ru Original-Received: by sas1-e00c2743cdb8.qloud-c.yandex.net (smtp/Yandex) with ESMTPSA id PlCRIkqI5l-lt2WoTQv; Tue, 20 Jul 2021 00:47:55 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) In-Reply-To: <87tukqi6q0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 19 Jul 2021 18:55:19 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210312 Archived-At: Lars Ingebrigtsen writes: > I wonder whether `ansi-color-compilation-filter' should be in > `compilation-filter-hook' by default? I don't think so. Well designed (machine readable) output can be parsed and colored by compilation-mode itself, this filter is most usable in two cases. First, if the output is exclusively human readable and cannot be parsed, it would be nice to have at least a native coloring. Examples: Elixir. Second, if the output is machine redable, but the tool cannot detect that the terminal is non-interactive and/or it does not have an option to turn off colorization, `filter' will allow compilation-mode to process the output.