unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ivan Sokolov <ivan-p-sokolov@ya.ru>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 49609@debbugs.gnu.org
Subject: bug#49609: [PATCH] Add option for handling SGR control sequences in compilation-mode
Date: Tue, 20 Jul 2021 00:47:45 +0300	[thread overview]
Message-ID: <874kcqm0vy.fsf@ya.ru> (raw)
In-Reply-To: <87tukqi6q0.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 19 Jul 2021 18:55:19 +0200")

Lars Ingebrigtsen <larsi@gnus.org> writes:

> I wonder whether `ansi-color-compilation-filter' should be in
> `compilation-filter-hook' by default?

I don't think so. Well designed (machine readable) output can be parsed
and colored by compilation-mode itself, this filter is most usable in
two cases.

First, if the output is exclusively human readable and cannot be parsed,
it would be nice to have at least a native coloring. Examples: Elixir.

Second, if the output is machine redable, but the tool cannot detect
that the terminal is non-interactive and/or it does not have an option
to turn off colorization, `filter' will allow compilation-mode to
process the output.





  parent reply	other threads:[~2021-07-19 21:47 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-17 19:37 bug#49609: [PATCH] Add option for handling SGR control sequences in compilation-mode Ivan Sokolov
2021-07-17 19:48 ` Ivan Sokolov
2021-07-18  0:18   ` Lars Ingebrigtsen
2021-07-18  0:45     ` Ivan Sokolov
2021-07-18  6:52       ` Eli Zaretskii
2021-07-19 13:53         ` Lars Ingebrigtsen
2021-07-19 15:45           ` Eli Zaretskii
2021-07-19 15:53             ` Lars Ingebrigtsen
2021-07-19 16:38               ` Eli Zaretskii
2021-07-19 16:55                 ` Lars Ingebrigtsen
2021-07-19 17:20                   ` Eli Zaretskii
2021-07-19 21:47                   ` Ivan Sokolov [this message]
2021-07-20 11:35                     ` Lars Ingebrigtsen
2021-07-19 20:19               ` Ivan Sokolov
2021-07-17 20:57 ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kcqm0vy.fsf@ya.ru \
    --to=ivan-p-sokolov@ya.ru \
    --cc=49609@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).