From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map Date: Mon, 19 Jul 2021 17:52:43 +0200 Message-ID: <874kcql2r8.fsf@gnus.org> References: <89178870.2006793.1626665845848@ichabod.co-bxl> <87eebupi5k.fsf@gnus.org> <343742107.2068902.1626706305280@ichabod.co-bxl> <87k0lml3wt.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40593"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 49632@debbugs.gnu.org, Brian Leung To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 19 17:53:55 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5Vac-000AKa-Ps for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 17:53:54 +0200 Original-Received: from localhost ([::1]:58702 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5Vab-0001IQ-NN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 11:53:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53482) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5VZm-00007D-AD for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 11:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48449) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5VZm-0007np-3O for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 11:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5VZm-00081z-3d for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 11:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jul 2021 15:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49632-submit@debbugs.gnu.org id=B49632.162670997430855 (code B ref 49632); Mon, 19 Jul 2021 15:53:02 +0000 Original-Received: (at 49632) by debbugs.gnu.org; 19 Jul 2021 15:52:54 +0000 Original-Received: from localhost ([127.0.0.1]:59995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5VZd-00081b-Ll for submit@debbugs.gnu.org; Mon, 19 Jul 2021 11:52:53 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:46768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5VZc-00081O-8h for 49632@debbugs.gnu.org; Mon, 19 Jul 2021 11:52:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oqAm8KYa1xeEzd6YR7dO1yoz/y/YBzhYC5Y6fNhHkCc=; b=Kfrk+TneTeSDiEUu8ChJWiphYj YP+BM4UVDd/SEIol3PkKCS7KkaVcybQw+HI2vethWPAMMA1UbtgeR+oH6CexOonw6W9g0n7QWGEIU q78gEucVXAjls5VUCPVUwHFnuuQ9ERSVJyjv04thUwxUzZ5fM8kM8fKn8nHNGHdv/G90=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5VZU-0008TB-13; Mon, 19 Jul 2021 17:52:46 +0200 X-Now-Playing: Chuck Person's _Chuck Person's Eccojams Vol. 1_: "B1" In-Reply-To: <87k0lml3wt.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 19 Jul 2021 18:37:46 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210277 Archived-At: Juri Linkov writes: > Exactly. But this means that you need to populate a new separate map > 'gdb-repeat-map' specific to 'gdb' commands. Also I noticed that the > current name of 'gud-repeat-map' is wrong. It should be renamed to > 'gud-gdb-repeat-map'. So other debuggers could populate own repeat-maps > named e.g. 'sdb-repeat-map', 'jdb-repeat-map', 'perldb-repeat-map', etc. I see. Then Brian's patch is functionally correct, but it shouldn't be copy-and-pasted -- instead separating it out into a helper function and using it both places seems like the correct thing to do. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no