From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#50209: 27.2; eshell-command not working async Date: Thu, 26 Aug 2021 09:20:47 +0000 Message-ID: <874kbcpna4.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39108"; mail-complaints-to="usenet@ciao.gmane.io" To: 50209@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 26 11:30:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mJBi7-0009uP-JC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 11:30:11 +0200 Original-Received: from localhost ([::1]:55684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mJBi6-0007jo-Bc for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 26 Aug 2021 05:30:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJBhy-0007jZ-Ct for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 05:30:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36854) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mJBhy-00074Q-3v for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 05:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mJBhx-0006rr-VH for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 05:30:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Aug 2021 09:30:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 50209 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.162997016426324 (code B ref -1); Thu, 26 Aug 2021 09:30:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Aug 2021 09:29:24 +0000 Original-Received: from localhost ([127.0.0.1]:48400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJBhL-0006qV-MY for submit@debbugs.gnu.org; Thu, 26 Aug 2021 05:29:24 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:58948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mJBhG-0006qJ-C6 for submit@debbugs.gnu.org; Thu, 26 Aug 2021 05:29:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56278) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJBhG-0007cA-6B for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 05:29:18 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:42327) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mJBhC-0006XK-T9 for bug-gnu-emacs@gnu.org; Thu, 26 Aug 2021 05:29:17 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 7200B240026 for ; Thu, 26 Aug 2021 11:29:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1629970151; bh=21FpCjsSOJ/KzghUYex2kV2zcdg4KA3guNf0/cMmwDE=; h=From:To:Subject:Date:Autocrypt:From; b=hrhEFpnYVRBGLLj8aQyngUe0ngCCLopika0xYgfrG7/XIkLDTsL1Le8hNEkPRbWS8 hXDXw/Bh05TBz9L5za3ByQHUWOwFbxEuECYCUgIcYDRWIUvEwdO/RJmv+0XMlxYTyz ukFrXvmF8p4uZCb3gmFndj7Xafsq2PKQDGLNHUOpIekWvm2ANyoSV4NzhzLtlxITzW 3cKMQJGYTf3+o8qV12cWKRbNXvYJX6+V5Ywlo7hJWqVhLuazQi0SoGa0NAIUcAfjCc SHwhJUkJfAdlJ2+KNlTNv0Lju+wezZ5UMAAkhHSOBoGve95c/ehl4vJjWblyltt0tw rxuR3nWkjMLpQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GwHbp4DkSz9rxD for ; Thu, 26 Aug 2021 11:29:10 +0200 (CEST) Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHUBBMBCgA+FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAl8y lcICGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQDsVtFB0W75MB3QwAlTsVzFmr +S/tMKwwwOibjhNPi/OZiUC2AYfaqfVAiIHDT3RbzDe03sAJoomJkJnYVjGzQZwibCMO2+ITkMPV 2wvrd4CbgS1KCVbrltwcuK/nxPCBaHytOCZUIInnhJo5PE/h03K Received-SPF: pass client-ip=185.67.36.65; envelope-from=thievol@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212699 Archived-At: When running a command in eshell ending with "&" the command should not block emacs, it should run asynchronously. It seems it is broken since 2005: ;; 6b6f91b357f6fe2f1e0d72f046a1b8d8a2d6d8c3 ;; Author: John Wiegley ;; AuthorDate: Fri May 27 02:57:18 2005 +0000 ;; Commit: John Wiegley ;; CommitDate: Fri May 27 02:57:18 2005 +0000 To allow my eshell aliases ending with "&" working in helm-find-files I use this advice: (defun helm--advice-eshell-eval-command (command &optional input) "Fix return value when command ends with \"&\"." ;; Fix this emacs commit which is plain wrong as it returns ;; either nil or an error (double because format spec doesn't ;; always match specifier) whereas it should return either a ;; single element (CAR DELIM) or DELIM itself if the car of ;; DELIM is a process. ;; This prevent running eshell-command async when needed i.e. when ;; command ends with "&". ;; ;; 6b6f91b357f6fe2f1e0d72f046a1b8d8a2d6d8c3 ;; Author: John Wiegley ;; AuthorDate: Fri May 27 02:57:18 2005 +0000 ;; Commit: John Wiegley ;; CommitDate: Fri May 27 02:57:18 2005 +0000 (if eshell-current-command ;; we can just stick the new command at the end of the current ;; one, and everything will happen as it should (setcdr (last (cdr eshell-current-command)) (list `(let ((here (and (eobp) (point)))) ,(and input `(insert-and-inherit ,(concat input "\n"))) (if here (eshell-update-markers here)) (eshell-do-eval ',command)))) (and eshell-debug-command (with-current-buffer (get-buffer-create "*eshell last cmd*") (erase-buffer) (insert "command: \"" input "\"\n"))) (setq eshell-current-command command) (let* ((delim (catch 'eshell-incomplete (eshell-resume-eval))) (val (car-safe delim))) ;; If the return value of `eshell-resume-eval' is wrapped in a ;; list, it indicates that the command was run asynchronously. ;; In that case, unwrap the value before checking the delimiter ;; value. (if (and val (not (processp val)) (not (eq val t))) (error "Unmatched delimiter: %S" val) ;; Eshell-command expect a list like () to know if the ;; command should be async or not. (or (and (processp val) delim) val))))) In GNU Emacs 27.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.30, cairo version 1.15.10) of 2021-03-25 built on IPadS340 Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Linux Mint 19.3 Recent messages: [perl]+ Done (/usr/bin/perl -w /usr/bin/aunpack nyxt-config-master.zip) previous-line: Beginning of buffer [9 times] [mu4e] Retrieving mail...done [mu4e] Indexing... processed 7, updated 7 [mu4e] Indexing completed; processed 7, updated 7, cleaned-up 0 [mu4e] Found 1 matching message Auto-saving...done Mark set Auto-saving...done Mark set [4 times] Configured using: 'configure CFLAGS=-O8 --without-dbus --without-gconf --without-gsettings --with-mailutils --with-cairo' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 GMP Important settings: value of $LANG: fr_FR.UTF-8 locale-coding-system: utf-8-unix Major mode: Elisp Minor modes in effect: bug-reference-prog-mode: t global-undo-tree-mode: t undo-tree-mode: t global-ligature-mode: t ligature-mode: t psession-mode: t psession-savehist-mode: t global-git-gutter-mode: t git-gutter-mode: t display-time-mode: t winner-mode: t show-paren-mode: t helm-epa-mode: t helm-descbinds-mode: t helm-adaptive-mode: t helm-mode: t shell-dirtrack-mode: t helm-popup-tip-mode: t async-bytecomp-package-mode: t dired-async-mode: t minibuffer-depth-indicate-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: /home/thierry/.emacs.d/elpa/magit-20210822.529/magit-section-pkg hides /home/thierry/.emacs.d/elpa/magit-section-20210819.1119/magit-section-pkg /home/thierry/.emacs.d/elpa/async-20210823.528/async-bytecomp hides /usr/local/share/emacs/site-lisp/emacs-async/async-bytecomp /home/thierry/.emacs.d/elpa/async-20210823.528/async hides /usr/local/share/emacs/site-lisp/emacs-async/async /home/thierry/.emacs.d/elpa/async-20210823.528/async-pkg hides /usr/local/share/emacs/site-lisp/emacs-async/async-pkg /home/thierry/.emacs.d/elpa/async-20210823.528/smtpmail-async hides /usr/local/share/emacs/site-lisp/emacs-async/smtpmail-async /home/thierry/.emacs.d/elpa/async-20210823.528/dired-async hides /usr/local/share/emacs/site-lisp/emacs-async/dired-async /home/thierry/.emacs.d/elpa/async-20210823.528/async-autoloads hides /usr/local/share/emacs/site-lisp/emacs-async/async-autoloads /home/thierry/.emacs.d/elpa/seq-2.22/seq hides /usr/local/share/emacs/27.2/lisp/emacs-lisp/seq Features: (shadow epa-mail face-remap emacsbug helm-command helm-ls-hg vc-hg em-unix em-term term disp-table ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-dirs esh-var em-cmpl em-basic em-banner em-alias esh-mode helm-dabbrev qp smerge-mode helm-apt sort gnus-cite w3m-form w3m-symbol w3m timezone w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-favicon w3m-image tab-line w3m-proc w3m-util mm-archive smiley mail-extr view addressbook-bookmark mu4e-config org-mu4e mu4e-contrib eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util mu4e-patch mu4e mu4e-org mu4e-main mu4e-view mu4e-view-gnus gnus-art mm-uu mml2015 mm-view mml-smime smime dig mu4e-view-common mu4e-headers mu4e-compose mu4e-context mu4e-draft mu4e-actions ido rfc2368 smtpmail sendmail mu4e-mark mu4e-proc mu4e-utils mu4e-lists mu4e-message flow-fill hl-line mu4e-vars mu4e-meta helm-x-files helm-for-files helm-bookmark bookmark pp org-element avl-tree generator ol-eww eww mm-url url-queue ol-rmail ol-mhe ol-irc ol-info ol-gnus nnir gnus-sum shr svg dom gnus-group gnus-undo gnus-start gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo gnus-spec gnus-int gnus-range gnus-win ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m image-file tramp-archive tramp-gvfs dbus helm-firefox bug-reference naquadah-theme solar cal-dst holidays hol-loaddefs tv-utils undo-tree diff rx ligature rainbow-mode color psession frameset log-view pcvs-util pcmpl-git cl-indent ffap autocrypt-message message rmc puny rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader autocrypt-gnus gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 text-property-search mail-utils mm-util mail-prsvr autocrypt-mu4e autocrypt ietf-drums config-w3m git-gutter mule-util appt diary-lib diary-loaddefs gud anaconda-mode xref project pythonic f dash s pcomplete-extension pcmpl-unix pcmpl-gnu iterator wdired dired-extension org-config ob-gnuplot org-crypt net-utils time pcase all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons winner w3m-wget wget thingatpt wget-sysdep autotest-mode autoconf-mode paren woman man ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util init-helm helm-fd epa derived epg epg-config helm-epa helm-misc helm-imenu imenu helm-elisp-package helm-find helm-org org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities noutline outline org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat advice org-macs org-loaddefs cal-menu calendar cal-loaddefs helm-external helm-net xml url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap isearch-light helm-descbinds cus-edit wid-edit helm-ls-git vc-git diff-mode vc vc-dispatcher helm-ipython helm-elisp helm-eval edebug backtrace find-func helm-info python tramp-sh helm-adaptive helm-mode helm-files filenotify tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat shell pcomplete parse-time iso8601 time-date ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep wgrep-helm wgrep grep compile comint ansi-color ring helm-regexp format-spec helm-utils helm-help helm-types helm-extensions-autoloads helm-config helm-autoloads helm async-bytecomp helm-global-bindings helm-easymenu helm-source helm-multi-match helm-lib dired-async dired-aux dired dired-loaddefs async popup diminish cl-extra help-mode mb-depth server edmacro kmacro avoid cus-start cus-load use-package use-package-ensure use-package-delight use-package-diminish use-package-bind-key bind-key easy-mmode use-package-core info w3m-load package easymenu browse-url url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads inotify lcms2 dynamic-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 530246 231953) (symbols 48 40848 1) (strings 32 169294 34500) (string-bytes 1 10791227) (vectors 16 76495) (vector-slots 8 1628858 276768) (floats 8 1729 733) (intervals 56 5114 2125) (buffers 1000 116)) <#secure method=pgpmime mode=sign> -- Thierry