From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50431: revert-buffer doesn't preserve read-onlyness Date: Thu, 09 Sep 2021 15:16:10 +0200 Message-ID: <874katx52d.fsf@gnus.org> References: <87mtopkj2a.fsf@mail.linkov.net> <3ny289k6bd.fsf@fencepost.gnu.org> <87pmtkbcy4.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35684"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: rgm@gnu.org, 50431@debbugs.gnu.org, juri@linkov.net To: Richard Stallman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 09 15:17:21 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOJvV-0008nX-PS for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Sep 2021 15:17:13 +0200 Original-Received: from localhost ([::1]:32850 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mOJvU-0004zL-Rc for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 09 Sep 2021 09:17:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38982) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mOJvL-0004yW-1p for bug-gnu-emacs@gnu.org; Thu, 09 Sep 2021 09:17:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51121) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mOJvK-0003GZ-86 for bug-gnu-emacs@gnu.org; Thu, 09 Sep 2021 09:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mOJvK-0007AQ-0g for bug-gnu-emacs@gnu.org; Thu, 09 Sep 2021 09:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Sep 2021 13:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50431 X-GNU-PR-Package: emacs Original-Received: via spool by 50431-submit@debbugs.gnu.org id=B50431.163119338225654 (code B ref 50431); Thu, 09 Sep 2021 13:17:01 +0000 Original-Received: (at 50431) by debbugs.gnu.org; 9 Sep 2021 13:16:22 +0000 Original-Received: from localhost ([127.0.0.1]:34434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOJuf-0006fP-Lh for submit@debbugs.gnu.org; Thu, 09 Sep 2021 09:16:22 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mOJud-0006Z9-NV for 50431@debbugs.gnu.org; Thu, 09 Sep 2021 09:16:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kgs7f7AjDCPd3u/Np0eDz+wd0g+t7ostIJRjtO+r84Y=; b=irerEQQA7rGzUGqZRSl9+H+v8Q GZkmk4jAn3CdhcLXfm8gZhoPlAQjdbpuuh/IndvJSYOQhvYNAkM6Qdw6d9EYQ8IHY2DF6RLGnwSwc j7QjhS1Et3ymuwDKfQZ8A4pTK7aUXqHGV2Q2O58OOIHqGrVjLLgPDnVbK5sfBvKf8I6c=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mOJuV-0007Dx-0K; Thu, 09 Sep 2021 15:16:13 +0200 In-Reply-To: (Richard Stallman's message of "Wed, 08 Sep 2021 23:07:35 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:213907 Archived-At: Richard Stallman writes: > How about just this: keep buffer-read-only unchanged? > > If it differs from the file's permissions, almost certainly > the user changed it and will beglad of revert-buffer preserves it. Yes, but that's my point -- we need to store the file's permissions somewhere so that we can see whether buffer-read-only was set/unset because of that or not. (Since the file's permissions may change afterwards.) > The other case is that the file permissions have been changed > since visiting the file. But users won't be shocked if > revert-buffer fails to change buffer-read-only in that case, > and they will know what to do. No, people have work flows that depend on revert-buffer updating the readedness based on the file's readedness, and this would disrupt that. And there's no need to. We just have to do a small bit of programming. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no