From: "João Távora" <joaotavora@gmail.com>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 50244@debbugs.gnu.org, Philipp Stephani <p.stephani2@gmail.com>,
Theodor Thornhill <theo@thornhill.no>
Subject: bug#50244: 28.0.50; Support project-wide diagnostics reports in flymake.el
Date: Mon, 13 Sep 2021 21:53:20 +0100 [thread overview]
Message-ID: <874kao42pr.fsf@gmail.com> (raw)
In-Reply-To: <7c6bb19d-24fa-0875-a25e-8b0739901e0f@yandex.ru> (Dmitry Gutov's message of "Mon, 13 Sep 2021 23:26:06 +0300")
Dmitry Gutov <dgutov@yandex.ru> writes:
> On 13.09.2021 09:48, João Távora wrote:
>> On Mon, Sep 13, 2021 at 1:08 AM Dmitry Gutov<dgutov@yandex.ru> wrote:
>>
>>> Or maybe you will have unique "show diagnostics" buffers for every
>>> project, to be invoked manually?
>> This. But it doesn't seem impossible to make a global diagnostics
>> buffer for every project one has open.
>
> Anyway, I asked about this because because the use of global variable
> (flymake-list-only-diagnostics) seems like it would make supporting
> multiple projects at the same time more difficult.
I can't guess what you are hinting at, sorry. You can call M-x
flymake-show-project-diagnostics in two or more projects, of course, and
you'll get separate listings. I don't know if that counts as
"supporting multiple projects at the same time".
> If global diagnostics are only reported to a particular buffer,
> perhaps we could do without the global variable by tying refreshes to
> a callback.
I don't fully understand what you're suggesting, because I don't
understand your working concepts. In the new manual section "Foreign and
list-only diagnostics", you can read that the new API allows a form of
reporting diagnostics for other buffers/files in a way that is tied to a
callback. Maybe that that what you mean?
Anyway, for the specific of case of Eglot/LSP -- which reports
neighboring diagnostics _sporadically_ (i.e. not systematically) -- the
"list only" diagnostics seem more suitable. For the purposes that I
envisioned (only listing, as the name implies) a global variable also
seems suitable.
Again, I don't understand your suggestion, but if you can propose it in
the form of code it would be much better, since there would be no
ambiguity. A word of caution though: making these things work correctly
in tandem with domestic diagnostics, new file visits and buffer killings
was relatively hard. I tried many different approaches and settled on
these two ("foreign" and "list-only"). Of course if you can clearly
describe a use case where they are unsuitable, a third style may be
invented. But I would first exhaust the possibilities in these two.
In the meantime, please say if version-bumping project.el is OK. That
is the only thing holding up the merge.
João
next prev parent reply other threads:[~2021-09-13 20:53 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 0:53 bug#50244: 28.0.50; Support project-wide diagnostics reports in flymake.el João Távora
2021-08-29 23:27 ` Dmitry Gutov
2021-08-30 7:00 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-08-30 8:46 ` João Távora
2021-09-11 1:08 ` João Távora
2021-09-13 0:08 ` Dmitry Gutov
2021-09-13 6:48 ` João Távora
2021-09-13 18:03 ` João Távora
2021-09-13 19:47 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-13 20:04 ` João Távora
2021-09-13 20:21 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 8:50 ` João Távora
2021-09-14 9:21 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-14 11:34 ` João Távora
2021-09-14 12:22 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 19:22 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 20:22 ` João Távora
2021-10-23 20:50 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-09-13 20:11 ` Dmitry Gutov
2021-09-14 8:20 ` João Távora
2021-09-16 22:27 ` Dmitry Gutov
2021-09-16 23:37 ` João Távora
2021-09-13 20:26 ` Dmitry Gutov
2021-09-13 20:53 ` João Távora [this message]
2021-09-13 23:35 ` Dmitry Gutov
2021-09-14 8:43 ` João Távora
2021-09-16 22:19 ` Dmitry Gutov
2021-09-16 23:36 ` João Távora
2021-09-18 1:19 ` Dmitry Gutov
2021-09-18 9:59 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kao42pr.fsf@gmail.com \
--to=joaotavora@gmail.com \
--cc=50244@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=p.stephani2@gmail.com \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).