From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#53255: highlight-regexp should show faces with their properties applied when selecting a face Date: Fri, 21 Jan 2022 14:39:34 +0100 Message-ID: <874k5x2oo9.fsf@gmail.com> References: <87y23hl729.fsf@gnus.org> <87zgnxnwkf.fsf@gmail.com> <877db1wboq.fsf@gnus.org> <87v8ylnsc1.fsf@gmail.com> <875yqe1qxl.fsf@gnus.org> <87lezadnfg.fsf@gmail.com> <87zgnpv3jp.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24169"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: ndame , 53255@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 21 15:12:36 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nAueZ-00069G-Ta for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jan 2022 15:12:35 +0100 Original-Received: from localhost ([::1]:46598 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nAueY-00049U-Vb for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Jan 2022 09:12:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40194) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nAu94-000468-IR for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 08:40:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39570) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nAu94-0007F0-5m for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 08:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nAu94-0007r2-4N for bug-gnu-emacs@gnu.org; Fri, 21 Jan 2022 08:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Jan 2022 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53255 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 53255-submit@debbugs.gnu.org id=B53255.164277238730166 (code B ref 53255); Fri, 21 Jan 2022 13:40:02 +0000 Original-Received: (at 53255) by debbugs.gnu.org; 21 Jan 2022 13:39:47 +0000 Original-Received: from localhost ([127.0.0.1]:60706 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAu8p-0007qU-GU for submit@debbugs.gnu.org; Fri, 21 Jan 2022 08:39:47 -0500 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:55089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nAu8k-0007qC-8V for 53255@debbugs.gnu.org; Fri, 21 Jan 2022 08:39:45 -0500 Original-Received: by mail-wm1-f44.google.com with SMTP id p18so17986586wmg.4 for <53255@debbugs.gnu.org>; Fri, 21 Jan 2022 05:39:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=Hxf8hkfBWVKgWVO9YRlfDWynK/Njq/BdCqdMl6a4XHo=; b=kgKFJxktakGfwdbjTUD89oEud5j8Ei1r5hmUEsJTV807zR2ABdiZrSU6FMXFGHtYH0 EAJf9lVHv7pYQFTdfy9GhpSnM9mH9WVv4iPBqYwJac/WqcA02vnlgY2bnfm//4vlHYyV CyXB+MzPnFxtOsxmfHq08mPvDhLwTx1kpSewX+LnqK1vrylb1dbw+I4Vq+BuzuPxcJAv BnsUiDvw5xE52c4TDZZD424NBQRtokAaOF4JG6M2VTcoj8Mu7DgUJsMOCGU4jvLEpVnx DLNH/IBVStB8hLih5G2NEgPmYR38vY4ZTSi2UCkDAv15fQNQixxlvHEqv5/qlo6OwkaI 75iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Hxf8hkfBWVKgWVO9YRlfDWynK/Njq/BdCqdMl6a4XHo=; b=PYAv8yBW4K7RNZgxhv20F+WW0D8/Ah9zQkrOleJBSenSmezX1cR3ubJ+YL2Dik/Td7 UZOCURJBUqC8LNTcA3CTBLQzkA+2BP8slBQBHyAHoCPJPv0RDTro01PLnjgr0QqGz0c/ vlnCzgsFWdsjWq9exCi3TqdfjRotMUBKT/wPA5uW8AWRj+GOhwuHIJbt0tjrsalEbaRf Yk4fjmOTKyZbQeV1wQOcmAWSh6Tok9o+x+Huno7gbcSx6RxKi6uGcufdhJXqGw54diAh CD14IzvNGVOVQnaYK4/qaQ49fPNhfGsH1+nYopWK2A4ZA8Z5YHdfji7WlTtTXC/joljt 02cA== X-Gm-Message-State: AOAM5312S2JeINEO3JMY31Ls463I+bkLCLai0AdHAuuiyF34P3ejUEou IRw21bf2f+kpamA1PAw0PsbFmaj0TpU= X-Google-Smtp-Source: ABdhPJw1dGVQ9zn/erylKY8qU17kTWO/3/6OE5F4dwg14N+EQIpmRX+AjhvvLr9C9ZCfpXx1R9gt1Q== X-Received: by 2002:adf:f9cb:: with SMTP id w11mr3987478wrr.106.1642772376006; Fri, 21 Jan 2022 05:39:36 -0800 (PST) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id m19sm5625426wmq.6.2022.01.21.05.39.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jan 2022 05:39:35 -0800 (PST) In-Reply-To: <87zgnpv3jp.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 21 Jan 2022 10:30:50 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224774 Archived-At: Lars Ingebrigtsen writes: > K=C3=A9vin Le Gouguec writes: > >> Great! A couple of nits: >> >> 1. Is there a reason why you went with (list "SAMPLE\t" "" face) instead >> of (list face "" \tSAMPLE)? "(elisp) Completion Variables" says that >> the completion goes first, then the prefix, then the suffix; I don't >> know how hard a rule that is, however I do think the latter option >> fares better when faced with variable heights. > > It looked really bad with the face names first, since they have wildly > differing lengths. =E2=80=A6 and so the samples would get misaligned? (Trying to make sure I understand the issue) IMO that's less annoying than the names being misaligned (since that throws me off slightly when I'm looking them over to figure out what I need to type), but YMMV. (I'm still intrigued by the documentation of :affixation-function though: it seems to me that it asks for (list COMPLETION PREFIX SUFFIX), but obviously your code works=E2=80=A6) >> 2. As you can see on the screenshots, the prompt shows the default face >> twice. I think fixing this is as simple as removing format-prompt >> (patch also attached), but then again, I'm not thinking straight this >> evening it seems. > > (hi-lock-read-face-name) doesn't seem to display the default twice in an > emacs -Q? It does here =F0=9F=98=95 ./src/emacs -Q M-: emacs-repository-version "1228ec3e1d7657c9eb50184719410f37ed0eb750" M-: (hi-lock-read-face-name) Highlight using face (default hi-yellow) (default hi-yellow):