From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#48598: 28.0.50; buffer-naming collisions involving bouncers in ERC Date: Wed, 27 Apr 2022 14:28:52 +0200 Message-ID: <874k2epv5n.fsf__23705.646912434$1651062623$gmane$org@gmx.de> References: <875yzakzvi.fsf@neverwas.me> <87bkxaeyuw.fsf@neverwas.me> <87zgkisetn.fsf@cassou.me> <87ee1ucvv3.fsf@neverwas.me> <87tuaqs9br.fsf__15054.4815858424$1650295523$gmane$org@cassou.me> <87k0bmbage.fsf@gmx.de> <878rrz268v.fsf@neverwas.me> <87czha3oc5.fsf_-_@gmx.de> <87v8v2o9l4.fsf@neverwas.me> <87k0bh31pt.fsf@gmx.de> <8735i5nql8.fsf@neverwas.me> <87bkws2ksn.fsf@gmx.de> <87czh5z7ui.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6791"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Damien Cassou , 48598@debbugs.gnu.org, Ted Zlatanov , emacs-erc@gnu.org, Sam Steingold To: "J.P." Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Apr 27 14:30:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1njgoB-0001W9-JO for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Apr 2022 14:30:15 +0200 Original-Received: from localhost ([::1]:55404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1njgoA-0002XO-1N for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Apr 2022 08:30:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1njgnz-0002XD-AL for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 08:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47597) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1njgnz-0003sN-14 for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 08:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1njgny-0005to-Sf for bug-gnu-emacs@gnu.org; Wed, 27 Apr 2022 08:30:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <875yzakzvi.fsf@neverwas.me> Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Apr 2022 12:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48598 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 48598-submit@debbugs.gnu.org id=B48598.165106254522573 (code B ref 48598); Wed, 27 Apr 2022 12:30:02 +0000 Original-Received: (at 48598) by debbugs.gnu.org; 27 Apr 2022 12:29:05 +0000 Original-Received: from localhost ([127.0.0.1]:41494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njgn2-0005s1-WF for submit@debbugs.gnu.org; Wed, 27 Apr 2022 08:29:05 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:37967) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1njgn0-0005r2-Ss for 48598@debbugs.gnu.org; Wed, 27 Apr 2022 08:29:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1651062534; bh=EyaWfnBIfdkb+BYlGw8PpWCu1KX+tvxtfnKoMb8v/xk=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date; b=eVOC7bPIwu/Q+ryZ1jOBpzszDobjjxvdkVXrIGfbnwaECU90QiBLFK9jQLhnhHkAh AKh+XggNVyrC5RxyImNNcTiM4+4Z0bgZFfvV1ZmImSiLy+wqWg8d7htAZ5sA6UI/AG jwyslpSj/AoEVk/TJWpJAS+wqW6zjqu/TVCBSovg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.149.5]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MvbBk-1o38e80rCA-00scrX; Wed, 27 Apr 2022 14:28:54 +0200 X-Provags-ID: V03:K1:gMW2oGKGtBCTmZQCezwNtc9vSzQki/1RKLY9FDhoTLWgQDfm52G 5dBDsAHXJptIM8XpL1Ft4YC7LEieRGkpkAivd71vHPXX2ZuCNVeeVh4P5Ohft9OqiFDNTi+ ohgSbxeMJjhrxfw3vVAcUF8CwZ3Sysw3/qlfrEj+cejlQ/iatRomoRoYTG0mesa/dDq6fqg 5Eq3KDRv+mpHeKUix0J4w== X-UI-Out-Filterresults: notjunk:1;V03:K0:hQfUJCxt7zM=:K+nI2NcmsNp872nUkv90u6 yyANjS4D6p4cDUzStkqjLs+jStbtYVBZUjGDDMUHnn/y6HLOi/AnZH/DWjatFdDAkT+EVKbOq h009vcBsHrvS7V05GeZoassmldpRq0Z/BsInZNwpA/PZDcdGtH+le9FSzU27L9fs6DYaQgM4S QJAEuKGEks8enQLDX0FoRuPaLL4510CyWj8l3GD7scXiHVN21LkPJZEUDSiRUDjfbuuzPHUP2 uyMwLWxiAeRhMoAPOQLOAKyjn9zEXG29N4H2UpeHbFa0hPpXT8jOjHo3PZp66ahS/pJ3Ncb03 u9qd/8chcd1mPsljQY9CBA1lqT/I0bDrd1ybYD3xC/4DAd1C8ThEkHJ4IHiyI2giwBOLKZEzY 7fe1p3u1993eaWlZl6xnLBgo0q0D//yza4zpckw1seRxhm9f7MPAjIGa+fjBlsL7PXNDHmTHE 1MLQBQvzRqu02sM5JliETQy3mE3ASJKDzubZQLwizeBlFMho+ReZOz9CtV69MgreysAWEMEvg VWgrFwEoVPRHWgkXLTLZQ4xYILpKT99hEDEC1qEyGg61awXfBwrcwaUXof+unfGu0+pxNIJcc ECIDOGvbC/BM++rwc6x263WayZlIcB7+iBRAiRUZ38WLII2as9zHp5S9Hb4WYl/BC/2fE54K+ gDB+Xf/Abi5EuVBeY9PjazzECx/twnTKGbxWScT51ShDSbMHmubBz720purun563pW15W8crv 6vNk+4UXiR8nTBbJYN+C8PeI1ZtdfG3doUn0OQxMf1KbTYLw/rsWV6/Rwby8hbbnlENKDc/C X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230779 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "J.P." writes: > Hi Michael, Hi, I'm now at erc 5.4.1.48598.0.20220425.270. Btw, it is a little bit tricky to decide which is the recent version, because you have two lines of patches: erc5.4.1.48598.* and erc 5.4.1.49860.*. The package manager always offers me to upgrade to the most recent 5.4.1.49860.* version, and I must pick then the most recent 5.4.1.48598.* version (hoping it is the proper decision). It might be more obvious to me if you could offer both erc-48598 and erc-49860 packages in parallel. > Even without the aforementioned packaging snafu, the erc-d/ situation is > definitely confusing. That subdir is supposed to house the fake IRC > server that all the "erc-scenarios"-based tests depend on. I initially > tried going with erc-d-tests.el instead of erc-d-self.el for the > server's own tests but hit a Make error because a corresponding library > didn't exist under lisp/erc/. Perhaps I should have tinkered further. Indeed, test/Makefile fires an error then. I've pushed a fix to master, it shall work now with the file name erc-d-tests.el. > And while moving erc-d/ (minus the tests) under lisp/erc/ would make > things easier in terms of the layout, I'd rather not add more bulk to > Emacs proper without good reason, even though adding it wouldn't really > cause any problems (assuming the symbols are renamed using the internal > "--" convention). Yes. Test data and test Elisp files belong to the test/ directory. > For now, I've moved it to test/lisp/erc/erc-scenarios/resources/erc-d/ > and am artificially piggybacking on check-lisp-erc-erc-scenarios via > test/lisp/erc/erc-scenarios/erc-scenarios-meta.el, which does nothing > but load erc-d-self.el (as convoluted as that sounds). Where is this needed? I don't see any load of erc-scenarios-meta.el. And even if you need it somewhere, I believe it belongs into the resources/ subdirectory. > That environment variable stuff has been driving me bananas! Yours is > much nicer (thanks) and has magically nudged me toward adopting what's > hopefully a less offensive layout, which currently looks like this: > > test/lisp/erc/ > =E2=94=9C=E2=94=80=E2=94=80 erc-tests.el > ... > =E2=94=94=E2=94=80=E2=94=80 erc-scenarios/ > =E2=94=9C=E2=94=80=E2=94=80 erc-scenarios-.el > =E2=94=9C=E2=94=80=E2=94=80 erc-scenarios-meta.el > ... > =E2=94=94=E2=94=80=E2=94=80 resources/ > =E2=94=9C=E2=94=80=E2=94=80 /... > ... > =E2=94=9C=E2=94=80=E2=94=80 erc-d/ > =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94=80 erc-d.el > =E2=94=82=C2=A0=C2=A0 ... > =E2=94=82=C2=A0=C2=A0 =E2=94=9C=E2=94=80=E2=94=80 erc-d-self.el > =E2=94=82=C2=A0=C2=A0 =E2=94=94=E2=94=80=E2=94=80 erc-d-self-re= sources/... > =E2=94=94=E2=94=80=E2=94=80 erc-scenarios-common.el Looks OK to me except the location of erc-scenarios-meta.el. >> I would mark the tests erc--auth-source-search--pass-* with >> ":tags '(:unstable)" until the problems in auth-source-pass are solved. > > Oh, I was going to remove those tests completely because they depend on > hacks from lisp/erc/erc-compat.el that I've since deleted. IOW, they're > guaranteed to fail (and so have been disabled). But I left them hanging > around for now in case you had something else in mind. Well, there seems to be a cut'n'waste error in erc-services-tests.el. See this fix: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Transfer-Encoding: quoted-printable *** /home/albinus/.emacs.d/elpa/erc-5.4.1.48598.0.20220425.270/test/erc-se= rvices-tests.el.~1~ 2022-04-26 08:38:20.106415131 +0200 =2D-- /home/albinus/.emacs.d/elpa/erc-5.4.1.48598.0.20220425.270/test/erc-= services-tests.el 2022-04-27 14:25:08.822978791 +0200 *************** *** 465,471 **** ((symbol-function 'auth-source-pass-entries) (lambda () (mapcar #'car store)))) ! (erc-services-tests--auth-source-announced #'erc--auth-source-search)))) (ert-deftest erc--auth-source-search--pass-announced () =2D-- 465,471 ---- ((symbol-function 'auth-source-pass-entries) (lambda () (mapcar #'car store)))) ! (erc-services-tests--auth-source-standard #'erc--auth-source-search)))) (ert-deftest erc--auth-source-search--pass-announced () --=-=-= Content-Type: text/plain > Sorry again for the packaging snafu. Despite all appearances, I really > do value your time, so please don't let this interfere (too much) with > whatever else is on your plate. You've already helped me so much, and I > owe you a ton! No need to sorry! That's what reviews are good for :-) > J.P. Best regards, Michael. --=-=-=--