From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56210: 29.0.50; Keyboard macros do not trigger after-change-functions Date: Tue, 28 Jun 2022 13:31:23 +0200 Message-ID: <874k05t46s.fsf@gnus.org> References: <8735ftklkr.fsf@gnus.org> <83pmiwa7y3.fsf@gnu.org> <83fsjralpq.fsf@gnu.org> <70bed502-1c51-8cd6-68b1-16c4e3c410e0@rhansen.org> <831qva82sz.fsf@gnu.org> <327ead91-4b3f-6177-b3a1-4f1db57c3e85@rhansen.org> <83zghy6n6b.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10116"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56210@debbugs.gnu.org, Richard Hansen To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 28 13:33:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o69T5-0002Sn-6n for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jun 2022 13:33:19 +0200 Original-Received: from localhost ([::1]:36424 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o69T3-0008I2-9t for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 28 Jun 2022 07:33:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o69So-0008FU-8z for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 07:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60214) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o69So-0005qJ-0i for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 07:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o69Sn-000325-UC for bug-gnu-emacs@gnu.org; Tue, 28 Jun 2022 07:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Jun 2022 11:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56210 X-GNU-PR-Package: emacs Original-Received: via spool by 56210-submit@debbugs.gnu.org id=B56210.165641592210234 (code B ref 56210); Tue, 28 Jun 2022 11:33:01 +0000 Original-Received: (at 56210) by debbugs.gnu.org; 28 Jun 2022 11:32:02 +0000 Original-Received: from localhost ([127.0.0.1]:54104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o69Rl-0002bD-UL for submit@debbugs.gnu.org; Tue, 28 Jun 2022 07:32:01 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o69Rk-0002W9-IU for 56210@debbugs.gnu.org; Tue, 28 Jun 2022 07:31:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Tp9HtnfKT9YLDSkVwY7Qd6M9CxV6G8dnjKXDZuTS+EM=; b=g7JE8P/ne0MkmXkbnlSTsQVcq4 GG+NF7bHBmWBeSy9+lGXAzpBCxKnqO5OeOBS4891+WnS7nZsLELKZc+i10O1sWiJBpMd4JPvPNze9 hUntQ7VKwlhCvK1ia2TVW21fyeT5bA+GlZmLyZHIqrviOhzGptBe2IwXnGFDT0oMStc8=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o69RD-0001YO-UE; Tue, 28 Jun 2022 13:31:34 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEW3qJLax6z03774 5MXo1LaQhHNIQDv///+tiry0AAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YGHAsWHJ2KScEAAAGkSURB VDjLnZQxdoQwDEShcOp4VxcIcICE5ALy6gBOATWNuf8RMpIMIbtsExfA0/doLFmPpu0+T1fTdo8L 8a8TMCSg8Q/oLcnYj50pxBZjX5h0NU0rBgaKHGMUuc2rr5JHUyDKkWLcQJmLAzYJUQUlh0VBEtZM yHWZneT4DY8mMXIxEXFqpkkTrUUVCoiZd48QSnGFIBOyMV8NTNlPBYDNsJeqQLoyeSoFJJFckeGR 3ZxYj8tVUX4BGkIDHr2BZd1SDcLeLldkVVVzrQT+7hF2gP04FJNc54LYCx61QBav8Taj8EVli5qj h4irx2X201YFgBzMQw478DCxH3cKWyrcHQrHa7/BdXknU3A0xfUeoBvW4YNCU5HuJ61wV0xujriO glAK1kL00C6KENIhYU6vTRtjg+9UAVw0oY4ettTZBdD70PkRTCk6I6kC7NPbSIIhtQboAH+YAvVp Njs4OTPwuDbA96A/KLYWwywlB3X/Fh5kGPpnHheAvIHjhssIEM8U3VPw9j+wV8C8fQ0KtHn3Pwdh BSd/EwN0AszjoEgj/if29f4Dg7Xeqqs2rt8AAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDYtMjhU MTE6MjI6MjgrMDA6MDB19bP8AAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA2LTI4VDExOjIyOjI4 KzAwOjAwBKgLQAAAAABJRU5ErkJggg== X-Now-Playing: Alabama Sacred Harp Singers's _Anthology of American Folk Music: Social Music (2)_: "Present Joys" In-Reply-To: <83zghy6n6b.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 27 Jun 2022 20:17:32 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:235525 Archived-At: Eli Zaretskii writes: >> I thought I had a `(should (null inhibit-modification-hooks))` at >> some point in the past to rule that out, but I must not have had >> that inside the `with-current-buffer-window'. >> >> Perhaps the documentation should be updated to indicate that the >> modification hooks are inhibited? I can cook up a patch. > > Is it really a good idea? In general, all the 'with-SOMETHING' macros > are likely to inhibit modification hooks, since they erase the > temporary buffers high and low. It's really surprising that with-current-buffer-window does this -- it sounds like a general variation on with-selected-window, but it's not: It's meant to be used to pop up help buffers, and this should be documented. with-current-buffer/with-selected-window etc do not inhibit any hooks in the buffers them handle. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no