From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#57334: 28.1; Fix wdired with (dired '(dir f1 f2 ...)) Date: Tue, 23 Aug 2022 03:01:59 +0200 Message-ID: <874jy3kc1k.fsf@web.de> References: <878rng23aq.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2065"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57334@debbugs.gnu.org To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 23 03:03:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQIK2-0000OH-QS for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 23 Aug 2022 03:03:14 +0200 Original-Received: from localhost ([::1]:53454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQIK1-0008Rs-ND for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Aug 2022 21:03:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQIJr-0008Qm-3O for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 21:03:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQIJq-0004tT-LO for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 21:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQIJq-0004Fc-Gs for bug-gnu-emacs@gnu.org; Mon, 22 Aug 2022 21:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Aug 2022 01:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57334 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 57334-submit@debbugs.gnu.org id=B57334.166121653216263 (code B ref 57334); Tue, 23 Aug 2022 01:03:02 +0000 Original-Received: (at 57334) by debbugs.gnu.org; 23 Aug 2022 01:02:12 +0000 Original-Received: from localhost ([127.0.0.1]:42106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQIJ1-0004EE-VU for submit@debbugs.gnu.org; Mon, 22 Aug 2022 21:02:12 -0400 Original-Received: from mout.web.de ([212.227.15.4]:60711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQIIx-0004Dw-Qv for 57334@debbugs.gnu.org; Mon, 22 Aug 2022 21:02:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1661216521; bh=GCAWWOd+wDv6m0fon7h0Y5FmNoKQnEtVtwindsjp6T0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=fsTNH+KoKN4aos6DwAtZsQtRYdQab6xkYp1EzQ3vi1O1j3A1PKCLa/ph3XOow91M0 WZmeg5Pbfpe7BgRJ8Q+Gu7G+7cww9njhwfpa0iNAq45CqAciWUlrb2rIQ9IbBXMokE q1BHj4P1I93jax3OQEVEkMhakPW9IJp3UGw08lbQ= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.57.248.18]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MsrhU-1pJVS43Mts-00tO5W; Tue, 23 Aug 2022 03:02:00 +0200 In-Reply-To: <878rng23aq.fsf@posteo.net> (Thierry Volpiatto's message of "Mon, 22 Aug 2022 06:23:52 +0000") X-Provags-ID: V03:K1:w+l+uVUmhjjKzd/xd9G2CB29nh7ZNr+jRGDDHieVnXysjqd+bxT XGyQQxdi/FXy/t+rPnlAtc2NZ8UEhjscvatUpkUDp1X6IQ3nSXxX8h0uf86ryASdo+Q2xXP nnHEn+KXoT3ehGahWmwkdfUn2AM7eOM9ti4ww0hrb3/6lh7wH2VsgWfLLCvK34EKdCtU7dW zcfs32nIQYzP7O7g42C9A== X-UI-Out-Filterresults: notjunk:1;V03:K0:mTchfHw5V7Y=:DL6Jj2/X7PTZXtOy0bLlB0 S98UTuVobQ+RW3nOGjJPwIq9SzDu8fVrtgwszoKb1ItiPSk5RpqpsIgNOVGFRDGspJSdxEQ3g tdX07PpSqc4sQL1WNPx203O+QyZn1c3hH6310Z32mi7mM9goyY5Y7OO3733OnEps40SkozYSQ Kvp4+Oj/aWuHCySA4om+t5TO/loi23Rz4TnsVf13TYJswIGY46a8EB66funjQy35WWDM4U29y aRX9ZEvXxI6fgicnq+kmbM9zUSdYztKRBlbMWhk94H8fWH20DZXyTSh05sT9wsUcrHbo8JciC xZkT1eq2ud80V+4Zpp8DzsEsCjUk0LMMEsiY/tjy19sH01CP7Xi+67R/lVTYdZ+SOeRPxJnM6 /2KifZzu5CKblfGqaJjxP/Z/v9lNuH3mhzB7hi6VKN7n0rvFx0DV7y9z7DMxdWNSeGRxIPyui smllh7u8p0u2a6a5xOMx6/BHjeiw8Keja8RWibDT/C+KUMcK7VGeJFsDJVFYaZ+7TKqXL9SeQ 7Wfh5YOF+7Alt7bulTvgUA6hEJda4x0CltyQ8E2r/PPUzZWhI8FMqCsD+YEJn8NyWZCt7iu0a xL5XjthCcIXCgtKmXoEEEMkf8h/r6jSZltpwrBphVDaliiKVbeP/YFgNpvhrX9Nm22RDGsJ2B VF3KBfaq3j+EIsuOHnWz9y30YjJgBS+PbftsdItL3e3QG7t74Cg7SMelS+IDgoHq01R6SAdfs 4sq/tVexXlbPaUmqOX5ze9wkcnJBxN/IbGWzs2ePo6oFq2l3srk9dz+DXNt6i4aHOkk6F3Xd X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240485 Archived-At: Thierry Volpiatto writes: > Hello Emacs, > > there is an action in helm that allows creating a dired buffer with > marked files for further editing with wdired. > For this I have to call dired with its dirname argument as a list: > (dired ' (dir f1 f2 f3)) > Unfortunately this is broken since years and until now I had to use an advice > to fix it. > The advice is working up to emacs-28.1 but now it becomes difficult to > write an advice compatible with all emacs versions, here is a patch to > apply on 29.0.50. I do also have such an advice. My approach is to make `wdired-finish-edit' _not_ call `revert-buffer'. This is faster and doesn't mess the original file order. AFAIR one also has to avoid the `dired-advertize' call for such buffers, else they are confused with normal buffers displayed the DIR. And file changes are not propagated to other dired buffers, that's also something I do manually. And a different thing is that changes in other dired buffers are not propagated to these special file-list buffers. This is a tricky matter. I think fixing all problems will require some work. They are not independent. Michael.