From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#58363: [PATCH 1/3] Use xsignal1 as required by argument type Date: Sat, 22 Oct 2022 12:45:02 +0200 Message-ID: <874jvwrvbl.fsf@bernoul.li> References: <87v8orky2u.fsf@gnus.org> <20221021210636.13329-1-jonas@bernoul.li> <20221021210636.13329-2-jonas@bernoul.li> <83czakuziw.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12590"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58363@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 22 13:46:34 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1omCxV-00035h-PI for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Oct 2022 13:46:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1omC10-0006xV-8E; Sat, 22 Oct 2022 06:46:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1omC0w-0006w4-Tg for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 06:46:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1omC0w-0004eV-MG for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 06:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1omC0w-0000Wa-C8 for bug-gnu-emacs@gnu.org; Sat, 22 Oct 2022 06:46:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Oct 2022 10:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58363 X-GNU-PR-Package: emacs Original-Received: via spool by 58363-submit@debbugs.gnu.org id=B58363.16664355081947 (code B ref 58363); Sat, 22 Oct 2022 10:46:02 +0000 Original-Received: (at 58363) by debbugs.gnu.org; 22 Oct 2022 10:45:08 +0000 Original-Received: from localhost ([127.0.0.1]:39781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omC04-0000VL-46 for submit@debbugs.gnu.org; Sat, 22 Oct 2022 06:45:08 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:58058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1omC01-0000VC-Ua for 58363@debbugs.gnu.org; Sat, 22 Oct 2022 06:45:06 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 898B8162AB; Sat, 22 Oct 2022 12:45:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1666435503; bh=Px7mWrj4E3AXf01U1LwA5TDJ FzQOhrwFybAK5Ud1EvQ=; b=yL9spEb76udNAk5c4SpMAiiNQTAp4n0gAjWngelm PgCtZGeJHJLwMsbyQIhOdAXJ5Ysy4ioTlYX9M6/KBmTG9ESDwyM0Ey4B1/5mL/2J xd2TWAv4EJVD5oKvaVTib3brFygC0pThJr+Ry9YffSOFyvcv8t8hXDPz/5sNTJZy 99s= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id 0p0csr1BUy0Y; Sat, 22 Oct 2022 12:45:03 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 5706C163CB; Sat, 22 Oct 2022 12:45:03 +0200 (CEST) In-Reply-To: <83czakuziw.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246036 Archived-At: Eli Zaretskii writes: >> From: Jonas Bernoulli >> Date: Fri, 21 Oct 2022 23:06:34 +0200 >> >> * src/sqlite.c (sqlite-load-extension): Use xsignal1. >> --- >> src/sqlite.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/sqlite.c b/src/sqlite.c >> index 1526e344e5..7861a699f4 100644 >> --- a/src/sqlite.c >> +++ b/src/sqlite.c >> @@ -675,7 +675,7 @@ DEFUN ("sqlite-load-extension", Fsqlite_load_extension, >> } >> >> if (!do_allow) >> - xsignal (Qerror, build_string ("Module name not on allowlist")); >> + xsignal1 (Qerror, build_string ("Module name not on allowlist")); > > Why Qerror here and not Qsqlite_error? And if the more general Qerror > is deliberate, then why not Qmodule_load_failed, for instance? This commit just fixes a bug. Qsqlite_error is introduced in the next commit.